https://github.com/apache/spark
Revision a5f14f4b454d99e04118a10b9a579375114c3c25 authored by zzzzming95 on 03 August 2022, 12:22:55 UTC, committed by Hyukjin Kwon on 03 August 2022, 12:23:32 UTC
### What changes were proposed in this pull request?
fix `BinaryFileFormat` filter push down bug.
Before modification, when Filter tree is:
````
-Not
- - IsNotNull
````
Since `IsNotNull` cannot be matched, `IsNotNull` will return a result that is always true (that is, `case _ => (_ => true)`), that is, no filter pushdown is performed. But because there is still a `Not`, after negation, it will return a result that is always False, that is, no result can be returned.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
test suit in `BinaryFileFormatSuite`
```
testCreateFilterFunction(
Seq(Not(IsNull(LENGTH))),
Seq((t1, true), (t2, true), (t3, true)))
```
Closes #37350 from zzzzming95/SPARK-39900.
Lead-authored-by: zzzzming95 <505306252@qq.com>
Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit a0dc7d9117b66426aaa2257c8d448a2f96882ecd)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
1 parent 7e0a5ef
Tip revision: a5f14f4b454d99e04118a10b9a579375114c3c25 authored by zzzzming95 on 03 August 2022, 12:22:55 UTC
[SPARK-39900][SQL] Address partial or negated condition in binary format's predicate pushdown
[SPARK-39900][SQL] Address partial or negated condition in binary format's predicate pushdown
Tip revision: a5f14f4
| File | Mode | Size |
|---|---|---|
| .github | ||
| R | ||
| assembly | ||
| bin | ||
| binder | ||
| build | ||
| common | ||
| conf | ||
| core | ||
| data | ||
| dev | ||
| docs | ||
| examples | ||
| external | ||
| graphx | ||
| hadoop-cloud | ||
| launcher | ||
| licenses | ||
| licenses-binary | ||
| mllib | ||
| mllib-local | ||
| project | ||
| python | ||
| repl | ||
| resource-managers | ||
| sbin | ||
| sql | ||
| streaming | ||
| tools | ||
| .asf.yaml | -rw-r--r-- | 1.1 KB |
| .gitattributes | -rw-r--r-- | 130 bytes |
| .gitignore | -rw-r--r-- | 1.5 KB |
| CONTRIBUTING.md | -rw-r--r-- | 997 bytes |
| LICENSE | -rw-r--r-- | 13.1 KB |
| LICENSE-binary | -rw-r--r-- | 22.7 KB |
| NOTICE | -rw-r--r-- | 2.0 KB |
| NOTICE-binary | -rw-r--r-- | 56.3 KB |
| README.md | -rw-r--r-- | 4.4 KB |
| appveyor.yml | -rw-r--r-- | 2.6 KB |
| pom.xml | -rw-r--r-- | 121.3 KB |
| scalastyle-config.xml | -rw-r--r-- | 20.0 KB |
Computing file changes ...
