Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision a6093ad7fc4962099d2d723bcca72f8175b58c82 authored by Leonard Crestez on 31 January 2019, 20:59:50 UTC, committed by Bjorn Helgaas on 31 January 2019, 20:59:50 UTC 
PCI: imx: Fix probe failure without power domain
 
On chips without a separate power domain for PCI (such as 6q/6qp) the
imx6_pcie_attach_pd() function incorrectly returns an error.

Fix by returning 0 if dev_pm_domain_attach_by_name() does not find
anything.

Fixes: 3f7cceeab895 ("PCI: imx: Add multi-pd support")
Reported-by: Lukas F.Hartmann <lukas@mntmn.com>
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent d2fd6e8
Raw File
Tip revision: a6093ad7fc4962099d2d723bcca72f8175b58c82 authored by Leonard Crestez on 31 January 2019, 20:59:50 UTC
PCI: imx: Fix probe failure without power domain
Tip revision: a6093ad
TODO 
Do the ax25_list_lock, ax25_dev_lock, linkfail_lockreally, ax25_frag_lock and
listen_lock have to be bh-safe?

Do the netrom and rose locks have to be bh-safe?

A device might be deleted after lookup in the SIOCADDRT ioctl but before it's
being used.

Routes to a device being taken down might be deleted by ax25_rt_device_down
but added by somebody else before the device has been deleted fully.

The ax25_rt_find_route synopsys is pervert but I somehow had to deal with
the race caused by the static variable in it's previous implementation.

Implement proper socket locking in netrom and rose.

Check socket locking when ax25_rcv is sending to raw sockets.  In particular
ax25_send_to_raw() seems fishy.  Heck - ax25_rcv is fishy.

Handle XID and TEST frames properly.
back to top