Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
	warn: passing zero to 'ERR_PTR'

If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.

Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
History
File Mode Size
agp
hw_random
ipmi
mwave
pcmcia
tpm
xilinx_hwicap
xillybus
Kconfig -rw-r--r-- 15.5 KB
Makefile -rw-r--r-- 1.4 KB
adi.c -rw-r--r-- 4.5 KB
apm-emulation.c -rw-r--r-- 17.3 KB
applicom.c -rw-r--r-- 24.1 KB
applicom.h -rw-r--r-- 2.5 KB
bsr.c -rw-r--r-- 8.2 KB
ds1620.c -rw-r--r-- 8.4 KB
dsp56k.c -rw-r--r-- 12.2 KB
dtlk.c -rw-r--r-- 16.3 KB
hangcheck-timer.c -rw-r--r-- 5.1 KB
hpet.c -rw-r--r-- 24.0 KB
lp.c -rw-r--r-- 27.4 KB
mem.c -rw-r--r-- 16.3 KB
misc.c -rw-r--r-- 6.8 KB
mspec.c -rw-r--r-- 7.1 KB
nsc_gpio.c -rw-r--r-- 3.5 KB
nvram.c -rw-r--r-- 13.5 KB
nwbutton.c -rw-r--r-- 7.9 KB
nwbutton.h -rw-r--r-- 1.1 KB
nwflash.c -rw-r--r-- 12.8 KB
pc8736x_gpio.c -rw-r--r-- 8.8 KB
powernv-op-panel.c -rw-r--r-- 5.1 KB
ppdev.c -rw-r--r-- 20.2 KB
ps3flash.c -rw-r--r-- 10.0 KB
random.c -rw-r--r-- 67.1 KB
scx200_gpio.c -rw-r--r-- 3.1 KB
sonypi.c -rw-r--r-- 40.4 KB
tb0219.c -rw-r--r-- 7.1 KB
tlclk.c -rw-r--r-- 23.3 KB
toshiba.c -rw-r--r-- 12.4 KB
ttyprintk.c -rw-r--r-- 4.8 KB
uv_mmtimer.c -rw-r--r-- 5.5 KB
virtio_console.c -rw-r--r-- 54.4 KB

back to top