Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
	warn: passing zero to 'ERR_PTR'

If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.

Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
History
File Mode Size
Kconfig -rw-r--r-- 2.6 KB
Makefile -rw-r--r-- 398 bytes
cf-fsi-fw.h -rw-r--r-- 4.7 KB
fsi-core.c -rw-r--r-- 32.6 KB
fsi-master-aspeed.c -rw-r--r-- 15.9 KB
fsi-master-ast-cf.c -rw-r--r-- 37.0 KB
fsi-master-gpio.c -rw-r--r-- 20.9 KB
fsi-master-hub.c -rw-r--r-- 7.3 KB
fsi-master.h -rw-r--r-- 5.8 KB
fsi-occ.c -rw-r--r-- 14.6 KB
fsi-sbefifo.c -rw-r--r-- 26.6 KB
fsi-scom.c -rw-r--r-- 14.6 KB

back to top