Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
	warn: passing zero to 'ERR_PTR'

If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.

Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
History
File Mode Size
Kconfig -rw-r--r-- 983 bytes
Makefile -rw-r--r-- 409 bytes
arpc.h -rw-r--r-- 1.3 KB
bundle.c -rw-r--r-- 5.4 KB
connection.c -rw-r--r-- 22.6 KB
control.c -rw-r--r-- 13.9 KB
core.c -rw-r--r-- 8.0 KB
debugfs.c -rw-r--r-- 515 bytes
es2.c -rw-r--r-- 33.4 KB
greybus_trace.h -rw-r--r-- 12.1 KB
hd.c -rw-r--r-- 5.6 KB
interface.c -rw-r--r-- 28.9 KB
manifest.c -rw-r--r-- 14.4 KB
module.c -rw-r--r-- 4.9 KB
operation.c -rw-r--r-- 35.0 KB
svc.c -rw-r--r-- 34.8 KB
svc_watchdog.c -rw-r--r-- 4.4 KB

back to top