Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
	warn: passing zero to 'ERR_PTR'

If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.

Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
History
File Mode Size
Kconfig -rw-r--r-- 3.5 KB
Makefile -rw-r--r-- 931 bytes
b43_pci_bridge.c -rw-r--r-- 1.8 KB
bridge_pcmcia_80211.c -rw-r--r-- 2.8 KB
driver_chipcommon.c -rw-r--r-- 17.7 KB
driver_chipcommon_pmu.c -rw-r--r-- 22.0 KB
driver_chipcommon_sflash.c -rw-r--r-- 4.1 KB
driver_extif.c -rw-r--r-- 5.0 KB
driver_gige.c -rw-r--r-- 7.3 KB
driver_gpio.c -rw-r--r-- 11.7 KB
driver_mipscore.c -rw-r--r-- 8.8 KB
driver_pcicore.c -rw-r--r-- 18.8 KB
embedded.c -rw-r--r-- 6.2 KB
host_soc.c -rw-r--r-- 4.5 KB
main.c -rw-r--r-- 30.3 KB
pci.c -rw-r--r-- 36.7 KB
pcihost_wrapper.c -rw-r--r-- 2.9 KB
pcmcia.c -rw-r--r-- 19.1 KB
scan.c -rw-r--r-- 10.2 KB
sdio.c -rw-r--r-- 15.5 KB
sprom.c -rw-r--r-- 5.2 KB
ssb_private.h -rw-r--r-- 7.0 KB

back to top