Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:
drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
warn: passing zero to 'ERR_PTR'
If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.
Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
| File | Mode | Size |
|---|---|---|
| iscsi | ||
| loopback | ||
| sbp | ||
| tcm_fc | ||
| Kconfig | -rw-r--r-- | 1.4 KB |
| Makefile | -rw-r--r-- | 939 bytes |
| target_core_alua.c | -rw-r--r-- | 59.1 KB |
| target_core_alua.h | -rw-r--r-- | 6.0 KB |
| target_core_configfs.c | -rw-r--r-- | 97.7 KB |
| target_core_device.c | -rw-r--r-- | 31.0 KB |
| target_core_fabric_configfs.c | -rw-r--r-- | 28.9 KB |
| target_core_fabric_lib.c | -rw-r--r-- | 10.6 KB |
| target_core_file.c | -rw-r--r-- | 24.2 KB |
| target_core_file.h | -rw-r--r-- | 1.2 KB |
| target_core_hba.c | -rw-r--r-- | 4.0 KB |
| target_core_iblock.c | -rw-r--r-- | 22.5 KB |
| target_core_iblock.h | -rw-r--r-- | 824 bytes |
| target_core_internal.h | -rw-r--r-- | 6.9 KB |
| target_core_pr.c | -rw-r--r-- | 122.1 KB |
| target_core_pr.h | -rw-r--r-- | 2.5 KB |
| target_core_pscsi.c | -rw-r--r-- | 27.5 KB |
| target_core_pscsi.h | -rw-r--r-- | 1.3 KB |
| target_core_rd.c | -rw-r--r-- | 16.2 KB |
| target_core_rd.h | -rw-r--r-- | 1.5 KB |
| target_core_sbc.c | -rw-r--r-- | 38.1 KB |
| target_core_spc.c | -rw-r--r-- | 39.2 KB |
| target_core_stat.c | -rw-r--r-- | 36.4 KB |
| target_core_tmr.c | -rw-r--r-- | 12.2 KB |
| target_core_tpg.c | -rw-r--r-- | 17.1 KB |
| target_core_transport.c | -rw-r--r-- | 96.2 KB |
| target_core_ua.c | -rw-r--r-- | 8.3 KB |
| target_core_ua.h | -rw-r--r-- | 1.7 KB |
| target_core_user.c | -rw-r--r-- | 83.2 KB |
| target_core_xcopy.c | -rw-r--r-- | 27.9 KB |
| target_core_xcopy.h | -rw-r--r-- | 1.9 KB |
Computing file changes ...
