Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:
drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
warn: passing zero to 'ERR_PTR'
If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.
Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
| File | Mode | Size |
|---|---|---|
| netfilter | ||
| Kconfig | -rw-r--r-- | 2.6 KB |
| Makefile | -rw-r--r-- | 996 bytes |
| br.c | -rw-r--r-- | 10.3 KB |
| br_arp_nd_proxy.c | -rw-r--r-- | 11.4 KB |
| br_cfm.c | -rw-r--r-- | 20.4 KB |
| br_cfm_netlink.c | -rw-r--r-- | 20.7 KB |
| br_device.c | -rw-r--r-- | 12.6 KB |
| br_fdb.c | -rw-r--r-- | 34.2 KB |
| br_forward.c | -rw-r--r-- | 7.8 KB |
| br_if.c | -rw-r--r-- | 18.1 KB |
| br_input.c | -rw-r--r-- | 10.6 KB |
| br_ioctl.c | -rw-r--r-- | 8.9 KB |
| br_mdb.c | -rw-r--r-- | 33.7 KB |
| br_mrp.c | -rw-r--r-- | 32.1 KB |
| br_mrp_netlink.c | -rw-r--r-- | 15.9 KB |
| br_mrp_switchdev.c | -rw-r--r-- | 5.8 KB |
| br_multicast.c | -rw-r--r-- | 129.6 KB |
| br_multicast_eht.c | -rw-r--r-- | 21.9 KB |
| br_netfilter_hooks.c | -rw-r--r-- | 30.9 KB |
| br_netfilter_ipv6.c | -rw-r--r-- | 5.6 KB |
| br_netlink.c | -rw-r--r-- | 52.4 KB |
| br_netlink_tunnel.c | -rw-r--r-- | 7.9 KB |
| br_nf_core.c | -rw-r--r-- | 2.0 KB |
| br_private.h | -rw-r--r-- | 59.3 KB |
| br_private_cfm.h | -rw-r--r-- | 4.3 KB |
| br_private_mcast_eht.h | -rw-r--r-- | 2.5 KB |
| br_private_mrp.h | -rw-r--r-- | 4.3 KB |
| br_private_stp.h | -rw-r--r-- | 1.7 KB |
| br_private_tunnel.h | -rw-r--r-- | 2.3 KB |
| br_stp.c | -rw-r--r-- | 16.2 KB |
| br_stp_bpdu.c | -rw-r--r-- | 5.6 KB |
| br_stp_if.c | -rw-r--r-- | 8.4 KB |
| br_stp_timer.c | -rw-r--r-- | 4.2 KB |
| br_switchdev.c | -rw-r--r-- | 8.8 KB |
| br_sysfs_br.c | -rw-r--r-- | 29.6 KB |
| br_sysfs_if.c | -rw-r--r-- | 10.7 KB |
| br_vlan.c | -rw-r--r-- | 54.5 KB |
| br_vlan_options.c | -rw-r--r-- | 19.6 KB |
| br_vlan_tunnel.c | -rw-r--r-- | 4.8 KB |
Computing file changes ...
