Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
	warn: passing zero to 'ERR_PTR'

If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.

Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
History
File Mode Size
Kconfig -rw-r--r-- 7.3 KB
Makefile -rw-r--r-- 1.3 KB
ebt_802_3.c -rw-r--r-- 1.9 KB
ebt_among.c -rw-r--r-- 6.9 KB
ebt_arp.c -rw-r--r-- 3.6 KB
ebt_arpreply.c -rw-r--r-- 2.5 KB
ebt_dnat.c -rw-r--r-- 2.4 KB
ebt_ip.c -rw-r--r-- 4.4 KB
ebt_ip6.c -rw-r--r-- 4.5 KB
ebt_limit.c -rw-r--r-- 3.3 KB
ebt_log.c -rw-r--r-- 5.8 KB
ebt_mark.c -rw-r--r-- 2.7 KB
ebt_mark_m.c -rw-r--r-- 2.4 KB
ebt_nflog.c -rw-r--r-- 1.8 KB
ebt_pkttype.c -rw-r--r-- 1.3 KB
ebt_redirect.c -rw-r--r-- 2.1 KB
ebt_snat.c -rw-r--r-- 2.0 KB
ebt_stp.c -rw-r--r-- 4.7 KB
ebt_vlan.c -rw-r--r-- 4.8 KB
ebtable_broute.c -rw-r--r-- 3.4 KB
ebtable_filter.c -rw-r--r-- 2.8 KB
ebtable_nat.c -rw-r--r-- 2.7 KB
ebtables.c -rw-r--r-- 65.1 KB
nf_conntrack_bridge.c -rw-r--r-- 10.1 KB
nft_meta_bridge.c -rw-r--r-- 3.9 KB
nft_reject_bridge.c -rw-r--r-- 5.5 KB

back to top