Revision a6f74333548f56afb413fc928ae1aefc4fe7608f authored by Dmytro Linkin on 25 August 2021, 14:51:26 UTC, committed by Saeed Mahameed on 20 October 2021, 17:42:49 UTC
Dan Carpenter report:
The patch f47e04eb96e0: "net/mlx5: E-switch, Allow setting share/max
tx rate limits of rate groups" from May 31, 2021, leads to the
following Smatch static checker warning:

	drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:483 esw_qos_create_rate_group()
	warn: passing zero to 'ERR_PTR'

If min rate normalization failed then error code may be overwritten to 0
if scheduling element destruction succeed. Ignore this value and always
return initial one.

Fixes: f47e04eb96e0 ("net/mlx5: E-switch, Allow setting share/max tx rate limits of rate groups")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent 14fe247
History
File Mode Size
Kconfig -rw-r--r-- 2.5 KB
Makefile -rw-r--r-- 743 bytes
af_vsock.c -rw-r--r-- 57.7 KB
af_vsock_tap.c -rw-r--r-- 2.0 KB
diag.c -rw-r--r-- 4.0 KB
hyperv_transport.c -rw-r--r-- 23.3 KB
virtio_transport.c -rw-r--r-- 18.8 KB
virtio_transport_common.c -rw-r--r-- 32.1 KB
vmci_transport.c -rw-r--r-- 57.4 KB
vmci_transport.h -rw-r--r-- 3.7 KB
vmci_transport_notify.c -rw-r--r-- 17.8 KB
vmci_transport_notify.h -rw-r--r-- 2.5 KB
vmci_transport_notify_qstate.c -rw-r--r-- 11.1 KB
vsock_addr.c -rw-r--r-- 1.5 KB
vsock_loopback.c -rw-r--r-- 5.7 KB

back to top