https://github.com/Kitware/CMake
Revision a71f0fc9c7762a06d0bfdd64d0d490919e12357a authored by Brad King on 13 September 2021, 17:31:28 UTC, committed by Brad King on 16 September 2021, 19:33:47 UTC
Since commit bd844387df (ROCMClang: Add the ROCm toolkit derived clang compiler to CMake, 2020-08-28, v3.21.0-rc1~66^2~6) and commit ff0d2858e1 (HIP: Extract clang compiler details from hipcc, 2020-10-21, v3.21.0-rc1~66^2~5), the separate `ROCMClang` compiler id for `hipcc` has caused a few problems: * The compiler id changed from behavior of CMake 3.20 and below, breaking projects that already built with `hipcc` treated as `Clang`. * The implementation of `target_compile_features` was incomplete for the `ROCMClang` identity. * Only `hipcc` was identified as `ROCMClang`, so after it is unwrapped to the underlying `clang++`, future runs of new CMake versions on an existing build tree would not repeat this. * Clang should be usable as a HIP compiler without the `hipcc` wrapper. Remove the `ROMClang` compiler identity, and revise HIP language support to work directly with a Clang compiler. Reject direct `hipcc` usage as a HIP compiler. For now it cannot be supported because it interferes with flags CMake needs to pass to Clang. Fixes: #22536, #22460, #22593
1 parent b125e98
Tip revision: a71f0fc9c7762a06d0bfdd64d0d490919e12357a authored by Brad King on 13 September 2021, 17:31:28 UTC
HIP: Remove ROMClang compiler id and use Clang directly
HIP: Remove ROMClang compiler id and use Clang directly
Tip revision: a71f0fc
| File | Mode | Size |
|---|---|---|
| .github | ||
| .gitlab | ||
| Auxiliary | ||
| Help | ||
| Licenses | ||
| Modules | ||
| Packaging | ||
| Source | ||
| Templates | ||
| Tests | ||
| Utilities | ||
| .clang-format | -rw-r--r-- | 1.4 KB |
| .clang-tidy | -rw-r--r-- | 1.1 KB |
| .codespellrc | -rw-r--r-- | 570 bytes |
| .editorconfig | -rw-r--r-- | 164 bytes |
| .gitattributes | -rw-r--r-- | 1.2 KB |
| .gitignore | -rw-r--r-- | 263 bytes |
| .gitlab-ci.yml | -rw-r--r-- | 18.3 KB |
| .hooks-config | -rw-r--r-- | 418 bytes |
| CMakeCPack.cmake | -rw-r--r-- | 9.8 KB |
| CMakeCPackOptions.cmake.in | -rw-r--r-- | 11.9 KB |
| CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
| CMakeLists.txt | -rw-r--r-- | 33.8 KB |
| CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
| CONTRIBUTING.rst | -rw-r--r-- | 3.0 KB |
| CTestConfig.cmake | -rw-r--r-- | 566 bytes |
| CTestCustom.cmake.in | -rw-r--r-- | 6.6 KB |
| CompileFlags.cmake | -rw-r--r-- | 4.7 KB |
| Copyright.txt | -rw-r--r-- | 5.2 KB |
| DartConfig.cmake | -rw-r--r-- | 374 bytes |
| README.rst | -rw-r--r-- | 3.9 KB |
| bootstrap | -rwxr-xr-x | 62.6 KB |
| cmake_uninstall.cmake.in | -rw-r--r-- | 789 bytes |
| configure | -rwxr-xr-x | 99 bytes |
| doxygen.config | -rw-r--r-- | 27.4 KB |
Computing file changes ...
