Skip to main content

Browse the archive

https://github.com/angular/angular
01 September 2024, 02:13:37 UTC
sort by:
Revision Author Date Message Commit Date
a8134dc Alex Rickabaugh 30 September 2020, 16:54:50 UTC release: cut the v10.1.4 release 30 September 2020, 16:54:50 UTC
a1bf0de JiaLiPassion 28 September 2020, 23:26:53 UTC release: cut the zone.js-0.11.2 release (#39032) PR Close #39032 30 September 2020, 13:53:34 UTC
3dbc076 Joey Perrott 29 September 2020, 23:06:50 UTC refactor(dev-infra): use common git client for git environment reset (#39051) For rebase tooling, use the `GitClient`'s `checkout` method rather than a custom function doing the same task. PR Close #39051 30 September 2020, 13:36:02 UTC
3409efb Joey Perrott 29 September 2020, 15:13:47 UTC fix(bazel): clean up outstanding failure message for usages of --define=compile (#39046) Removes the failure message put in place to catch usages of the old --define=compile method of setting which compiler was to be used. PR Close #39046 30 September 2020, 13:33:59 UTC
3812f57 Dan Russell 29 September 2020, 13:13:58 UTC docs(core): fix typo (#39041) Change the word "weather" to "whether" PR Close #39041 30 September 2020, 13:32:16 UTC
8292e1c Andrew Kushnir 29 September 2020, 01:08:07 UTC ci: do not require g3 checks for the changes in `ngtsc/sourcemaps` folder (#39035) This commit updates ngbot config to avoid requesting google3 presubmit for the changes in the `packages/compiler-cli/src/ngtsc/sourcemaps` folder (which is not synced into google3). PR Close #39035 30 September 2020, 13:28:42 UTC
d8de689 Daniel 29 September 2020, 00:47:57 UTC docs(docs-infra): replace a comma with a period at the end of a sentence (#39034) In order to keep document consistency this commit replaces a comma with a period at the end of a sentence PR Close #39034 30 September 2020, 13:27:31 UTC
d53cfb5 George Kalpakas 27 September 2020, 10:37:45 UTC build(docs-infra): simplify updating dependencies in docs examples boilerplate (#38992) Previously, when updating the dependency versions in `aio/tools/examples/shared/package.json` (which contains all dependencies used in docs examples projects), one had to manually go through all boilerplate directories and update the `package.json` files with the same versions. This commit simplifies this task by automating it via a Node.js script. PR Close #38992 30 September 2020, 13:20:01 UTC
fb51e10 George Kalpakas 27 September 2020, 10:37:43 UTC build(docs-infra): simplify update workflow for CLI-based docs examples boilerplate (#38992) When updating the boilerplate for CLI-based docs examples, one needed to install dependencies inside the `aio/tools/examples/shared/boilerplate/cli/` directory, which resulted in a `node_modules/` directory and a `yarn.lock` file. These were not supposed to be part of the boilerplate, so they had to be manually removed after the boilerplate was updated. This commit simplifies the workflow by allowing boilerplate files to be ignored (both by git and the `example-boilerplate.js` script) via a `.gitignore` file. This way, it is no longer necessary to manually remove the unneeded directories/files. PR Close #38992 30 September 2020, 13:20:01 UTC
7813529 George Kalpakas 27 September 2020, 10:37:41 UTC docs(docs-infra): update instructions for updating docs examples dependencies (#38992) PR Close #38992 30 September 2020, 13:20:01 UTC
066fca0 George Kalpakas 27 September 2020, 10:37:39 UTC docs(docs-infra): apply the one-sentence-per-line rule to Markdown files in `aio/tools/` (#38992) This commit updates the Markdown files inside the `aio/tools/` directory to contain one sentence per line in order to be consistent with how Markdown files are formatted in the rest of the repo. PR Close #38992 30 September 2020, 13:20:01 UTC
31be06a Daniel Kreider 28 September 2020, 17:36:55 UTC docs: fix two broken commands (#38960) PR Close #38960 30 September 2020, 13:17:19 UTC
fd795da Kapunahele Wong 03 September 2020, 16:20:32 UTC docs: edit template-statements doc (#38742) This commit updates the copy and headers to bring in line with style guide and clarify content. PR Close #38742 30 September 2020, 13:13:23 UTC
69302ad Misko Hevery 25 September 2020, 21:47:33 UTC refactor(core): Create `NodeInjectorOffset` type which better describes NodeInjector (#38707) `NodeInjector` is store in expando as a list of values in an array. The offset constant into the array have been brought together into a single `NodeInjectorOffset` enum with better documentation explaining their usage. PR Close #38707 28 September 2020, 23:21:03 UTC
9891cef Misko Hevery 26 September 2020, 00:17:30 UTC docs(core): Update instructions on updating symbol tests (#38707) PR Close #38707 28 September 2020, 23:21:00 UTC
65d4e7a Misko Hevery 14 September 2020, 20:43:44 UTC refactor(core): renamed `previousOrParent` to `currentTNode` (#38707) The previous name of `previousOrParent` was confusing. Changed the terminology to `currentTNode`. PR Close #38707 28 September 2020, 23:20:56 UTC
0fa208f Misko Hevery 14 September 2020, 20:25:13 UTC refactor(core): change `getPreviousOrParentTNode` to return `TNode|null` (#38707) This change makes `getPreviousOrParentTNode` return `TNode|null` (rather than just `TNode`) which is more reflective of the reality. The `getPreviousOrParentTNode` can be `null` upon entering the `LView`. PR Close #38707 28 September 2020, 23:20:53 UTC
15fa4bb Misko Hevery 14 September 2020, 20:14:12 UTC refactor(core): Rename `TView.node` to `TView.declTNode`. (#38707) The value stored in `TView.node` is really the declaration `TNode`, therefore renaming to make it more explicit. PR Close #38707 28 September 2020, 23:20:50 UTC
ed35adb Misko Hevery 14 September 2020, 20:06:05 UTC refactor(core): Remove `TViewNode` as it is no longer used. (#38707) Previous commit change the logic to not rely on the `TViewNode` this change removes it entirely. PR Close #38707 28 September 2020, 23:20:46 UTC
4645f43 Misko Hevery 14 September 2020, 18:21:15 UTC refactor(core): Remove reliance on `TNodeType.View`. (#38707) `TNodeType.View` was created to support inline views. That feature did not materialize and we have since removed the instructions for it, leave an unneeded `TNodeType.View` which was still used in a very inconsistent way. This change no longer created `TNodeType.View` (and there will be a follow up chang to completely remove it.) Also simplified the mental model so that `LView[HOST]`/`LView[T_HOST]` always point to the insertion location of the `LView`. PR Close #38707 28 September 2020, 23:20:43 UTC
b613639 Misko Hevery 04 September 2020, 23:55:51 UTC refactor(core): Add injector debug information to `LViewDebug` (#38707) Extended the `LViewDebug` to display node-injector information for each node. PR Close #38707 28 September 2020, 21:36:10 UTC
bc6ff77 Misko Hevery 04 September 2020, 20:03:46 UTC refactor(core): Remove host `TNode` from `getOrCreateTNode` (#38707) Host `TNode` was passed into `getOrCreateTNode` just so that we can compute weather or not we are a root node. This was needed because `previousOrParentTNode` could have `TNode` from `TView` other then current `TView`. This is confusing mental model. Previous change ensured that `previousOrParentTNode` must always be part of `TView`, which enabled this change to remove the unneeded argument. PR Close #38707 28 September 2020, 21:36:06 UTC
33aaa9e Misko Hevery 04 September 2020, 05:46:11 UTC refactor(core): Ensure that `previousOrParentTNode` always belongs to current `TView`. (#38707) `previousOrParentTNode` stores current `TNode`. Due to inconsistent implementation the value stored would sometimes belong to the current `TView` and sometimes to the parent. We have extra logic which accounts for it. A better solution is to just ensure that `previousOrParentTNode` always belongs to current `TNode`. This simplifies the mental model and cleans up some code. PR Close #38707 28 September 2020, 21:36:03 UTC
689651b Misko Hevery 17 September 2020, 22:57:01 UTC docs(core): correct instructions for running component repo locally (#38707) PR Close #38707 28 September 2020, 21:36:00 UTC
875fcfe Joey Perrott 28 September 2020, 19:22:26 UTC ci: note Paul and Pawel as OOO in pullapprove (#39028) Notes Paul and Pawel as OOO through commenting out their usernames in users entries throughout the pullapprove configs which could result in their review being requested by pullapprove. PR Close #39028 28 September 2020, 20:29:14 UTC
0d238aa George Kalpakas 27 September 2020, 12:20:48 UTC build(docs-infra): update TypeScript and other deps to align with latest CLI (#39017) This commit updates TypeScript and other dependencies used in angular.io to more closely align with new apps created with the latest Angular CLI. It also updates `tsconfig.json`, re-ordering some properties around and introducing some more checks (again to more closely match new CLI apps). NOTE: I skipped updating RxJS from 6.5.4 to 6.6.3, because it increased the main bundle by ~500B. NOTE: `tslint.json` will be updated in a subsequent PR, because it requires more extensive changes. PR Close #39017 28 September 2020, 20:28:05 UTC
398b446 George Kalpakas 27 September 2020, 12:20:46 UTC build(docs-infra): update @angular/material to 10.2.2 (#39017) This commit updates the version of Angular Components used in angular.io to version 10.2.2. NOTE: The actual size increase for the main bundle in ViewEngine mode is 1.3KB (because the actual size before this commit was 430423B, not 430008B as seen in `aio-payloads.json`). PR Close #39017 28 September 2020, 20:28:05 UTC
5b1c714 George Kalpakas 27 September 2020, 12:20:44 UTC build(docs-infra): update @angular/* to 10.1.3 (#39017) This commit updates the version of Angular framework used in angular.io to version 10.1.3. NOTE: The actual size decrease for the main bundle is 3KB (because the actual size before this commit was 451226B, not 450952B as seen in `aio-payloads.json`). PR Close #39017 28 September 2020, 20:28:05 UTC
6df71d5 George Kalpakas 27 September 2020, 12:20:39 UTC build(docs-infra): update @angular/cli to 10.1.3 (#39017) This commit updates the version of Angular CLI used in angular.io to version 10.1.3. PR Close #39017 28 September 2020, 20:28:05 UTC
be25ccb JoostK 26 September 2020, 20:28:12 UTC test(compiler-cli): fix tests to have at least one component (#39011) With the introduction of incremental type checking in #36211, an intermediate `ts.Program` for type checking is only created if there are any templates to check. This rendered some tests ineffective at avoiding regressions, as the intermediate `ts.Program` was required for the tests to fail if the scenario under test would not be accounted for. This commit adds a single component to these tests, to ensure the intermediate `ts.Program` is in fact created. PR Close #39011 28 September 2020, 20:27:36 UTC
6e99427 JoostK 26 September 2020, 20:14:10 UTC fix(compiler-cli): enable @types discovery in incremental rebuilds (#39011) Prior to this fix, incremental rebuilds could fail to type check due to missing ambient types from auto-discovered declaration files in @types directories, or type roots in general. This was caused by the intermediary `ts.Program` that is created for template type checking, for which a `ts.CompilerHost` was used which did not implement the optional `directoryExists` methods. As a result, auto-discovery of types would not be working correctly, and this would retain into the `ts.Program` that would be created for an incremental rebuild. This commit fixes the issue by forcing the custom `ts.CompilerHost` used for type checking to properly delegate into the original `ts.CompilerHost`, even for optional methods. This is accomplished using a base class `DelegatingCompilerHost` which is typed in such a way that newly introduced `ts.CompilerHost` methods must be accounted for. Fixes #38979 PR Close #39011 28 September 2020, 20:27:35 UTC
79ac811 Kristiyan Kostadinov 27 September 2020, 11:58:57 UTC test(compiler-cli): error when running tests on non-posix systems (#39005) We weren't resolving a path correctly which resulted in an error on Windows. For reference, here's the error. Note the extra slash before `C:`: ``` Error: ENOENT: no such file or directory, scandir '/C:/bazel_output_root/yxvwd24o/external/npm/node_modules/typescript' at Object.readdirSync (fs.js:854:3) ``` PR Close #39005 28 September 2020, 20:27:01 UTC
bbe6cf3 George Kalpakas 25 September 2020, 16:21:16 UTC build(docs-infra): enable AOT in development mode for all docs examples (#39001) In the past, the docs examples were configured to not use AOT compilation in development mode (only in production mode). This was an artifact of when JIT was the default in development mode. Now that AOT is the default (even in development mode) for new CLI apps, this commit configures all docs examples to always use AOT compilation. (This has been made possible by fixing the `component-interaction` docs example to correctly run in AOT mode in an earlier commit.) PR Close #39001 28 September 2020, 20:26:33 UTC
c95fabf George Kalpakas 25 September 2020, 16:17:49 UTC test(docs-infra): fix and enable remaining `component-interaction` e2e tests (#39001) Previously, some of the e2e tests of the `component-interaction` docs example were disabled because they were failing. This commit fixes and re-enables them. PR Close #39001 28 September 2020, 20:26:33 UTC
3fad0ff George Kalpakas 25 September 2020, 15:17:26 UTC refactor(docs-infra): minor refactoring of the `component-interaction` e2e tests (#39001) This commit refactors the e2e tests of the `component-interaction` docs example to improve readability and make them easier to maintain. Changes include: - Switch from `element.all().get(0)` to `element()` when there is only one such element on the page. - Switch from `Promise#then()` to `async/await`. - Move `ElementFinder`s at the top of the test (instead of having them interleaved with expectations). - Load the page before every test (i.e. in a `beforeEach()` instead of `beforeAll()`) to prevent state from each test leaking into the subsequent tests. - Order imports alphabetically. PR Close #39001 28 September 2020, 20:26:33 UTC
ef0be18 George Kalpakas 25 September 2020, 13:31:31 UTC fix(docs-infra): fix the `component-interaction` example e2e tests to run in prod mode (#39001) Previously, the `component-interaction` docs example was configured to run e2e tests on CI in development mode (in contrast to the default for all docs examples, which is to run e2e tests in production mode). This was necessary due to the following reasons: - One of the components, `CountdownTimerComponent`, which is used by `CountdownLocalVarParentComponent` and `CountdownViewChildParentComponent`, was triggering a periodic asynchronous task (via `setInterval()`), which prevented the app from stabilizing and caused tests to fail. - In order to prevent this from happening, the example's `AppModule` had special provisioning to not include the problematic components in its declarations when testing. - Since this had to be determined dynamically at runtime (via inspecting the URL query params), the `AppModule`'s config could not be statically evaluated in AOT compilation. This commit fixes the example to make it compatible with AOT compilation and removes the custom test command from its `example-config.json` (allowing it to be run with the default e2e test command, i.e. in production mode). PR Close #39001 28 September 2020, 20:26:33 UTC
139c5b4 George Kalpakas 21 September 2020, 17:52:26 UTC build(docs-infra): update docs examples to Angular v10 (#38993) This commit updates the docs examples to Angular v10.1.3. In addition to updating the dependencies versions, it also updates the project's structure and config to more closely match what a new v10 CLI app would look like. See, also, the [diff][1] between a basic v9.1.4 CLI app and a v10.1.3 one. [1]: https://github.com/cexbrayat/angular-cli-diff/compare/9.1.4..10.1.3 PR Close #38993 28 September 2020, 20:25:00 UTC
1328236 Joey Perrott 24 September 2020, 16:17:57 UTC refactor(zone.js): rename BlacklistedStackFrames to InternalZoneJsStackFrames (#38978) BlacklistedStackFrames to InternalZoneJsStackFrames along with other related symbols renamed with the same changes (with appropriate casing style). PR Close #38978 28 September 2020, 20:23:42 UTC
5453772 Joey Perrott 23 September 2020, 20:23:49 UTC docs: remove usage of whitelist in cli analytics docs (#38963) Removes the usage of the term whitelist in the analytics docs for cli. PR Close #38963 28 September 2020, 20:23:07 UTC
7c5f89d Joey Perrott 21 September 2020, 21:06:31 UTC build: remove usage of blacklist in benchmark tooling (#38926) Removes the usage of blacklist in benchmark tooling, instead using more specificity to indicate whether a row is collapsible. PR Close #38926 28 September 2020, 20:20:40 UTC
bc0d140 George Kalpakas 28 September 2020, 15:17:57 UTC test(docs-infra): add missing test for the `rx-library` docs example (#38905) This commit adds an extra test for the `retry-on-error` snippet of the `rx-library` docs example to ensure it can successfully recover after a couple of failed attempts. This commit addresses comment https://github.com/angular/angular/pull/38905#discussion_r491494196. PR Close #38905 28 September 2020, 20:20:12 UTC
14ecc9e Sonu Kapoor 28 September 2020, 14:56:59 UTC test(docs-infra): add unit tests for rx-library examples (#38905) This commit adds missing unit tests for all rx-library examples from the docs. Closes #28017 PR Close #38905 28 September 2020, 20:20:12 UTC
62a2fc8 Sonu Kapoor 28 September 2020, 14:56:57 UTC fix(docs-infra): fix the retry-on-error example (#38905) Previously, the `retry` example did not work as intended. The `retry` operator was called before the exception occured, thus not retrying the `ajax` request. This commit moves the `retry` operator into the correct order to ensure that the failed request is retried. PR Close #38905 28 September 2020, 20:20:11 UTC
8f59e37 Paul Gschwendtner 09 September 2020, 13:01:18 UTC feat(dev-infra): tool for staging and publishing releases (#38656) Creates a tool for staging and publishing releases as per the new branching and versioning that has been outlined in the following document. The tool is intended to be used across the organization to ensure consistent branching/versioning and labeling: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU/edit#heading=h.s3qlps8f4zq7dd The tool implements the actions as outlined in the following initial plan: https://hackmd.io/2Le8leq0S6G_R5VEVTNK9A. The implementation slightly diverged in so far that it performs staging and publishing together so that releasing is a single convenient command. In case of errors for which re-running the full command is not sufficient, we want to consider adding recover functionality. e.g. when the staging completed, but the actual NPM publishing aborted unexpectedly due to build errors. PR Close #38656 28 September 2020, 20:11:48 UTC
3d9ebb4 Paul Gschwendtner 09 September 2020, 12:56:58 UTC feat(dev-infra): add release command for setting NPM dist tag (#38656) Introduces a new command for `ng-dev release`, so that the NPM dist tag can be set for all configured NPM packages. This command can be useful in case a manual tag needs to be set, but it is primarily used by the release tooling when a new stable version is cut, and when the previous patch branch needs to be set as LTS version through a `v{major}-lts` dist tag. It is necessary to have this as a command so that the release tool can execute it for old branches where other packages might have been configured. This is similar to the separate `ng-dev build` command that we created. Note that we also added logic for spawning a process conveniently with different "console output" modes. This will be useful for other command invocations in the release tool and it's generally better than directly using native `child_process` as that one doesn't log to the dev-infra debug log file. PR Close #38656 28 September 2020, 20:11:47 UTC
ea141f8 Paul Gschwendtner 09 September 2020, 12:55:19 UTC feat(dev-infra): add command for building release output (#38656) Adds a command for building all release packages. This command is primarily used by the release tool for building release output in version branches. The release tool cannot build the release packages configured in `master` as those packages could differ from the packages available in a given version branch. Also, the build process could have changed, so we want to have an API for building release packages that is guaranteed to be consistent across branches. PR Close #38656 28 September 2020, 20:11:47 UTC
c100dbe Paul Gschwendtner 09 September 2020, 12:53:13 UTC refactor(dev-infra): move existing env-stamp command into subfolder (#38656) Moves the existing `ng-dev release env-stamp` command into a subfolder so that the staging/publish tool can have its own dedicated folder (without being polluted by the env-stamp logic). Every subcommand should be in its own folder. PR Close #38656 28 September 2020, 20:11:47 UTC
9c82e27 Paul Gschwendtner 09 September 2020, 12:50:02 UTC feat(dev-infra): add shared testing utilities folder with git mock (#38656) Adds a new folder to dev-infra where shared testing utilities could be placed in. This commit already adds initial testing utilities for dealing with the `GitClient` and SemVer versions. The `GitClient` in the testing utilities simulates actual Git behavior in a virtual manner. It's not complete at all, but can be extended based on our needs. The currently implemented commands are the most basic ones that we'd need for our release tooling. PR Close #38656 28 September 2020, 20:11:47 UTC
4035e47 Paul Gschwendtner 09 September 2020, 12:48:36 UTC feat(dev-infra): add logic for printing active release trains (#38656) Adds a method for printing active release trains for a configured project. This is helpful for the release tool that will print the active release trains. Also this can be useful for the caretaker status command, where we could print the active version branches (i.e. "is there currently a feature-freeze branch"). PR Close #38656 28 September 2020, 20:11:46 UTC
d03e2e3 Paul Gschwendtner 09 September 2020, 12:48:11 UTC feat(dev-infra): add logic for determining active LTS branches (#38656) Adds logic for determining active LTS branches for a given release configuration. The active LTS branches can be determined by querying NPM and matching dist tags against a specific pattern. i.e. `v{major}-lts`. This logic will be useful for the release tool that supports publishing of active LTS version branches. PR Close #38656 28 September 2020, 20:11:46 UTC
b29c32b Paul Gschwendtner 09 September 2020, 12:44:14 UTC refactor(dev-infra): cleanup comments in git utilities (#38656) Cleans up outdated comments in the shared dev-infra Git utilities. We also export the Graphql client for consistency as we expose the `GithubClient` and `GitClient` too. PR Close #38656 28 September 2020, 20:11:46 UTC
3e99868 Paul Gschwendtner 09 September 2020, 12:42:34 UTC refactor(dev-infra): move common versioning tooling to shared location (#38656) We initially added logic for determining active release trains into the merge script. Given we now build more tools that rely on this information, we move the logic into a more general "versioning" folder that can contain common logic following the versioning document for the Angular organization. PR Close #38656 28 September 2020, 20:11:46 UTC
617858d Paul Gschwendtner 09 September 2020, 12:37:38 UTC feat(dev-infra): introduce new configuration for release tool (#38656) Introduces a new configuration for the `ng-dev release` command. This configuration will be the source of truth for all release packages and how they can be built. Additionally, in a temporary manner where each project has its own way of generating the changelog, the changelog generation can be configured. This will be removed in the future when there is canonical changelog generation in the dev-infra shared package. PR Close #38656 28 September 2020, 20:11:45 UTC
68cb77d Paul Gschwendtner 01 September 2020, 17:48:03 UTC refactor(dev-infra): expose logic for dealing with LTS branches (#38656) Exposes logic for dealing with LTS branches, so that the release tool can re-use it for cutting LTS patch releases. Eventually, we can move all of this logic to a more dedicated folder instead of having it inside the merge folder. PR Close #38656 28 September 2020, 20:11:45 UTC
5cdf2e4 Paul Gschwendtner 01 September 2020, 10:32:09 UTC refactor(dev-infra): use shared github repo interface (#38656) Instead of maintaining multiple interface for grouping owner name and repo name, we expose a shared interface describing a Github repository. One unfortunate downside is that the GraphQL Github and Rest API diverge slightly with the key for the repository name. i.e. rest uses `repo` for the name of a repository, while GraphQL uses `name` for the name. If that would be consistent, we could use the rest operator to pass a repository to the Octokit REST or GraphQL API. This does not work, so we have a small manual overhead as seen in the `branches.ts` file. PR Close #38656 28 September 2020, 20:11:45 UTC
39bfa34 Paul Gschwendtner 01 September 2020, 08:48:01 UTC build: add tsconfig with strict flag to dev-infra package (#38656) The dev-infra package is currently built with Bazel and ts-node. In Bazel, the shared tsconfig from the `packages/` folder is used. This means that the code is built in strict mode, but IDEs and ts-node do not know about the strictness. This is because the tsconfig is part of the `packages` folder and not accessible from the dev-infra package. We fix this by adding an IDE and ts-node specific tsconfig to the dev-infra package. This helps with spotting compilation failures before building with Bazel / waiting for CI to check build state. PR Close #38656 28 September 2020, 20:11:45 UTC
b3752e6 Paul Gschwendtner 01 September 2020, 08:46:41 UTC refactor(dev-infra): expose version for determined release trains (#38656) Previously, the logic for determing the active release trains did not return the resolved version of a release train. With the publish script being created, we need this information and can just pass it through, so that we do not need to fetch and parse the package.json of given branches multiple times. PR Close #38656 28 September 2020, 20:11:44 UTC
9833b0b Paul Gschwendtner 01 September 2020, 08:46:10 UTC build: set up ora for progress spinners in dev-infra package (#38656) Sets up the NPM `ora` package in the project and in dev-infra, so that we can show progress spinners when needed. This is useful in the publish release script when we wait for a pull request to be merged. PR Close #38656 28 September 2020, 20:11:44 UTC
2eb8447 Paul Gschwendtner 01 September 2020, 08:43:26 UTC refactor(dev-infra): do not print git commands in silent mode (#38656) The git client respects the `SpawnSyncOptions` when a command is executed. Currently it does not hide the command info messages when commands are run in silent mode. We fix this as part of this commit, so that the command info is only printed to `debug` if `stdio` is set to `ignore`. Additonally, the github token is made public so that it can be used by commands if other repositories like forks are targeted. PR Close #38656 28 September 2020, 20:11:44 UTC
78c9972 Paul Gschwendtner 01 September 2020, 08:39:35 UTC refactor(dev-infra): share more github code between commands (#38656) Instead of repeating the logic for adding the github token to a repository git url, we add a shared function for automatically computing the URls with token. Additionally, URLs for updating/generating tokens have been moved to a dedicated file in the `utils` folder. Also while being at it, the yargs github token helper is also moved into the dedicated Git/Github related util folder. PR Close #38656 28 September 2020, 20:11:43 UTC
5bf5513 George Kalpakas 24 September 2020, 15:12:55 UTC build(docs-infra): upgrade cli command docs sources to ab97bc382 (#38974) Updating [angular#10.1.x](https://github.com/angular/angular/tree/10.1.x) from [cli-builds#10.1.x](https://github.com/angular/cli-builds/tree/10.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/ef770f1cb...ab97bc382): **Modified** - help/build.json - help/serve.json PR Close #38974 25 September 2020, 18:34:11 UTC
50f5827 Joey Perrott 23 September 2020, 20:27:30 UTC docs(docs-infra): remove usage of whitelist in aio-builds-setup docs (#38964) Removes the usage of the term whitelist in the aio-builds-setup docs. PR Close #38964 25 September 2020, 18:31:58 UTC
e98f11a Alyssa Nicoll 23 September 2020, 16:26:23 UTC docs(docs-infra): add upcoming conference (#38956) PR Close #38956 25 September 2020, 18:31:34 UTC
1f2c7f6 JoostK 19 September 2020, 23:06:19 UTC test(compiler-cli): load test files into memory only once (#38909) Prior to this change, each invocation of `loadStandardTestFiles` would load the necessary files from disk. This function is typically called at the top-level of a test module in order to share the result across tests. The `//packages/compiler-cli/test/ngtsc` target has 8 modules where this call occurs, each loading their own copy of `node_modules/typescript` which is ~60MB in size, so the memory overhead used to be significant. This commit loads the individual packages into a standalone `Folder` and mounts this folder into the filesystem of standard test files, such that all file contents are no longer duplicated in memory. PR Close #38909 25 September 2020, 18:28:50 UTC
3d2799b JoostK 13 September 2020, 18:31:33 UTC test(compiler-cli): improve test performance using shared source file cache (#38909) Some compiler tests take a long time to run, even using multiple executors. A profiling session revealed that most time is spent in parsing source files, especially the default libraries are expensive to parse. The default library files are constant across all tests, so this commit introduces a shared cache of parsed source files of the default libraries. This achieves a significant improvement for several targets on my machine: //packages/compiler-cli/test/compliance: from 23s to 5s. //packages/compiler-cli/test/ngtsc: from 115s to 11s. Note that the number of shards for the compliance tests has been halved, as the extra shards no longer provide any speedup. PR Close #38909 25 September 2020, 18:28:49 UTC
6852813 Keen Yee Liau 15 September 2020, 17:11:23 UTC docs: Delete repeated section "Removed APIs" (#38858) The section "Removed APIs" is repeated twice, probably due to a mistake in resolving merge conflicts. PR Close #38858 25 September 2020, 18:28:26 UTC
9e8fa07 Andrew Scott 23 September 2020, 18:23:28 UTC test(core): enable test in compiler compliance for namespace uri (#38957) Enables test that was fixed by #24386. resolves #24426. PR Close #38957 24 September 2020, 15:35:44 UTC
525af1e Sonu Kapoor 19 September 2020, 16:41:59 UTC test(docs-infra): add missing unit tests for backoff example (#38896) This commit adds the missing unit test for the backoff example. PR Close #38896 24 September 2020, 15:33:21 UTC
58f2abe Sonu Kapoor 19 September 2020, 15:52:03 UTC fix(docs-infra): fix the backoff example (#38896) Previously, the `backoff()` example did not work as intended. More specifically, the `range(1, maxTries)` observable would complete immediately after emitting the `maxTries`th value, causing the overall observable to also complete. As a result, it would only make `maxTries - 1` attempts to recover from an error. More importantly, the outer observable would complete successfully instead of erroring. This commit fixes the `backoff()` operator by ensuring it makes exactly `maxTries` attempts to recover and it propagates the actual error to the outer observable. The test for this change is added in the next commit. PR Close #38896 24 September 2020, 15:33:21 UTC
9d918d8 JiaLiPassion 15 August 2020, 07:34:22 UTC fix(zone.js): disable wrap uncaught promise rejection should handle primitive value (#38476) Close #38334. zone.js provides a flag DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION to let zone.js throw the original error instead of wrap it when uncaught promise rejection found. But the rejection value could be anything includes primitive value such as number. In that case, we should not attach any additional properties to the value. PR Close #38476 24 September 2020, 15:32:45 UTC
8236904 Joey Perrott 21 September 2020, 21:15:52 UTC test(platform-browser): remove usage of blacklist in test naming (#38928) Remove usage of blacklist in test name. PR Close #38928 23 September 2020, 19:47:28 UTC
7355096 Alex Rickabaugh 22 September 2020, 20:18:09 UTC fix(compiler-cli): perform DOM schema checks even in basic mode in g3 (#38943) In Ivy, template type-checking has 3 modes: basic, full, and strict. The primary difference between basic and full modes is that basic mode only checks the top-level template, whereas full mode descends into nested templates (embedded views like ngIfs and ngFors). Ivy applies this approach to all of its template type-checking, including the DOM schema checks which validate whether an element is a valid component/directive or not. View Engine has both the basic and the full mode, with the same distinction. However in View Engine, DOM schema checks happen for the full template even in the basic mode. Ivy's behavior here is technically a "fix" as it does not make sense for some checks to apply to the full template and others only to the top-level view. However, since g3 relies exclusively on the basic mode of checking and developers there are used to DOM checks applying throughout their template, this commit re-enables the nested schema checks even in basic mode only in g3. This is done by enabling the checks only when Closure Compiler annotations are requested. Outside of g3, it's recommended that applications use at least the full mode of checking (controlled by the `fullTemplateTypeCheck` flag), and ideally the strict mode (`strictTemplates`). PR Close #38943 23 September 2020, 19:46:33 UTC
c650500 Joey Perrott 21 September 2020, 21:10:48 UTC test(docs-infra): remove usage of blacklist in test naming (#38927) Remove usage of blacklist in test naming of processor tranform tests. PR Close #38927 23 September 2020, 19:46:02 UTC
73c7882 Alex Rickabaugh 23 September 2020, 18:54:47 UTC release: cut the v10.1.3 release 23 September 2020, 18:54:47 UTC
32e32e5 Wagner Maciel 22 September 2020, 17:27:18 UTC refactor(dev-infra): simplify runBenchmark (#38941) * Make url and params optional in runBenchmark * Make url optional in openBrowser * Remove unused code from runBenchmark PR Close #38941 22 September 2020, 22:05:34 UTC
0dda8bf Joey Perrott 21 September 2020, 21:27:44 UTC refactor(zone.js): remove usages of blacklist related to UNPATCHED_EVENTS (#38930) Remove usages of blacklist around UNPATCHED_EVENTS configuration PR Close #38930 22 September 2020, 22:05:01 UTC
8db865d David Shevitz 17 September 2020, 17:10:16 UTC docs: Update titles to getting started topics (#38887) The topics for our getting started tutorial are inconsistent. This change makes the titles consistent and easier to read. PR Close #38887 21 September 2020, 23:33:29 UTC
667c10a Andrew Scott 21 September 2020, 19:12:27 UTC ci: Update payload size on 10.1.x to be correct (#38923) Update payload size on 10.1.x to be correct after changing in 04d0aa6781a38ed8769c53fcc5d13304c4300f95. PR Close #38923 21 September 2020, 23:26:24 UTC
0286233 Ajit Singh 21 August 2020, 01:38:36 UTC docs: change wrong default app module by ng new (#38549) In bootstrapping.md the default AppModule has some extra imports which are not generated by default in ng new removed those extra imports and add them at appropriate place. PR Close #38549 21 September 2020, 19:25:29 UTC
8f523c1 Andrew Scott 17 September 2020, 23:16:17 UTC refactor(compiler): simplify visitor logic for attributes (#38899) The logic for computing identifiers, specifically for bound attributes can be simplified by using the value span of the binding rather than the source span. PR Close #38899 21 September 2020, 19:23:59 UTC
790e483 Kapunahele Wong 15 September 2020, 12:52:44 UTC fix(docs-infra): remove scrollbar styles for accessibility (#38852) This commit removes the scrollbar styles so that the default styles in the browser render. This widens the webkit scroll bar. This makes it easier to grab the scrollbar using assistive technology and devices, and provides a wider target for those who have dexterity issues. By removing these styles, We will no longer have to maintain custom scrollbars specific to WebKit and they will be accessible by default. PR Close #38852 21 September 2020, 19:22:08 UTC
a7650b0 Sonu Kapoor 17 September 2020, 22:47:41 UTC test(docs-infra): replace deprecated `ReflectiveInjector` with `Injector` (#38897) This commit replaces the old and slow ReflectiveInjector that was deprecated in v5 with the new Injector. PR Close #38897 21 September 2020, 19:21:27 UTC
04d0aa6 Marley Powell 21 September 2020, 12:34:39 UTC revert: feat(router): better warning message when a router outlet has not been instantiated (#38920) This reverts commit [1609815]. The warning that was added created more confusion than it solved and also warned for valid use-cases. PR Close #38920 21 September 2020, 19:18:45 UTC
7d5b515 Andrew 18 September 2020, 15:33:23 UTC docs: Grammar fixes (#38900) Changed several period into colons to be consistent throughout the doc. Changed "If don't add the interface..." to "If _you_ don't add the interface..." PR Close #38900 18 September 2020, 23:52:52 UTC
27a6e5a Andrew Kushnir 18 September 2020, 18:21:56 UTC ci: do not require g3 checks for the changes in `packages/zone.js/dist` folder (#38901) This commit updates ngbot config to avoid requesting google3 presubmit for the changes in the `packages/zone.js/dist` folder (which is not synced into google3). PR Close #38901 18 September 2020, 23:48:17 UTC
2700d88 Joey Perrott 16 September 2020, 14:38:47 UTC build: update to latest version of yarn (#38869) Update the vendored version of yarn to the latest version. PR Close #38869 18 September 2020, 23:47:34 UTC
3902ec0 William Koza 09 September 2020, 11:03:01 UTC fix(http): Fix error message when we call jsonp without importing HttpClientJsonpModule (#38756) Currently, when we call jsonp method without importing HttpClientJsonpModule, an error message appears saying 'Attempted to construct Jsonp request without JsonpClientModule installed.' instance of 'Attempted to construct Jsonp request without HttpClientJsonpModule installed.' PR Close #38756 18 September 2020, 18:20:37 UTC
6f579b2 Andrew Kushnir 11 September 2020, 01:15:32 UTC feat(dev-infra): output the number of new and fixed cycles (#38805) This commit adds a logic to ouput the number of new and fixed cycles after running circular dependency checker. This information is useful to better understand an impact of changes in case the number of new/fixed cycles is relatively big. PR Close #38805 18 September 2020, 18:20:08 UTC
c4a7516 Andrew Kushnir 10 September 2020, 19:38:49 UTC refactor(core): reduce the number of circular deps (#38805) This commit updates several import statements in the core package to decrease the number of cycles detected by the dependency checker tool. PR Close #38805 18 September 2020, 18:20:08 UTC
33055da JiaLiPassion 14 September 2020, 06:54:12 UTC fix(zone.js): should invoke xhr send task when no response error occurs (#38836) Close #38795 in the XMLHttpRequest patch, when get `readystatechange` event, zone.js try to invoke `load` event listener first, then call `invokeTask` to finish the `XMLHttpRequest::send` macroTask, but if the request failed because the server can not be reached, the `load` event listener will not be invoked, so the `invokeTask` of the `XMLHttpRequest::send` will not be triggered either, so we will have a non finished macroTask there which will make the Zone not stable, also memory leak. So in this PR, if the `XMLHttpRequest.status = 0` when we get the `readystatechange` event, that means something wents wrong before we reached the server, we need to invoke the task to finish the macroTask. PR Close #38836 18 September 2020, 18:19:37 UTC
fb163df Joey Perrott 17 September 2020, 17:17:08 UTC fix(dev-infra): skip husky git commit hooks while merging pull requests (#38888) During the merge process, all validations have already been completed so git commit hooks can be safely skipped. This additionally, prevents errors from occuring which would be caused the commit hooks executing, such as when yarn updates and then yarn commands are unable to run within the same process. PR Close #38888 18 September 2020, 18:14:58 UTC
6b05dc4 Sonu Kapoor 11 September 2020, 21:41:56 UTC refactor(core): remove unused imports (#38818) This commit removes some unused imports from the spec files. PR Close #38818 18 September 2020, 15:03:51 UTC
093c3a1 JoostK 17 September 2020, 18:40:35 UTC fix(ngcc): fix compilation of `ChangeDetectorRef` in pipe constructors (#38892) In #38666 we changed how ngcc deals with type expressions, where it would now always emit the original type expression into the generated code as a "local" type value reference instead of synthesizing new imports using an "imported" type value reference. This was done as a fix to properly deal with renamed symbols, however it turns out that the compiler has special handling for certain imported symbols, e.g. `ChangeDetectorRef` from `@angular/core`. The "local" type value reference prevented this special logic from being hit, resulting in incorrect compilation of pipe factories. This commit fixes the issue by manually inspecting the import of the type expression, in order to return an "imported" type value reference. By manually inspecting the import we continue to handle renamed symbols. Fixes #38883 PR Close #38892 18 September 2020, 15:02:50 UTC
a0756e9 Pete Bacon Darwin 11 September 2020, 15:43:23 UTC refactor(compiler): replace Comment nodes with leadingComments property (#38811) Common AST formats such as TS and Babel do not use a separate node for comments, but instead attach comments to other AST nodes. Previously this was worked around in TS by creating a `NotEmittedStatement` AST node to attach the comment to. But Babel does not have this facility, so it will not be a viable approach for the linker. This commit refactors the output AST, to remove the `CommentStmt` and `JSDocCommentStmt` nodes. Instead statements have a collection of `leadingComments` that are rendered/attached to the final AST nodes when being translated or printed. PR Close #38811 18 September 2020, 15:01:29 UTC
d8657dd Maksymilian Sielicki 10 September 2020, 22:52:12 UTC docs: updating the text of user input page to reflect real location of the forms page (#38802) PR Close #38802 18 September 2020, 15:00:44 UTC
2f71995 Minko Gechev 17 September 2020, 15:41:14 UTC Update aio/content/marketing/events.json (#38874) Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> PR Close #38874 18 September 2020, 15:00:02 UTC
32a8713 Minko Gechev 16 September 2020, 19:18:25 UTC docs: add upcoming angular conferences (#38874) PR Close #38874 18 September 2020, 14:59:58 UTC
0958a8d Adrien Crivelli 09 July 2020, 09:46:27 UTC docs: drop `newEvent()` compatibility function (#37251) Because PhantomJS has been deprecated since March 2018, and `newEvent` is very confusing for newcomers that read the testing documentation, we remove it entirely, and instead assume most, if not all, newcomers will run tests in Chrome as it is the default. Fixes #23370 PR Close #37251 17 September 2020, 16:31:23 UTC
e64c0c3 Joey Perrott 15 September 2020, 22:38:29 UTC fix(dev-infra): handle no caretaker config being defined (#38862) Properly handle cases where no caretaker config is provided to ng-dev commands PR Close #38862 16 September 2020, 22:22:13 UTC
7302778 Oscar Rosner 16 September 2020, 16:31:24 UTC docs(forms): fix grammar in first sentence of reset function docs (#38872) PR Close #38872 16 September 2020, 22:20:33 UTC
back to top