Revision a82c25c366b0963d33ddf699196e6cf57f6d89b1 authored by Florian Westphal on 08 March 2022, 12:52:11 UTC, committed by Florian Westphal on 08 March 2022, 12:52:11 UTC
This reverts commit 878aed8db324bec64f3c3f956e64d5ae7375a5de.

This change breaks existing setups where conntrack is used with
asymmetric paths.

In these cases, the NAT transformation occurs on the syn-ack instead of
the syn:

1. SYN    x:12345 -> y -> 443 // sent by initiator, receiverd by responder
2. SYNACK y:443 -> x:12345 // First packet seen by conntrack, as sent by responder
3. tuple_force_port_remap() gets called, sees:
  'tcp from 443 to port 12345 NAT' -> pick a new source port, inititor receives
4. SYNACK y:$RANDOM -> x:12345   // connection is never established

While its possible to avoid the breakage with NOTRACK rules, a kernel
update should not break working setups.

An alternative to the revert is to augment conntrack to tag
mid-stream connections plus more code in the nat core to skip NAT
for such connections, however, this leads to more interaction/integration
between conntrack and NAT.

Therefore, revert, users will need to add explicit nat rules to avoid
port shadowing.

Link: https://lore.kernel.org/netfilter-devel/20220302105908.GA5852@breakpoint.cc/#R
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2051413
Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent f8e9bd3
History
File Mode Size
index.rst -rw-r--r-- 367 bytes
leds-blinkm.rst -rw-r--r-- 2.0 KB
leds-class-flash.rst -rw-r--r-- 3.2 KB
leds-class-multicolor.rst -rw-r--r-- 3.0 KB
leds-class.rst -rw-r--r-- 7.2 KB
leds-el15203000.rst -rw-r--r-- 4.3 KB
leds-lm3556.rst -rw-r--r-- 3.0 KB
leds-lp3944.rst -rw-r--r-- 1.5 KB
leds-lp5521.rst -rw-r--r-- 2.9 KB
leds-lp5523.rst -rw-r--r-- 3.4 KB
leds-lp5562.rst -rw-r--r-- 3.6 KB
leds-lp55xx.rst -rw-r--r-- 6.7 KB
leds-mlxcpld.rst -rw-r--r-- 2.4 KB
leds-sc27xx.rst -rw-r--r-- 989 bytes
ledtrig-oneshot.rst -rw-r--r-- 1.5 KB
ledtrig-transient.rst -rw-r--r-- 6.9 KB
ledtrig-usbport.rst -rw-r--r-- 1.4 KB
uleds.rst -rw-r--r-- 1.2 KB
well-known-leds.txt -rw-r--r-- 2.3 KB

back to top