Revision a82c25c366b0963d33ddf699196e6cf57f6d89b1 authored by Florian Westphal on 08 March 2022, 12:52:11 UTC, committed by Florian Westphal on 08 March 2022, 12:52:11 UTC
This reverts commit 878aed8db324bec64f3c3f956e64d5ae7375a5de.

This change breaks existing setups where conntrack is used with
asymmetric paths.

In these cases, the NAT transformation occurs on the syn-ack instead of
the syn:

1. SYN    x:12345 -> y -> 443 // sent by initiator, receiverd by responder
2. SYNACK y:443 -> x:12345 // First packet seen by conntrack, as sent by responder
3. tuple_force_port_remap() gets called, sees:
  'tcp from 443 to port 12345 NAT' -> pick a new source port, inititor receives
4. SYNACK y:$RANDOM -> x:12345   // connection is never established

While its possible to avoid the breakage with NOTRACK rules, a kernel
update should not break working setups.

An alternative to the revert is to augment conntrack to tag
mid-stream connections plus more code in the nat core to skip NAT
for such connections, however, this leads to more interaction/integration
between conntrack and NAT.

Therefore, revert, users will need to add explicit nat rules to avoid
port shadowing.

Link: https://lore.kernel.org/netfilter-devel/20220302105908.GA5852@breakpoint.cc/#R
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2051413
Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent f8e9bd3
History
File Mode Size
i386
x86_64
amd-memory-encryption.rst -rw-r--r-- 4.5 KB
boot.rst -rw-r--r-- 49.9 KB
booting-dt.rst -rw-r--r-- 938 bytes
buslock.rst -rw-r--r-- 4.6 KB
cpuinfo.rst -rw-r--r-- 7.9 KB
earlyprintk.rst -rw-r--r-- 6.2 KB
elf_auxvec.rst -rw-r--r-- 1.4 KB
entry_64.rst -rw-r--r-- 4.2 KB
exception-tables.rst -rw-r--r-- 13.8 KB
features.rst -rw-r--r-- 90 bytes
index.rst -rw-r--r-- 546 bytes
intel-iommu.rst -rw-r--r-- 3.9 KB
intel_txt.rst -rw-r--r-- 10.3 KB
kernel-stacks.rst -rw-r--r-- 6.5 KB
mds.rst -rw-r--r-- 8.5 KB
microcode.rst -rw-r--r-- 4.0 KB
mtrr.rst -rw-r--r-- 11.6 KB
orc-unwinder.rst -rw-r--r-- 8.0 KB
pat.rst -rw-r--r-- 11.5 KB
pti.rst -rw-r--r-- 8.9 KB
resctrl.rst -rw-r--r-- 46.9 KB
sgx.rst -rw-r--r-- 12.2 KB
sva.rst -rw-r--r-- 11.9 KB
tlb.rst -rw-r--r-- 3.6 KB
topology.rst -rw-r--r-- 7.2 KB
tsx_async_abort.rst -rw-r--r-- 6.8 KB
usb-legacy-support.rst -rw-r--r-- 1.8 KB
xstate.rst -rw-r--r-- 3.2 KB
zero-page.rst -rw-r--r-- 2.1 KB

back to top