Revision a82c25c366b0963d33ddf699196e6cf57f6d89b1 authored by Florian Westphal on 08 March 2022, 12:52:11 UTC, committed by Florian Westphal on 08 March 2022, 12:52:11 UTC
This reverts commit 878aed8db324bec64f3c3f956e64d5ae7375a5de. This change breaks existing setups where conntrack is used with asymmetric paths. In these cases, the NAT transformation occurs on the syn-ack instead of the syn: 1. SYN x:12345 -> y -> 443 // sent by initiator, receiverd by responder 2. SYNACK y:443 -> x:12345 // First packet seen by conntrack, as sent by responder 3. tuple_force_port_remap() gets called, sees: 'tcp from 443 to port 12345 NAT' -> pick a new source port, inititor receives 4. SYNACK y:$RANDOM -> x:12345 // connection is never established While its possible to avoid the breakage with NOTRACK rules, a kernel update should not break working setups. An alternative to the revert is to augment conntrack to tag mid-stream connections plus more code in the nat core to skip NAT for such connections, however, this leads to more interaction/integration between conntrack and NAT. Therefore, revert, users will need to add explicit nat rules to avoid port shadowing. Link: https://lore.kernel.org/netfilter-devel/20220302105908.GA5852@breakpoint.cc/#R Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2051413 Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent f8e9bd3
File | Mode | Size |
---|---|---|
unittest-data | ||
Kconfig | -rw-r--r-- | 2.2 KB |
Makefile | -rw-r--r-- | 670 bytes |
address.c | -rw-r--r-- | 27.1 KB |
base.c | -rw-r--r-- | 57.8 KB |
device.c | -rw-r--r-- | 9.8 KB |
dynamic.c | -rw-r--r-- | 22.8 KB |
fdt.c | -rw-r--r-- | 33.9 KB |
fdt_address.c | -rw-r--r-- | 6.2 KB |
irq.c | -rw-r--r-- | 19.7 KB |
kexec.c | -rw-r--r-- | 10.6 KB |
kobj.c | -rw-r--r-- | 3.9 KB |
of_numa.c | -rw-r--r-- | 3.9 KB |
of_private.h | -rw-r--r-- | 5.5 KB |
of_reserved_mem.c | -rw-r--r-- | 11.4 KB |
overlay.c | -rw-r--r-- | 34.3 KB |
pdt.c | -rw-r--r-- | 4.8 KB |
platform.c | -rw-r--r-- | 20.2 KB |
property.c | -rw-r--r-- | 42.5 KB |
resolver.c | -rw-r--r-- | 8.7 KB |
unittest.c | -rw-r--r-- | 93.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...