Revision a82c25c366b0963d33ddf699196e6cf57f6d89b1 authored by Florian Westphal on 08 March 2022, 12:52:11 UTC, committed by Florian Westphal on 08 March 2022, 12:52:11 UTC
This reverts commit 878aed8db324bec64f3c3f956e64d5ae7375a5de. This change breaks existing setups where conntrack is used with asymmetric paths. In these cases, the NAT transformation occurs on the syn-ack instead of the syn: 1. SYN x:12345 -> y -> 443 // sent by initiator, receiverd by responder 2. SYNACK y:443 -> x:12345 // First packet seen by conntrack, as sent by responder 3. tuple_force_port_remap() gets called, sees: 'tcp from 443 to port 12345 NAT' -> pick a new source port, inititor receives 4. SYNACK y:$RANDOM -> x:12345 // connection is never established While its possible to avoid the breakage with NOTRACK rules, a kernel update should not break working setups. An alternative to the revert is to augment conntrack to tag mid-stream connections plus more code in the nat core to skip NAT for such connections, however, this leads to more interaction/integration between conntrack and NAT. Therefore, revert, users will need to add explicit nat rules to avoid port shadowing. Link: https://lore.kernel.org/netfilter-devel/20220302105908.GA5852@breakpoint.cc/#R Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2051413 Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent f8e9bd3
File | Mode | Size |
---|---|---|
controller | ||
endpoint | ||
hotplug | ||
msi | ||
pcie | ||
switch | ||
Kconfig | -rw-r--r-- | 7.1 KB |
Makefile | -rw-r--r-- | 1.2 KB |
access.c | -rw-r--r-- | 15.0 KB |
ats.c | -rw-r--r-- | 11.0 KB |
bus.c | -rw-r--r-- | 10.2 KB |
ecam.c | -rw-r--r-- | 5.6 KB |
host-bridge.c | -rw-r--r-- | 2.4 KB |
iov.c | -rw-r--r-- | 27.0 KB |
irq.c | -rw-r--r-- | 2.4 KB |
mmap.c | -rw-r--r-- | 2.6 KB |
of.c | -rw-r--r-- | 17.0 KB |
p2pdma.c | -rw-r--r-- | 26.2 KB |
pci-acpi.c | -rw-r--r-- | 37.5 KB |
pci-bridge-emul.c | -rw-r--r-- | 15.2 KB |
pci-bridge-emul.h | -rw-r--r-- | 3.3 KB |
pci-driver.c | -rw-r--r-- | 42.0 KB |
pci-label.c | -rw-r--r-- | 5.6 KB |
pci-mid.c | -rw-r--r-- | 1.1 KB |
pci-pf-stub.c | -rw-r--r-- | 1.2 KB |
pci-stub.c | -rw-r--r-- | 2.3 KB |
pci-sysfs.c | -rw-r--r-- | 38.3 KB |
pci.c | -rw-r--r-- | 179.8 KB |
pci.h | -rw-r--r-- | 23.5 KB |
probe.c | -rw-r--r-- | 85.8 KB |
proc.c | -rw-r--r-- | 9.7 KB |
quirks.c | -rw-r--r-- | 208.3 KB |
remove.c | -rw-r--r-- | 3.7 KB |
rom.c | -rw-r--r-- | 5.3 KB |
search.c | -rw-r--r-- | 12.1 KB |
setup-bus.c | -rw-r--r-- | 59.0 KB |
setup-irq.c | -rw-r--r-- | 1.6 KB |
setup-res.c | -rw-r--r-- | 13.1 KB |
slot.c | -rw-r--r-- | 9.7 KB |
syscall.c | -rw-r--r-- | 2.7 KB |
vc.c | -rw-r--r-- | 12.0 KB |
vpd.c | -rw-r--r-- | 14.6 KB |
xen-pcifront.c | -rw-r--r-- | 27.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...