Revision a82c25c366b0963d33ddf699196e6cf57f6d89b1 authored by Florian Westphal on 08 March 2022, 12:52:11 UTC, committed by Florian Westphal on 08 March 2022, 12:52:11 UTC
This reverts commit 878aed8db324bec64f3c3f956e64d5ae7375a5de.

This change breaks existing setups where conntrack is used with
asymmetric paths.

In these cases, the NAT transformation occurs on the syn-ack instead of
the syn:

1. SYN    x:12345 -> y -> 443 // sent by initiator, receiverd by responder
2. SYNACK y:443 -> x:12345 // First packet seen by conntrack, as sent by responder
3. tuple_force_port_remap() gets called, sees:
  'tcp from 443 to port 12345 NAT' -> pick a new source port, inititor receives
4. SYNACK y:$RANDOM -> x:12345   // connection is never established

While its possible to avoid the breakage with NOTRACK rules, a kernel
update should not break working setups.

An alternative to the revert is to augment conntrack to tag
mid-stream connections plus more code in the nat core to skip NAT
for such connections, however, this leads to more interaction/integration
between conntrack and NAT.

Therefore, revert, users will need to add explicit nat rules to avoid
port shadowing.

Link: https://lore.kernel.org/netfilter-devel/20220302105908.GA5852@breakpoint.cc/#R
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2051413
Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent f8e9bd3
History
File Mode Size
Kconfig -rw-r--r-- 3.4 KB
Makefile -rw-r--r-- 530 bytes
espintcp.c -rw-r--r-- 12.6 KB
xfrm_algo.c -rw-r--r-- 14.5 KB
xfrm_compat.c -rw-r--r-- 19.3 KB
xfrm_device.c -rw-r--r-- 9.9 KB
xfrm_hash.c -rw-r--r-- 803 bytes
xfrm_hash.h -rw-r--r-- 4.6 KB
xfrm_inout.h -rw-r--r-- 1.8 KB
xfrm_input.c -rw-r--r-- 18.9 KB
xfrm_interface.c -rw-r--r-- 22.9 KB
xfrm_ipcomp.c -rw-r--r-- 7.4 KB
xfrm_output.c -rw-r--r-- 21.1 KB
xfrm_policy.c -rw-r--r-- 106.1 KB
xfrm_proc.c -rw-r--r-- 2.8 KB
xfrm_replay.c -rw-r--r-- 18.5 KB
xfrm_state.c -rw-r--r-- 68.4 KB
xfrm_sysctl.c -rw-r--r-- 1.9 KB
xfrm_user.c -rw-r--r-- 84.9 KB

back to top