Revision a82c25c366b0963d33ddf699196e6cf57f6d89b1 authored by Florian Westphal on 08 March 2022, 12:52:11 UTC, committed by Florian Westphal on 08 March 2022, 12:52:11 UTC
This reverts commit 878aed8db324bec64f3c3f956e64d5ae7375a5de. This change breaks existing setups where conntrack is used with asymmetric paths. In these cases, the NAT transformation occurs on the syn-ack instead of the syn: 1. SYN x:12345 -> y -> 443 // sent by initiator, receiverd by responder 2. SYNACK y:443 -> x:12345 // First packet seen by conntrack, as sent by responder 3. tuple_force_port_remap() gets called, sees: 'tcp from 443 to port 12345 NAT' -> pick a new source port, inititor receives 4. SYNACK y:$RANDOM -> x:12345 // connection is never established While its possible to avoid the breakage with NOTRACK rules, a kernel update should not break working setups. An alternative to the revert is to augment conntrack to tag mid-stream connections plus more code in the nat core to skip NAT for such connections, however, this leads to more interaction/integration between conntrack and NAT. Therefore, revert, users will need to add explicit nat rules to avoid port shadowing. Link: https://lore.kernel.org/netfilter-devel/20220302105908.GA5852@breakpoint.cc/#R Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2051413 Signed-off-by: Florian Westphal <fw@strlen.de>
1 parent f8e9bd3
File | Mode | Size |
---|---|---|
oss | ||
seq | ||
Kconfig | -rw-r--r-- | 5.5 KB |
Makefile | -rw-r--r-- | 1.6 KB |
compress_offload.c | -rw-r--r-- | 30.0 KB |
control.c | -rw-r--r-- | 60.2 KB |
control_compat.c | -rw-r--r-- | 12.2 KB |
control_led.c | -rw-r--r-- | 19.9 KB |
ctljack.c | -rw-r--r-- | 2.0 KB |
device.c | -rw-r--r-- | 6.4 KB |
hrtimer.c | -rw-r--r-- | 3.6 KB |
hwdep.c | -rw-r--r-- | 12.6 KB |
hwdep_compat.c | -rw-r--r-- | 1.4 KB |
info.c | -rw-r--r-- | 20.2 KB |
info_oss.c | -rw-r--r-- | 2.8 KB |
init.c | -rw-r--r-- | 29.2 KB |
isadma.c | -rw-r--r-- | 3.1 KB |
jack.c | -rw-r--r-- | 17.2 KB |
memalloc.c | -rw-r--r-- | 19.8 KB |
memalloc_local.h | -rw-r--r-- | 741 bytes |
memory.c | -rw-r--r-- | 1.8 KB |
misc.c | -rw-r--r-- | 3.5 KB |
pcm.c | -rw-r--r-- | 32.9 KB |
pcm_compat.c | -rw-r--r-- | 19.0 KB |
pcm_dmaengine.c | -rw-r--r-- | 13.7 KB |
pcm_drm_eld.c | -rw-r--r-- | 2.3 KB |
pcm_iec958.c | -rw-r--r-- | 5.9 KB |
pcm_lib.c | -rw-r--r-- | 69.7 KB |
pcm_local.h | -rw-r--r-- | 3.0 KB |
pcm_memory.c | -rw-r--r-- | 15.9 KB |
pcm_misc.c | -rw-r--r-- | 16.0 KB |
pcm_native.c | -rw-r--r-- | 112.4 KB |
pcm_param_trace.h | -rw-r--r-- | 4.5 KB |
pcm_timer.c | -rw-r--r-- | 3.0 KB |
pcm_trace.h | -rw-r--r-- | 5.0 KB |
rawmidi.c | -rw-r--r-- | 55.5 KB |
rawmidi_compat.c | -rw-r--r-- | 3.3 KB |
seq_device.c | -rw-r--r-- | 7.1 KB |
sound.c | -rw-r--r-- | 10.2 KB |
sound_oss.c | -rw-r--r-- | 6.4 KB |
timer.c | -rw-r--r-- | 58.4 KB |
timer_compat.c | -rw-r--r-- | 3.5 KB |
vmaster.c | -rw-r--r-- | 14.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...