Skip to main content

Browse the archive

Revision a84a79e4d369a73c0130b5858199e949432da4c6 authored by Linus Torvalds on 17 October 2011, 15:24:24 UTC, committed by Linus Torvalds on 17 October 2011, 15:24:24 UTC 
Avoid using variable-length arrays in kernel/sys.c
 
The size is always valid, but variable-length arrays generate worse code
for no good reason (unless the function happens to be inlined and the
compiler sees the length for the simple constant it is).

Also, there seems to be some code generation problem on POWER, where
Henrik Bakken reports that register r28 can get corrupted under some
subtle circumstances (interrupt happening at the wrong time?).  That all
indicates some seriously broken compiler issues, but since variable
length arrays are bad regardless, there's little point in trying to
chase it down.

"Just don't do that, then".

Reported-by: Henrik Grindal Bakken <henribak@cisco.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 8bc03e8
Raw File
LICENSE.SRC 
Code in this directory written at the IDA Supercomputing Research Center
carries the following copyright and license.

    Copyright 1993 United States Government as represented by the
    Director, National Security Agency.  This software may be used
    and distributed according to the terms of the GNU General Public License,
    incorporated herein by reference.

    In addition to the disclaimers in the GPL, SRC expressly disclaims any
    and all warranties, expressed or implied, concerning the enclosed software.
    This software was developed at SRC for use in internal research, and the
    intent in sharing this software is to promote the productive interchange
    of ideas throughout the research community.   All software is furnished
    on an "as-is" basis.  No further updates to this software should be
    expected.  Although updates may occur, no commitment exists.
back to top