Revision a87f3fe01a5a894aa27ccd6a239155fd129988e4 authored by Benjamin Kaduk on 10 April 2020, 19:27:28 UTC, committed by Matt Caswell on 21 April 2020, 12:32:35 UTC
In the tls1_check_sig_alg() helper function, we loop through the list of
"signature_algorithms_cert" values received from the client and attempt
to look up each one in turn in our internal table that maps wire
codepoint to string-form name, digest and/or signature NID, etc., in
order to compare the signature scheme from the peer's list against what
is used to sign the certificates in the certificate chain we're
checking.  Unfortunately, when the peer sends a value that we don't
support, the lookup returns NULL, but we unconditionally dereference the
lookup result for the comparison, leading to an application crash
triggerable by an unauthenticated client.

Since we will not be able to say anything about algorithms we don't
recognize, treat NULL return from lookup as "does not match".

We currently only apply the "signature_algorithm_cert" checks on TLS 1.3
connections, so previous TLS versions are unaffected.  SSL_check_chain()
is not called directly from libssl, but may be used by the application
inside a callback (e.g., client_hello or cert callback) to verify that a
candidate certificate chain will be acceptable to the client.

CVE-2020-1967

Reviewed-by: Matt Caswell <matt@openssl.org>
1 parent 3656c08
History
File Mode Size
.github
Configurations
VMS
apps
boringssl @ 2070f8a
crypto
demos
dev
doc
engines
external
fuzz
include
krb5 @ 890ca2f
ms
os-dep
providers
pyca-cryptography @ 0940310
ssl
test
tools
util
.gitattributes -rw-r--r-- 501 bytes
.gitignore -rw-r--r-- 3.3 KB
.gitmodules -rw-r--r-- 270 bytes
.travis-apt-pin.preferences -rw-r--r-- 256 bytes
.travis-create-release.sh -rw-r--r-- 44 bytes
.travis.yml -rw-r--r-- 10.7 KB
ACKNOWLEDGEMENTS.md -rw-r--r-- 159 bytes
AUTHORS.md -rw-r--r-- 862 bytes
CHANGES.md -rw-r--r-- 676.6 KB
CONTRIBUTING.md -rw-r--r-- 4.0 KB
Configure -rwxr-xr-x 121.4 KB
FAQ.md -rw-r--r-- 197 bytes
HACKING -rw-r--r-- 1.1 KB
INSTALL.md -rw-r--r-- 60.5 KB
LICENSE -rw-r--r-- 9.9 KB
NEWS.md -rw-r--r-- 64.3 KB
NOTES.ANDROID -rw-r--r-- 4.4 KB
NOTES.DJGPP -rw-r--r-- 2.0 KB
NOTES.PERL -rw-r--r-- 4.5 KB
NOTES.UNIX -rw-r--r-- 5.4 KB
NOTES.VALGRIND -rw-r--r-- 2.6 KB
NOTES.VMS -rw-r--r-- 3.6 KB
NOTES.WIN -rw-r--r-- 7.2 KB
README.ENGINE -rw-r--r-- 15.7 KB
README.FIPS -rw-r--r-- 61 bytes
README.md -rw-r--r-- 6.6 KB
SUPPORT.md -rw-r--r-- 4.8 KB
VERSION -rw-r--r-- 90 bytes
appveyor.yml -rw-r--r-- 2.5 KB
build.info -rw-r--r-- 1.3 KB
config -rwxr-xr-x 27.6 KB
config.com -rw-r--r-- 2.5 KB
configdata.pm.in -rw-r--r-- 13.7 KB
e_os.h -rw-r--r-- 9.1 KB

README.md

back to top