Revision - a8fad07 - Don't assume file_is_test when there's a top-level non-assert error - origin: https://github.com/web-platform-tests/wpt

visit type:

https://github.com/web-platform-tests/wpt

26 December 2018, 22:31:15 UTC

Revision a8fad0798ea933c6e48cc7910959dd9add4b1ec1 authored by James Graham on 15 May 2018, 21:31:15 UTC, committed by James Graham on 16 May 2018, 08:43:02 UTC

Don't assume file_is_test when there's a top-level non-assert error

Previously, if we got an unexpected error before any asserts ran, we
would assume that the file represented a single-test file and imply a
subtest. However this is confusing in the case that the assumptions
are wrong because we see different subtests in browsers that have an
early error vs those that do not.

Instead of this, we only set file_is_test when we call assert()
outside a test, and in other cases set the overall status to ERROR and
leave the list of subtests empty.

1 parent b395fb0

Files
Changes

Permalinks

Tip revision: a8fad0798ea933c6e48cc7910959dd9add4b1ec1 authored by James Graham on 15 May 2018, 21:31:15 UTC
Don't assume file_is_test when there's a top-level non-assert error

Tip revision: a8fad07

File	Mode	Size
.well-known
2dcontext
BackgroundSync
FileAPI
IndexedDB
WebCryptoAPI
WebIDL
accelerometer
accname
acid
ambient-light
annotation-model
annotation-protocol
annotation-vocab
apng
async-local-storage
audio-output
background-fetch
battery-status
beacon
bluetooth
budget-api
clear-site-data
client-hints
clipboard-apis
common
compat
conformance-checkers
console
content-security-policy
cookie-store
cookies
core-aam
cors
credential-management
css
custom-elements
device-memory
docs
dom
domparsing
domxpath
dpub-aam
dpub-aria
editing
encoding
encrypted-media
entries-api
eventsource
feature-policy
fetch
fonts
fullscreen
gamepad
generic-sensor
geolocation-API
geolocation-sensor
graphics-aam
gyroscope
hr-time
html
html-imports
html-longdesc
html-media-capture
imagebitmap-renderingcontext
images
infrastructure
input-events
interfaces
intersection-observer
js
keyboard-lock
keyboard-map
longtask-timing
magnetometer
mathml
media
media-capabilities
media-source
mediacapture-fromelement
mediacapture-image
mediacapture-record
mediacapture-streams
mediasession
mimesniff
mixed-content
navigation-timing
netinfo
notifications
offscreen-canvas
old-tests
orientation-event
orientation-sensor
page-visibility
paint-timing
payment-handler
payment-method-basic-card
payment-method-id
payment-request
performance-timeline
picture-in-picture
pointerevents
pointerlock
preload
presentation-api
proximity
quirks
referrer-policy
remote-playback
requestidlecallback
resize-observer
resource-timing
resources
screen-orientation
secure-contexts
selection
server-timing
service-workers
shadow-dom
speech-api
storage
streams
subresource-integrity
svg
svg-aam
tools
touch-events
trusted-types
uievents
upgrade-insecure-requests
url
user-timing
vibration
visual-viewport
wai-aria
wake-lock
wasm
web-animations
web-nfc
web-share
webaudio
webauthn
webdriver
webgl
webmessaging
webrtc
websockets
webstorage
webusb
webvr
webvtt
webxr
workers
worklets
x-frame-options
xhr
.codecov.yml	-rw-r--r--	66 bytes
.gitignore	-rw-r--r--	340 bytes
.gitmodules	-rw-r--r--	519 bytes
.pyup.yml	-rw-r--r--	1.0 KB
.taskcluster.yml	-rw-r--r--	39.6 KB
.travis.yml	-rw-r--r--	2.9 KB
CONTRIBUTING.md	-rw-r--r--	1.6 KB
LICENSE.md	-rw-r--r--	5.1 KB
README.md	-rw-r--r--	16.7 KB
check_stability.ini	-rw-r--r--	527 bytes
lint.whitelist	-rw-r--r--	45.3 KB
serve.py	-rw-r--r--	263 bytes
server-side.md	-rw-r--r--	8.1 KB
testharness_runner.html	-rw-r--r--	95 bytes
update-built-tests.sh	-rwxr-xr-x	208 bytes
wpt	-rwxr-xr-x	95 bytes
wpt.py	-rw-r--r--	15 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/web-platform-tests/wpt

Don't assume file_is_test when there's a top-level non-assert error

README.md