Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 August 2024, 15:42:30 UTC
Revision a98fdcef941e107eeabae622d85a1f476f25a160 authored by Oleg Nesterov on 14 January 2008, 21:02:37 UTC, committed by Linus Torvalds on 14 January 2008, 21:23:00 UTC 
fix the "remove task_ppid_nr_ns" commit
 
Commit 84427eaef1fb91704c7112bdb598c810003b99f3 (remove task_ppid_nr_ns)
moved the task_tgid_nr_ns(task->real_parent) outside of lock_task_sighand().
This is wrong, ->real_parent could be freed/reused.

Both ->parent/real_parent point to nothing after __exit_signal() because
we remove the child from ->children list, and thus the child can't be
reparented when its parent exits.

rcu_read_lock() protects ->parent/real_parent, but _only_ if we know it was
valid before we take rcu lock.

Revert this part of the patch.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4fd3670
History
Tip revision: a98fdcef941e107eeabae622d85a1f476f25a160 authored by Oleg Nesterov on 14 January 2008, 21:02:37 UTC
fix the "remove task_ppid_nr_ns" commit
Tip revision: a98fdce
File Mode Size
Kconfig -rw-r--r-- 6.9 KB
Makefile -rw-r--r-- 270 bytes
console.c -rw-r--r-- 1.1 KB
disk.c -rw-r--r-- 16.7 KB
main.c -rw-r--r-- 8.2 KB
pm.c -rw-r--r-- 6.0 KB
power.h -rw-r--r-- 6.9 KB
poweroff.c -rw-r--r-- 905 bytes
process.c -rw-r--r-- 6.3 KB
snapshot.c -rw-r--r-- 49.9 KB
swap.c -rw-r--r-- 14.6 KB
swsusp.c -rw-r--r-- 7.7 KB
user.c -rw-r--r-- 7.5 KB
back to top