Revision a98fdcef941e107eeabae622d85a1f476f25a160 authored by Oleg Nesterov on 14 January 2008, 21:02:37 UTC, committed by Linus Torvalds on 14 January 2008, 21:23:00 UTC
Commit 84427eaef1fb91704c7112bdb598c810003b99f3 (remove task_ppid_nr_ns)
moved the task_tgid_nr_ns(task->real_parent) outside of lock_task_sighand().
This is wrong, ->real_parent could be freed/reused.

Both ->parent/real_parent point to nothing after __exit_signal() because
we remove the child from ->children list, and thus the child can't be
reparented when its parent exits.

rcu_read_lock() protects ->parent/real_parent, but _only_ if we know it was
valid before we take rcu lock.

Revert this part of the patch.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4fd3670
Raw File
switch_to.S
/*
 * Copyright (C) 2004-2006 Atmel Corporation
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
 * published by the Free Software Foundation.
 */

#include <asm/sysreg.h>

	.text
	.global	__switch_to
	.type	__switch_to, @function

	/* Switch thread context from "prev" to "next", returning "last"
	 *   r12 :	prev
	 *   r11 :	&prev->thread + 1
	 *   r10 :	&next->thread
	 */
__switch_to:
	stm	--r11, r0,r1,r2,r3,r4,r5,r6,r7,sp,lr
	mfsr	r9, SYSREG_SR
	st.w	--r11, r9
	ld.w	r8, r10++
	/*
	 * schedule() may have been called from a mode with a different
	 * set of registers. Make sure we don't lose anything here.
	 */
	pushm	r10,r12
	mtsr	SYSREG_SR, r8
	frs			/* flush the return stack */
	sub	pc, -2		/* flush the pipeline */
	popm	r10,r12
	ldm	r10++, r0,r1,r2,r3,r4,r5,r6,r7,sp,pc
	.size	__switch_to, . - __switch_to
back to top