Revision a98fdcef941e107eeabae622d85a1f476f25a160 authored by Oleg Nesterov on 14 January 2008, 21:02:37 UTC, committed by Linus Torvalds on 14 January 2008, 21:23:00 UTC
Commit 84427eaef1fb91704c7112bdb598c810003b99f3 (remove task_ppid_nr_ns)
moved the task_tgid_nr_ns(task->real_parent) outside of lock_task_sighand().
This is wrong, ->real_parent could be freed/reused.

Both ->parent/real_parent point to nothing after __exit_signal() because
we remove the child from ->children list, and thus the child can't be
reparented when its parent exits.

rcu_read_lock() protects ->parent/real_parent, but _only_ if we know it was
valid before we take rcu lock.

Revert this part of the patch.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4fd3670
History
File Mode Size
Kconfig -rw-r--r-- 442 bytes
Makefile -rw-r--r-- 297 bytes
netlabel_cipso_v4.c -rw-r--r-- 20.8 KB
netlabel_cipso_v4.h -rw-r--r-- 4.7 KB
netlabel_domainhash.c -rw-r--r-- 11.5 KB
netlabel_domainhash.h -rw-r--r-- 2.1 KB
netlabel_kapi.c -rw-r--r-- 11.7 KB
netlabel_mgmt.c -rw-r--r-- 17.5 KB
netlabel_mgmt.h -rw-r--r-- 4.9 KB
netlabel_unlabeled.c -rw-r--r-- 7.1 KB
netlabel_unlabeled.h -rw-r--r-- 2.6 KB
netlabel_user.c -rw-r--r-- 3.1 KB
netlabel_user.h -rw-r--r-- 1.9 KB

back to top