Revision a98fdcef941e107eeabae622d85a1f476f25a160 authored by Oleg Nesterov on 14 January 2008, 21:02:37 UTC, committed by Linus Torvalds on 14 January 2008, 21:23:00 UTC
Commit 84427eaef1fb91704c7112bdb598c810003b99f3 (remove task_ppid_nr_ns)
moved the task_tgid_nr_ns(task->real_parent) outside of lock_task_sighand().
This is wrong, ->real_parent could be freed/reused.

Both ->parent/real_parent point to nothing after __exit_signal() because
we remove the child from ->children list, and thus the child can't be
reparented when its parent exits.

rcu_read_lock() protects ->parent/real_parent, but _only_ if we know it was
valid before we take rcu lock.

Revert this part of the patch.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4fd3670
History
File Mode Size
Kconfig -rw-r--r-- 15.6 KB
Makefile -rw-r--r-- 1.6 KB
act_api.c -rw-r--r-- 22.8 KB
act_gact.c -rw-r--r-- 5.3 KB
act_ipt.c -rw-r--r-- 7.2 KB
act_mirred.c -rw-r--r-- 6.0 KB
act_nat.c -rw-r--r-- 7.0 KB
act_pedit.c -rw-r--r-- 5.9 KB
act_police.c -rw-r--r-- 9.1 KB
act_simple.c -rw-r--r-- 5.0 KB
cls_api.c -rw-r--r-- 13.1 KB
cls_basic.c -rw-r--r-- 6.4 KB
cls_fw.c -rw-r--r-- 8.3 KB
cls_route.c -rw-r--r-- 12.3 KB
cls_rsvp.c -rw-r--r-- 761 bytes
cls_rsvp.h -rw-r--r-- 14.6 KB
cls_rsvp6.c -rw-r--r-- 768 bytes
cls_tcindex.c -rw-r--r-- 12.1 KB
cls_u32.c -rw-r--r-- 16.2 KB
em_cmp.c -rw-r--r-- 2.1 KB
em_meta.c -rw-r--r-- 20.8 KB
em_nbyte.c -rw-r--r-- 1.9 KB
em_text.c -rw-r--r-- 3.6 KB
em_u32.c -rw-r--r-- 1.4 KB
ematch.c -rw-r--r-- 14.5 KB
sch_api.c -rw-r--r-- 29.3 KB
sch_atm.c -rw-r--r-- 19.7 KB
sch_blackhole.c -rw-r--r-- 1.2 KB
sch_cbq.c -rw-r--r-- 47.5 KB
sch_dsmark.c -rw-r--r-- 11.0 KB
sch_fifo.c -rw-r--r-- 2.5 KB
sch_generic.c -rw-r--r-- 14.7 KB
sch_gred.c -rw-r--r-- 13.4 KB
sch_hfsc.c -rw-r--r-- 40.3 KB
sch_htb.c -rw-r--r-- 42.3 KB
sch_ingress.c -rw-r--r-- 8.7 KB
sch_netem.c -rw-r--r-- 17.4 KB
sch_prio.c -rw-r--r-- 11.5 KB
sch_red.c -rw-r--r-- 8.8 KB
sch_sfq.c -rw-r--r-- 11.9 KB
sch_tbf.c -rw-r--r-- 11.4 KB
sch_teql.c -rw-r--r-- 11.4 KB

back to top