Skip to main content

Browse the archive

https://github.com/torvalds/linux
08 September 2024, 02:26:05 UTC
Revision ab2bb148c5932712d2717a7f3a452846f07a660a authored by Faidon Liambotis on 11 July 2013, 21:08:09 UTC, committed by Ralf Baechle on 19 July 2013, 09:04:54 UTC 
MIPS: Octeon: Fix DT pruning bug with pip ports
 
During the pruning of the device tree octeon_fdt_pip_iface() is called
for each PIP interface and every port up to the port count is removed
from the device tree. However, the count was set to the return value of
cvmx_helper_interface_enumerate() which doesn't actually return the
count but just returns zero on success. This effectively removed *all*
ports from the tree.

Use cvmx_helper_ports_on_interface() instead to fix this. This
successfully restores the 3 ports of my ERLite-3 and fixes the "kernel
assigns random MAC addresses" issue.

Signed-off-by: Faidon Liambotis <paravoid@debian.org>
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: David Daney <david.daney@cavium.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/5587/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
1 parent f2a5b1d
History
Tip revision: ab2bb148c5932712d2717a7f3a452846f07a660a authored by Faidon Liambotis on 11 July 2013, 21:08:09 UTC
MIPS: Octeon: Fix DT pruning bug with pip ports
Tip revision: ab2bb14
File Mode Size
aoa
arm
atmel
core
drivers
firewire
i2c
isa
mips
oss
parisc
pci
pcmcia
ppc
sh
soc
sparc
spi
synth
usb
Kconfig -rw-r--r-- 3.8 KB
Makefile -rw-r--r-- 539 bytes
ac97_bus.c -rw-r--r-- 1.6 KB
last.c -rw-r--r-- 1.2 KB
sound_core.c -rw-r--r-- 15.9 KB
sound_firmware.c -rw-r--r-- 1.6 KB
back to top