Skip to main content

Browse the archive

Revision ab5780956dda798c97707e05fd2e58df7963b6d0 authored by Harald Alvestrand on 05 October 2018, 09:29:42 UTC, committed by Chromium WPT Sync on 05 October 2018, 09:29:42 UTC 
Revert "Implement DTMF [[ToneBuffer]] in the blink layer"
 
This reverts commit 3f90035e2fac160d23309a96ef2cf465b29cebe4.

Reason for revert: The original problem was solved using another approach, and this CL just adds complexity with no purpose.

Original change's description:
> Implement DTMF [[ToneBuffer]] in the blink layer
>
> This CL makes the Blink layer keep a copy of the tone buffer
> and update it on insertDTMF and ontonechange events only; this
> makes it possible to expose the state of the tone buffer at the
> time the event is fired to the Javascript callback.
>
> It removes a queueing step inside the DTMF sender, because
> that queueing step destroyed the consistency.
>
> Bug: chromium:816475
> Change-Id: I5aa68396299a67d6cea1e8a17d364f553514c291
> Reviewed-on: https://chromium-review.googlesource.com/1213084
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589910}

TBR=hta@chromium.org,haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,foolip@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:816475
Change-Id: Iaee9fefa8a37e3c6c7256dacac0855f426601e0d
1 parent 006e385
Raw File
t022-manual.html 
<!DOCTYPE html>
<html>
  <head>
    <title>The corresponding event must be of type DeviceOrientationEvent and must fire on the window object</title>
    <meta name=viewport content="width=device-width, maximum-scale=1.0">
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
    <link rel="author" title="Mosquito FP7">
    <link rel="reviewer author" title="Zhiqiang Zhang" href="mailto:zhiqiang.zhang@intel.com"> <!-- 2013-10-14 -->
  </head>
  <body>
    <p>Move the device to run the test.</p>
    <div id="log"></div>
    <script>
      var t1 = async_test("The corresponding event must be of type DeviceMotionEvent");
      var t2 = async_test("The corresponding event must fire on the window object");
      var run = false;
      window.addEventListener("devicemotion", function(e) {
        if (!run) {
          run = true;
          t1.step(function() {
            assert_equals(e.type, "devicemotion");
          });
          t1.done();
          t2.step(function() {
            assert_true(e.target instanceof Window);
          });
          t2.done();
        }
      }, false);
    </script>
  </body>
</html>
back to top