Skip to main content

Browse the archive

Revision ac4966fa4dcda8e22ade19e03ed6690de7b9cece authored by Henrik Boström on 28 March 2018, 15:48:04 UTC, committed by Chromium WPT Sync on 28 March 2018, 15:48:04 UTC 
RTCRtpSender.getStats() in blink added behind flag.
 
This exposes RTCRtpSender.getStats() in JavaScript (behind flag) which
implements the stats selection algorithm[1] for senders.

[1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm

Bug: 680172
Change-Id: I8117c87f475d1c78fa3301fc2d821f0c3a21281f
Reviewed-on: https://chromium-review.googlesource.com/975306
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546493}
1 parent f9c1a50
Raw File
transaction-deactivation-timing.html 
<!DOCTYPE html>
<meta charset=utf-8>
<title>Transactions deactivation timing</title>
<link rel="help" href="https://w3c.github.io/IndexedDB/#dom-idbdatabase-transaction">
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src=support.js></script>
<script>

indexeddb_test(
  (t, db, tx) => {
    db.createObjectStore('store');
  },
  (t, db) => {
    const tx = db.transaction('store');
    const release_tx = keep_alive(tx, 'store');
    assert_true(is_transaction_active(tx, 'store'),
                'Transaction should be active after creation');

    setTimeout(t.step_func(() => {
      assert_false(is_transaction_active(tx, 'store'),
                   'Transaction should be inactive in next task');
      release_tx();
      t.done();
    }), 0);
  },
  'New transactions are deactivated before next task');

indexeddb_test(
  (t, db, tx) => {
    db.createObjectStore('store');
  },
  (t, db) => {
    const tx = db.transaction('store');
    const release_tx = keep_alive(tx, 'store');
    assert_true(is_transaction_active(tx, 'store'),
                'Transaction should be active after creation');

    Promise.resolve().then(t.step_func(() => {
      assert_true(is_transaction_active(tx, 'store'),
                  'Transaction should be active in microtask checkpoint');
      release_tx();
      t.done();
    }));
  },
  'New transactions are not deactivated until after the microtask checkpoint');

indexeddb_test(
  (t, db, tx) => {
    db.createObjectStore('store');
  },
  (t, db) => {
    let tx, release_tx;

    Promise.resolve().then(t.step_func(() => {
      tx = db.transaction('store');
      release_tx = keep_alive(tx, 'store');
      assert_true(is_transaction_active(tx, 'store'),
                  'Transaction should be active after creation');
    }));

    setTimeout(t.step_func(() => {
      assert_false(is_transaction_active(tx, 'store'),
                   'Transaction should be inactive in next task');
      release_tx();
      t.done();
    }), 0);
  },
  'New transactions from microtask are deactivated before next task');

indexeddb_test(
  (t, db, tx) => {
    db.createObjectStore('store');
  },
  (t, db) => {
    let tx, release_tx;

    Promise.resolve().then(t.step_func(() => {
      tx = db.transaction('store');
      release_tx = keep_alive(tx, 'store');
      assert_true(is_transaction_active(tx, 'store'),
                  'Transaction should be active after creation');
    }));

    Promise.resolve().then(t.step_func(() => {
      assert_true(is_transaction_active(tx, 'store'),
                  'Transaction should be active in microtask checkpoint');
      release_tx();
      t.done();
    }));
  },
  'New transactions from microtask are still active through the ' +
  'microtask checkpoint');


indexeddb_test(
  (t, db, tx) => {
    db.createObjectStore('store');
  },
  (t, db) => {
    // This transaction serves as the source of an event seen by multiple
    // listeners. A DOM event with multiple listeners could be used instead,
    // but not via dispatchEvent() because (drumroll...) that happens
    // synchronously so microtasks don't run between steps.
    const tx = db.transaction('store');
    assert_true(is_transaction_active(tx, 'store'),
                'Transaction should be active after creation');

    const request = tx.objectStore('store').get(0);
    let new_tx;
    let first_listener_ran = false;
    let microtasks_ran = false;
    request.addEventListener('success', t.step_func(() => {
      first_listener_ran = true;
      assert_true(is_transaction_active(tx, 'store'),
                  'Transaction should be active in callback');

      // We check to see if this transaction is active across unrelated event
      // dispatch steps.
      new_tx = db.transaction('store');
      assert_true(is_transaction_active(new_tx, 'store'),
                  'New transaction should be active after creation');

      Promise.resolve().then(t.step_func(() => {
        microtasks_ran = true;
        assert_true(is_transaction_active(new_tx, 'store'),
                    'New transaction is still active in microtask checkpoint');
      }));

    }));
    request.addEventListener('success', t.step_func(() => {
      assert_true(first_listener_ran, 'first listener ran first');
      assert_true(microtasks_ran, 'microtasks ran before second listener');
      assert_true(is_transaction_active(tx, 'store'),
                  'Transaction should be active in callback');
      assert_false(is_transaction_active(new_tx, 'store'),
                   'New transaction should be inactive in unrelated callback');
      t.done();
    }));
  },
  'Deactivation of new transactions happens at end of invocation');

</script>
back to top