Skip to main content

Browse the archive

https://github.com/torvalds/linux
13 August 2024, 17:29:01 UTC
Revision ad3e14d7c5268c2e24477c6ef54bbdf88add5d36 authored by Jiri Kosina on 21 August 2014, 14:57:17 UTC, committed by Jiri Kosina on 21 August 2014, 15:43:06 UTC 
HID: logitech: perform bounds checking on device_id early enough
 
device_index is a char type and the size of paired_dj_deivces is 7
elements, therefore proper bounds checking has to be applied to
device_index before it is used.

We are currently performing the bounds checking in
logi_dj_recv_add_djhid_device(), which is too late, as malicious device
could send REPORT_TYPE_NOTIF_DEVICE_UNPAIRED early enough and trigger the
problem in one of the report forwarding functions called from
logi_dj_raw_event().

Fix this by performing the check at the earliest possible ocasion in
logi_dj_raw_event().

Cc: stable@vger.kernel.org
Reported-by: Ben Hawkes <hawkes@google.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
1 parent 51217e6
History
Tip revision: ad3e14d7c5268c2e24477c6ef54bbdf88add5d36 authored by Jiri Kosina on 21 August 2014, 14:57:17 UTC
HID: logitech: perform bounds checking on device_id early enough
Tip revision: ad3e14d
File Mode Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.gitignore -rw-r--r-- 1.1 KB
.mailmap -rw-r--r-- 4.7 KB
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 93.7 KB
Kbuild -rw-r--r-- 2.5 KB
Kconfig -rw-r--r-- 252 bytes
MAINTAINERS -rw-r--r-- 276.9 KB
Makefile -rw-r--r-- 51.1 KB
README -rw-r--r-- 18.3 KB
REPORTING-BUGS -rw-r--r-- 7.3 KB

README

back to top