Revision ad576e63e0c8b274a8558b8e05a6d0526e804dc0 authored by Nick Piggin on 05 May 2005, 23:15:46 UTC, committed by Linus Torvalds on 05 May 2005, 23:36:40 UTC
When running fsstress -v -d $DIR/tmp -n 1000 -p 1000 -l 2 on an ext2 filesystem with 1024 byte block size, on SMP i386 with 4096 byte page size over loopback to an image file on a tmpfs filesystem, I would very quickly hit BUG_ON(!buffer_async_write(bh)); in fs/buffer.c:end_buffer_async_write It seems that more than one request would be submitted for a given bh at a time. What would happen is the following: 2 threads doing __mpage_writepages on the same page. Thread 1 - lock the page first, and enter __block_write_full_page. Thread 1 - (eg.) mark_buffer_async_write on the first 2 buffers. Thread 1 - set page writeback, unlock page. Thread 2 - lock page, wait on page writeback Thread 1 - submit_bh on the first 2 buffers. => both requests complete, none of the page buffers are async_write, end_page_writeback is called. Thread 2 - wakes up. enters __block_write_full_page. Thread 2 - mark_buffer_async_write on (eg.) the last buffer Thread 1 - finds the last buffer has async_write set, submit_bh on that. Thread 2 - submit_bh on the last buffer. => oops. So change __block_write_full_page to explicitly keep track of the last bh we need to issue, so we don't touch anything after issuing the last request. Signed-off-by: Nick Piggin <nickpiggin@yahoo.com.au> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent f3ddbdc
File | Mode | Size |
---|---|---|
ChangeLog | -rw-r--r-- | 14.0 KB |
Makefile | -rw-r--r-- | 164 bytes |
TODO | -rw-r--r-- | 385 bytes |
attribute.c | -rw-r--r-- | 1.8 KB |
befs.h | -rw-r--r-- | 3.2 KB |
befs_fs_types.h | -rw-r--r-- | 3.8 KB |
btree.c | -rw-r--r-- | 22.0 KB |
btree.h | -rw-r--r-- | 300 bytes |
datastream.c | -rw-r--r-- | 15.6 KB |
datastream.h | -rw-r--r-- | 514 bytes |
debug.c | -rw-r--r-- | 7.6 KB |
endian.h | -rw-r--r-- | 2.8 KB |
inode.c | -rw-r--r-- | 1.1 KB |
inode.h | -rw-r--r-- | 123 bytes |
io.c | -rw-r--r-- | 1.8 KB |
io.h | -rw-r--r-- | 190 bytes |
linuxvfs.c | -rw-r--r-- | 23.5 KB |
super.c | -rw-r--r-- | 3.0 KB |
super.h | -rw-r--r-- | 134 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...