Revision aeae142d768061fd542809805517f7c87b9ae65b authored by Cody Tapscott on 06 September 2023, 19:02:19 UTC, committed by GitHub on 06 September 2023, 19:02:19 UTC
The unreachable here seems to be caused by the fact that (as of #50943) we re-use a more narrow type from Inference that correctly ignores these edges, but when inserting the `φᶜ` node in `slot2reg` we were including extra edges that never get exercised at runtime. I'm not sure _why_ this causes us to hit an unreachable, since the narrow type from inference is technically still valid (the catch block will never observe these spurious assignments at runtime), but this seems to fix the issue and anyway improves the quality of the IRCode generated by `slot2ssa`. Resolves #51159
| File | Mode | Size |
|---|---|---|
| utils | ||
| error_printing.jl | -rw-r--r-- | 959 bytes |
| invalids.jl | -rw-r--r-- | 473 bytes |
| parse.jl | -rw-r--r-- | 2.7 KB |
| print.jl | -rw-r--r-- | 3.2 KB |
| readme.jl | -rw-r--r-- | 21.0 KB |
| runtests.jl | -rw-r--r-- | 640 bytes |
| toml_test.jl | -rw-r--r-- | 4.3 KB |
| values.jl | -rw-r--r-- | 7.3 KB |
Computing file changes ...
