Revision aed7abbcca7574ed438c3b22e27db9bf249e8de3 authored by Xin Tong on 18 May 2018, 00:49:06 UTC, committed by Facebook Github Bot on 18 May 2018, 00:57:48 UTC
Summary:
Running. TEST_TMPDIR=/dev/shm ./buck-out/gen/rocks/tools/rocks_db_bench --benchmarks=readwhilewriting --num=5000000 -benchmark_write_rate_limit=2000000 --threads=32
Collected esan data and reorder field. Accesses to 4th and 6th fields take majority of the access. Group them. Overall, this struct takes 10%+ of the total accesses in the program. (637773011/6107964986)
==2433831== class rocksdb::InlineSkipList
==2433831== size = 48, count = 637773011, ratio = 112412, array access = 0
==2433831== # 0: offset = 0, size = 2, count = 455137, type = i16
==2433831== # 1: offset = 2, size = 2, count = 6, type = i16
==2433831== # 2: offset = 4, size = 4, count = 182303, type = i32
==2433831== # 3: offset = 8, size = 8, count = 263953900, type = %"class.rocksdb::MemTableRep::KeyComparator"*
==2433831== # 4: offset = 16, size = 8, count = 136409, type = %"class.rocksdb::Allocator"*
==2433831== # 5: offset = 24, size = 8, count = 366628820, type = %"struct.rocksdb::InlineSkipList<const rocksdb::MemTableRep::KeyComparator &>::Node"*
==2433831== # 6: offset = 32, size = 4, count = 6280031, type = %"struct.std::atomic" = type { %"struct.std::__atomic_base" }
==2433831== # 7: offset = 40, size = 8, count = 136405, type = %"struct.rocksdb::InlineSkipList<const rocksdb::MemTableRep::KeyComparator &>::Splice"*
==2433831==EfficiencySanitizer: total struct field access count = 6107964986
Before re-ordering
[trentxintong@devbig460.frc2 ~/fbsource/fbcode]$ fgrep readwhilewriting
without-ro.log
readwhilewriting : 0.036 micros/op 27545605 ops/sec; 26.8 MB/s
(45954 of 5000000 found)
readwhilewriting : 0.036 micros/op 28024240 ops/sec; 27.2 MB/s
(43158 of 5000000 found)
readwhilewriting : 0.037 micros/op 27345145 ops/sec; 27.1 MB/s
(46725 of 5000000 found)
readwhilewriting : 0.037 micros/op 27072588 ops/sec; 27.3 MB/s
(42605 of 5000000 found)
readwhilewriting : 0.034 micros/op 29578781 ops/sec; 28.3 MB/s
(44294 of 5000000 found)
readwhilewriting : 0.035 micros/op 28528304 ops/sec; 27.7 MB/s
(44176 of 5000000 found)
readwhilewriting : 0.037 micros/op 27075497 ops/sec; 26.5 MB/s
(43763 of 5000000 found)
readwhilewriting : 0.036 micros/op 28024117 ops/sec; 27.1 MB/s
(40622 of 5000000 found)
readwhilewriting : 0.037 micros/op 27078709 ops/sec; 27.6 MB/s
(47774 of 5000000 found)
readwhilewriting : 0.034 micros/op 29020689 ops/sec; 28.1 MB/s
(45066 of 5000000 found)
AVERAGE()=27.37 MB/s
After re-ordering
[trentxintong@devbig460.frc2 ~/fbsource/fbcode]$ fgrep readwhilewriting
ro.log
readwhilewriting : 0.036 micros/op 27542409 ops/sec; 27.7 MB/s
(46163 of 5000000 found)
readwhilewriting : 0.036 micros/op 28021148 ops/sec; 28.2 MB/s
(46155 of 5000000 found)
readwhilewriting : 0.036 micros/op 28021035 ops/sec; 27.3 MB/s
(44039 of 5000000 found)
readwhilewriting : 0.036 micros/op 27538659 ops/sec; 27.5 MB/s
(46781 of 5000000 found)
readwhilewriting : 0.036 micros/op 28028604 ops/sec; 27.6 MB/s
(44689 of 5000000 found)
readwhilewriting : 0.036 micros/op 27541452 ops/sec; 27.3 MB/s
(43156 of 5000000 found)
readwhilewriting : 0.034 micros/op 29041338 ops/sec; 28.8 MB/s
(44895 of 5000000 found)
readwhilewriting : 0.036 micros/op 27784974 ops/sec; 26.3 MB/s
(39963 of 5000000 found)
readwhilewriting : 0.036 micros/op 27538892 ops/sec; 28.1 MB/s
(46570 of 5000000 found)
readwhilewriting : 0.038 micros/op 26622473 ops/sec; 27.0 MB/s
(43236 of 5000000 found)
AVERAGE()=27.58 MB/s
Closes https://github.com/facebook/rocksdb/pull/3855
Reviewed By: siying
Differential Revision: D8048781
Pulled By: trentxintong
fbshipit-source-id: bc9807a9845e2a92cb171ce1ecb5a2c8a51f1481
1 parent fa43948
.travis.yml
sudo: false
dist: trusty
language: cpp
os:
- linux
- osx
compiler:
- clang
- gcc
osx_image: xcode8.3
jdk:
- oraclejdk7
cache:
- ccache
- apt
addons:
apt:
packages: ['zlib1g-dev', 'libbz2-dev', 'libsnappy-dev', 'curl', 'libgflags-dev', 'mingw-w64']
env:
- TEST_GROUP=platform_dependent # 16-18 minutes
- TEST_GROUP=1 # 33-35 minutes
- TEST_GROUP=2 # 18-20 minutes
- TEST_GROUP=3 # 20-22 minutes
- TEST_GROUP=4 # 12-14 minutes
# Run java tests
- JOB_NAME=java_test # 4-11 minutes
# Build ROCKSDB_LITE
- JOB_NAME=lite_build # 3-4 minutes
# Build examples
- JOB_NAME=examples # 5-7 minutes
- JOB_NAME=cmake # 3-5 minutes
- JOB_NAME=cmake-mingw # 3 minutes
matrix:
exclude:
- os: osx
env: TEST_GROUP=1
- os: osx
env: TEST_GROUP=2
- os: osx
env: TEST_GROUP=3
- os: osx
env: TEST_GROUP=4
- os : osx
env: JOB_NAME=cmake-mingw
- os : linux
compiler: clang
- os : osx
compiler: gcc
# https://docs.travis-ci.com/user/caching/#ccache-cache
install:
- if [ "${TRAVIS_OS_NAME}" == osx ]; then
brew install ccache;
PATH=$PATH:/usr/local/opt/ccache/libexec;
fi
- if [[ "${JOB_NAME}" == cmake* ]] && [ "${TRAVIS_OS_NAME}" == linux ]; then
mkdir cmake-dist && curl -sfSL https://cmake.org/files/v3.8/cmake-3.8.1-Linux-x86_64.tar.gz | tar --strip-components=1 -C cmake-dist -xz && export PATH=$PWD/cmake-dist/bin:$PATH;
fi
before_script:
# Increase the maximum number of open file descriptors, since some tests use
# more FDs than the default limit.
- ulimit -n 8192
script:
- ${CXX} --version
- if [ `command -v ccache` ]; then ccache -C; fi
- if [ "${TEST_GROUP}" == 'platform_dependent' ]; then OPT=-DTRAVIS V=1 ROCKSDBTESTS_END=db_block_cache_test make -j4 all_but_some_tests check_some; fi
- if [ "${TEST_GROUP}" == '1' ]; then OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=db_block_cache_test ROCKSDBTESTS_END=full_filter_block_test make -j4 check_some; fi
- if [ "${TEST_GROUP}" == '2' ]; then OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=full_filter_block_test ROCKSDBTESTS_END=write_batch_with_index_test make -j4 check_some; fi
- if [ "${TEST_GROUP}" == '3' ]; then OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=write_batch_with_index_test ROCKSDBTESTS_END=write_prepared_transaction_test make -j4 check_some; fi
- if [ "${TEST_GROUP}" == '4' ]; then OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=write_prepared_transaction_test make -j4 check_some; fi
- if [ "${JOB_NAME}" == 'java_test' ]; then OPT=-DTRAVIS V=1 make clean jclean && make rocksdbjava jtest; fi
- if [ "${JOB_NAME}" == 'lite_build' ]; then OPT="-DTRAVIS -DROCKSDB_LITE" V=1 make -j4 static_lib tools; fi
- if [ "${JOB_NAME}" == 'examples' ]; then OPT=-DTRAVIS V=1 make -j4 static_lib; cd examples; make -j4; fi
- if [ "${JOB_NAME}" == 'cmake' ]; then mkdir build && cd build && cmake -DJNI=1 .. && make -j4 rocksdb rocksdbjni; fi
- if [ "${JOB_NAME}" == 'cmake-mingw' ]; then mkdir build && cd build && cmake -DJNI=1 .. -DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc -DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++ -DCMAKE_SYSTEM_NAME=Windows && make -j4 rocksdb rocksdbjni; fi
notifications:
email:
- leveldb@fb.com
webhooks:
- https://buildtimetrend.herokuapp.com/travis
Computing file changes ...
