Skip to main content

Browse the archive

https://github.com/torvalds/linux
29 July 2024, 15:18:00 UTC
Revision af1c0e4e00f3cc76cb136ebf2e2c04e8b6446285 authored by Chan Shu Tak, Alex on 19 December 2019, 06:16:18 UTC, committed by David S. Miller on 21 December 2019, 05:19:36 UTC 
llc2: Fix return statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c)
 
When a frame with NULL DSAP is received, llc_station_rcv is called.
In turn, llc_stat_ev_rx_null_dsap_xid_c is called to check if it is a NULL
XID frame. The return statement of llc_stat_ev_rx_null_dsap_xid_c returns 1
when the incoming frame is not a NULL XID frame and 0 otherwise. Hence, a
NULL XID response is returned unexpectedly, e.g. when the incoming frame is
a NULL TEST command.

To fix the error, simply remove the conditional operator.

A similar error in llc_stat_ev_rx_null_dsap_test_c is also fixed.

Signed-off-by: Chan Shu Tak, Alex <alexchan@task.com.hk>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 90b3b33
History
Tip revision: af1c0e4e00f3cc76cb136ebf2e2c04e8b6446285 authored by Chan Shu Tak, Alex on 19 December 2019, 06:16:18 UTC
llc2: Fix return statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c)
Tip revision: af1c0e4
File Mode Size
Makefile -rw-r--r-- 361 bytes
compat.c -rw-r--r-- 2.2 KB
ipc_sysctl.c -rw-r--r-- 6.1 KB
mq_sysctl.c -rw-r--r-- 2.7 KB
mqueue.c -rw-r--r-- 40.3 KB
msg.c -rw-r--r-- 30.5 KB
msgutil.c -rw-r--r-- 3.6 KB
namespace.c -rw-r--r-- 4.6 KB
sem.c -rw-r--r-- 62.1 KB
shm.c -rw-r--r-- 43.0 KB
syscall.c -rw-r--r-- 5.1 KB
util.c -rw-r--r-- 22.8 KB
util.h -rw-r--r-- 8.7 KB
back to top