Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 August 2024, 15:42:30 UTC
Revision af1c0e4e00f3cc76cb136ebf2e2c04e8b6446285 authored by Chan Shu Tak, Alex on 19 December 2019, 06:16:18 UTC, committed by David S. Miller on 21 December 2019, 05:19:36 UTC 
llc2: Fix return statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c)
 
When a frame with NULL DSAP is received, llc_station_rcv is called.
In turn, llc_stat_ev_rx_null_dsap_xid_c is called to check if it is a NULL
XID frame. The return statement of llc_stat_ev_rx_null_dsap_xid_c returns 1
when the incoming frame is not a NULL XID frame and 0 otherwise. Hence, a
NULL XID response is returned unexpectedly, e.g. when the incoming frame is
a NULL TEST command.

To fix the error, simply remove the conditional operator.

A similar error in llc_stat_ev_rx_null_dsap_test_c is also fixed.

Signed-off-by: Chan Shu Tak, Alex <alexchan@task.com.hk>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 90b3b33
History
Tip revision: af1c0e4e00f3cc76cb136ebf2e2c04e8b6446285 authored by Chan Shu Tak, Alex on 19 December 2019, 06:16:18 UTC
llc2: Fix return statement of llc_stat_ev_rx_null_dsap_xid_c (and _test_c)
Tip revision: af1c0e4
File Mode Size
kvm
lib
Makefile -rw-r--r-- 54 bytes
back to top