Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
b0854e2 Alex Rickabaugh 21 July 2021, 21:31:12 UTC release: cut the v12.1.3 release (#42914) PR Close #42914 21 July 2021, 21:32:51 UTC
29f5097 George Kalpakas 20 July 2021, 09:36:26 UTC fix(docs-infra): fix keyword color in CLI pages code blocks (#42889) Previously, names of CLI commands that also happened to be keywords were shown in black color in the code block demonstrating the command's usage. This worked fine when in light mode (where the code block background is white) but not in the recently introduced dark mode (where the code block background is dark gray). This commit fixes this by ensuring the `.kwd` token color is inherited from its parent (which has an appropriate color for the current theme). Previously, the `.kwd` token was reset to its initial value (which is `black` regardless of the theme). **Before:** ![CLI pages keyword before][1] **After:** ![cli-pages-keyword after][2] [1]: https://user-images.githubusercontent.com/8604205/126073803-af317f0c-d04f-4c3a-9a83-e92541d7dd5a.png [2]: https://user-images.githubusercontent.com/8604205/126073806-1d57e3ed-90b1-4735-ae2a-d0a39862bb95.png PR Close #42889 20 July 2021, 18:56:34 UTC
d207ea0 JoostK 17 July 2021, 20:50:03 UTC fix(compiler-cli): use correct module import for types behind a `forwardRef` (#42887) The static interpreter assumed that a foreign function expression would have to be imported from the absolute module specifier that was used for the foreign function itself. This assumption does not hold for the `forwardRef` foreign function resolver, as that extracts the resolved expression from the function's argument, which is not behind the absolute module import of the `forwardRef` function. The prior behavior has worked for the typical usage of `forwardRef`, when it is contained within the same source file as where the static evaluation started. In that case, the resulting reference would incorrectly have an absolute module guess of `@angular/core`, but the local identifier emit strategy was capable of emitting the reference without generating an import using the absolute module guess. In the scenario where the static interpreter would first have to follow a reference to a different source that contained the `forwardRef` would the compilation fail. In that case, there is no local identifier available such that the absolute module emitter would try to locate the imported symbol from `@angular/core`. which fails as the symbol is not exported from there. This commit fixes the issue by checking whether a foreign expression occurs in the same source file as the call expression. If it does, then the absolute module specifier that was used to resolve the call expression is ignored. Fixes #42865 PR Close #42887 20 July 2021, 18:56:07 UTC
18e2dba Joey Perrott 16 July 2021, 00:06:15 UTC fix(dev-infra): use the version from package.json rather than tags (#42872) Use the version value from the primary package.json file rather than checking the branch for the latest semver tag. This allows for us to explictly create changelogs from the previous version to the new version. PR Close #42872 20 July 2021, 18:30:34 UTC
e31eaf8 Joey Perrott 20 July 2021, 00:04:38 UTC feat(dev-infra): update package version verification to allow for experimental version (#42898) The angular-cli repo publishes experimental versioned packages in addition to standard versioned packages. Both experimental and standard verions, based on the expected new version provided are treated as valid and correct. PR Close #42898 20 July 2021, 18:30:01 UTC
e6b7472 dario-piotrowicz 18 July 2021, 09:32:26 UTC build(docs-infra): improve @usageNotes message (#42888) improve the @usageNotes message by adding the word "is" (outcome: "Further information is available in...", compared to "Further information available in...") PR Close #42888 20 July 2021, 00:37:57 UTC
a6db152 JoostK 17 July 2021, 19:26:12 UTC fix(core): use correct injector when resolving DI tokens from within a directive provider factory (#42886) When a directive provides a DI token using a factory function and interacting with a standalone injector from within that factory, the standalone injector should not have access to either the directive injector nor the NgModule injector; only the standalone injector should be used. This commit ensures that a standalone injector never reaches into the directive-level injection context while resolving DI tokens. Fixes #42651 PR Close #42886 20 July 2021, 00:36:30 UTC
778edfc George Kalpakas 17 July 2021, 16:30:02 UTC fix(docs-infra): prevent main content from overlapping with ToC (#42884) Previously, if there was more content than what would horizontally fit in the main content area, it would overflow to the right and overlap with the Table of Contents (ToC). This was accidentally introduced in #42787. This commit fixes it by ensuring that the main content area will not overlap with ToC and the necessary space for the ToC will be reserved using `margin` (instead of `padding`, which contributes to the element's size). Fixes #42867 PR Close #42884 20 July 2021, 00:35:36 UTC
8989397 George Kalpakas 17 July 2021, 11:41:45 UTC fix(docs-infra): correctly handle reported errors (#42883) Error-handling in AIO happens mainly in two places: 1. For errors happening inside the app we have a custom `ErrorHandler` implementation, `ReportingErrorHandler`. `ReportingErrorHandler` passes errors to the default `ErrorHandler` (for them to be logged to the console) and also forwards them to `window.onerror()`. 2. Errors happening outside the app and errors forwarded by `ReportingErrorHandler` are handled by `window.onerror()`, which in turn reports them to Google analytics. Previously, we were making some assumptions (which turned out to be incorrect based on the info captured in Google analytics - see #28106): - `ReportingErrorHandler` assumed that the errors passed to its `handleError()` method would be either strings or `Error` instances. _Apparently, other values (such as `null` or `undefined`) may also be passed._ - `window.onerror()` assumed that if an `Error` instance was passed in, it would always have a stacktrace (i.e. its `stack` property would be defined). _This is not necessarily true, although it is not clear (based on the logs) whether reported errors of this type are caused by `Error` instance with no stacktrace or by non-string error objects which are incorrectly treated as `Error` instances. This commit ensures that all types of error arguments can be handled correctly, including `Error` instances with no stacktrace and other types of objects or primitives. NOTE: PR #42881 is related as it fixes handling `null` and `undefined` arguments in the default `ErrorHandler`. Fixes #28106 PR Close #42883 20 July 2021, 00:35:03 UTC
aeff926 Paul Gschwendtner 16 July 2021, 18:18:18 UTC feat(dev-infra): add option to setup global types in API golden test (#42876) Previously we disabled automatic type-resolution for the API extractor because in non-sandbox environments this resulted in different API reports. There are cases where global types are still needed for analysis of an entry-point. To support this, we add a new property called `types` which allows for explicit type targets being specified. Note that we do not want to determine types from the `data` runfiles because API extractor itself also brings in types which should not always be part of the API report analysis. PR Close #42876 20 July 2021, 00:33:20 UTC
24cc144 Paul Gschwendtner 16 July 2021, 17:23:09 UTC ci: remove RBE workaround from `components-repo-unit-tests` job (#42875) In the past when we had issues with our RBE instance, we wanted to get CI green as soon as possible, and couldn't wait on the components repo to land their RBE instance fix. We manually fixed the RBE instance name using a CI step using `sed`. This is no longer needed if we update to the most recent state of the components repository. PR Close #42875 20 July 2021, 00:32:44 UTC
6eea132 Paul Gschwendtner 15 July 2021, 19:23:13 UTC build: remove unnecessary husky gitignore file (#42870) We recently updated to Husky v7 through Renovate, but as of Husky v7, a `.gitignore` file is no longer needed. This commit removes the file. PR Close #42870 20 July 2021, 00:31:55 UTC
a47ea85 Paul Gschwendtner 15 July 2021, 18:39:24 UTC ci: exempt bazel scope from merge tool target label checks (#42869) Currently, changes with the `bazel` scope are guarded by the merge tool target label checks. i.e. feature commits with the `bazel` scope cannot land in the patch branch. This is expected for all public packages, but given the `bazel` package being used internal-only, it should be possible to land these in a patch branch. Especially since we want tooling to be in sync between version branches as much as possible. PR Close #42869 20 July 2021, 00:29:02 UTC
9ee4441 Joey Perrott 15 July 2021, 23:35:57 UTC fix(dev-infra): prevent verbose messaging of git checkout and commit for release (#42871) Prevent logging verbose messages to the output for commit and checkout during the release process. PR Close #42871 20 July 2021, 00:15:55 UTC
e7b3b34 Joey Perrott 15 July 2021, 23:28:26 UTC fix(dev-infra): perform actual npm login verification for wombot proxy (#42871) Previously the wombot proxy was not able to be queried for login state, now that it is able to be checked via `npm whoami` a specific alternate flow is no longer needed. PR Close #42871 20 July 2021, 00:15:54 UTC
ca2165e Joey Perrott 15 July 2021, 23:26:26 UTC refactor(dev-infra): provide entire pull request object to waitForPullRequestToBeMerged (#42871) `waitForPullRequestToBeMerged` should get the entire `PullRequest` object rather than just the id to allow it to have more information/context for logging and messaging. PR Close #42871 20 July 2021, 00:15:54 UTC
d845643 Joey Perrott 15 July 2021, 23:22:04 UTC fix(dev-infra): don't pollute standard out during commit message hooks (#42871) When a commit message is not restored, there is not need to log this to stdout. It is a better experience to silently succeed. PR Close #42871 20 July 2021, 00:15:54 UTC
8f109da dario-piotrowicz 17 July 2021, 19:35:35 UTC refactor(animations): remove unused animation trigger imports (#42763) in the animation_trigger.ts file there are unused imports remove them to clean up the file PR Close #42763 20 July 2021, 00:13:46 UTC
6de37b8 dario-piotrowicz 17 July 2021, 12:37:36 UTC refactor(animations): remove publicApi annotations from triggers (#42763) the buildTrigger function and AnimationTrigger class are annotated as publicApi which seems wrong and makes changes to the two problematic, so they are being removed here see: https://github.com/angular/angular/pull/42763/files#r671481902 PR Close #42763 20 July 2021, 00:13:46 UTC
3cddc3d dario-piotrowicz 04 July 2021, 08:57:55 UTC fix(animations): normalize final styles in buildStyles (#42763) the final styles created in buildStyles lack normalization, meaning that pixel values remain as numbers (without "px") and so such properties fail to be correctly set/applied Example: "width: 300" is applies as "width": "300" (and thus ignored) instead of the correct "width": "300px" PR Close #42763 20 July 2021, 00:13:46 UTC
0dfb4e8 dario-piotrowicz 17 July 2021, 09:53:26 UTC refactor(animations): fix typo in transition animations spec file (#42763) fix the typo "mean't" in the transition_animation_engine spec file to "meant" (the typo is simply in a code comment so the change does not have any impact) PR Close #42763 20 July 2021, 00:13:46 UTC
97fa1cf Joey Perrott 14 July 2021, 19:43:39 UTC build: add configuration for caretaker handoff (#42859) Add configuration information about groups for caretaker handoff assistant. PR Close #42859 15 July 2021, 20:34:59 UTC
9d4b580 Joey Perrott 14 July 2021, 19:43:28 UTC feat(dev-infra): create caretaker handoff assistant to update github team membership (#42859) Create a handoff assistant, currently only assists in updating github team membership for caretaking team. PR Close #42859 15 July 2021, 20:34:59 UTC
0ef8b01 Minko Gechev 13 July 2021, 23:01:01 UTC docs: remove reference to an obsolete design doc (#42842) The type checking design document is no longer relevant. This PR removes the reference to it. Close #42424. PR Close #42842 15 July 2021, 20:24:58 UTC
c06cbb2 David Shevitz 13 July 2021, 22:59:06 UTC docs: remove references to future in topic (#42841) Fixes #25704 PR Close #42841 15 July 2021, 20:23:28 UTC
688b1c5 dario-piotrowicz 03 July 2021, 10:42:39 UTC docs(docs-infra): remove unnecessary "Podcast" from happy-angular podcast's title (#42756) PR Close #42756 15 July 2021, 20:22:04 UTC
12ad314 dario-piotrowicz 03 July 2021, 10:41:40 UTC docs(docs-infra): add the angular show to the podcast resources (#42756) PR Close #42756 15 July 2021, 20:22:04 UTC
8b9aea9 dario-piotrowicz 03 July 2021, 10:24:58 UTC docs(docs-infra): podcast keys cleanup in resources.json (#42756) PR Close #42756 15 July 2021, 20:22:04 UTC
1d9d74a dario-piotrowicz 03 July 2021, 09:28:02 UTC docs(docs-infra): remove deep dive from podcast resources (#42756) PR Close #42756 15 July 2021, 20:22:03 UTC
d4567b2 JoostK 28 June 2021, 21:07:41 UTC refactor(core): expand error logging when the JIT compiler is not available (#42693) If a decorator or partial declaration has not been AOT compiled, then the compiler is needed at runtime to be able to JIT compile the code. However, it may occur that the compiler is not available, if it has not been loaded into the application. The error that was reported in this case did not provide insight into which class requested compilation, nor did it differentiate between decorators vs. partial declarations. This commit expands the error logging to provide better insight into the class that initiated JIT compilation and offers a specialized error message for partial declarations. This should help a developer better understand why the error occurs and what can be done to resolve it. Closes #40609 PR Close #42693 15 July 2021, 20:19:05 UTC
e6d520f JoostK 15 March 2021, 22:28:28 UTC perf(compiler-cli): optimize cycle detection using a persistent cache (#41271) For the compilation of a component, the compiler verifies that the imports it needs to generate to reference the used directives and pipes would not create an import cycle in the program. This requires visiting the transitive import graphs of all directive/pipe usage in search of the component file. The observation can be made that all directive/pipe usages can leverage the exploration work in search of the component file, thereby allowing sub-graphs of the import graph to be only visited once instead of repeatedly per usage. Additionally, the transitive imports of a file are no longer collected into a set to reduce memory pressure. PR Close #41271 15 July 2021, 20:13:49 UTC
e6f01d7 Krzysztof Kotowicz 08 July 2021, 11:36:54 UTC revert: docs: remove references to Trusted Types due to incompatibility with Webpack 5 (#42796) Re-add reference to Trusted Types since the issue #41754 is resolved in 12.1.1. This reverts commit 7254fbc2baa1455e3b24400597342843df3017f2. PR Close #42796 14 July 2021, 18:14:08 UTC
fa3e7f8 Alan Agius 14 July 2021, 16:20:54 UTC docs: remove End-to-end test files structure (#42844) Since version 12, the Angular CLI no longer generates end-to-end tests. PR Close #42844 14 July 2021, 18:12:42 UTC
8d184f9 David Shevitz 13 July 2021, 22:53:22 UTC docs: update incorrect bullet text (#42839) Fixes #42286 PR Close #42839 14 July 2021, 18:11:56 UTC
2a61728 Andrew Kushnir 14 July 2021, 17:47:57 UTC release: cut the v12.1.2 release (#42856) 14 July 2021, 17:47:57 UTC
6301354 JoostK 10 July 2021, 21:24:03 UTC fix(core): associate the NgModule scope for an overridden component (#42817) When using `TestBed.overrideComponent`, the overridden component would incorrectly lose access to its NgModule's declaration scope if the NgModule had been imported into the testing NgModule as a `ModuleWithProviders`, e.g. using a `forRoot` call. The issue occurred as the `TestBed` compiler did not consider NgModules that had been imported as a `ModuleWithProviders` when associating NgModules with component overrides. This caused the overridden component to be compiled standalone, meaning that it does not have access to its NgModule's declarations. This commit extends the logic for traversing the NgModule graph to also consider `ModuleWithProviders` imports. Fixes #42734 PR Close #42817 13 July 2021, 22:59:28 UTC
9ebd41e JoostK 28 June 2021, 19:35:03 UTC fix(core): allow proper type inference when `ngFor` is used with a `trackBy` function (#42692) In #41995 the type of `TrackByFunction` was changed such that the declaration of a `trackBy` function did not cause the item type to be widened to the `trackBy`'s item type, which may be a supertype of the iterated type. This has introduced situations where the template type checker is now reporting errors for cases where a `trackBy` function is no longer assignable to `TrackByFunction`. This commit fixes the error by also including the item type `T` in addition to the constrained type parameter `U`, allowing TypeScript to infer an appropriate `T`. Fixes #42609 PR Close #42692 13 July 2021, 21:08:06 UTC
34b2669 David Shevitz 13 July 2021, 17:28:37 UTC docs: update routing-overview topic with link to custom route matches tutorial (#42837) PR Close #42837 13 July 2021, 21:07:16 UTC
d654c79 Meir Blumenfeld 12 July 2021, 16:44:07 UTC fix(common): re-sort output of `KeyValuePipe` when `compareFn` changes (#42821) Previously, if only the `compareFn` changed but the data itself did not, then the `KeyValuePipe` did not re-sort the output. Fixes #42819 PR Close #42821 13 July 2021, 18:33:21 UTC
b101ad0 Mark Goho 01 July 2021, 21:05:48 UTC docs: clarify voting phase for feature requests (#42663) PR Close #42663 12 July 2021, 22:25:46 UTC
75a11d9 Andrew Kushnir 12 July 2021, 21:58:53 UTC Revert "refactor(dev-infra): add spawnSync to child process utils, normalize naming of child-process utils (#42394)" (#42829) This reverts commit 08444c6679e88034f021cc4ce8d1a0dd85ac4e46. PR Close #42829 12 July 2021, 22:24:55 UTC
2cdf074 Andrew Kushnir 12 July 2021, 21:58:35 UTC Revert "refactor(dev-infra): remove usages and dependency on shelljs (#42394)" (#42829) This reverts commit f0d857eff876033359a7c284171775041f75db5d. PR Close #42829 12 July 2021, 22:24:55 UTC
2566cbb Kristiyan Kostadinov 11 July 2021, 08:24:55 UTC fix(compiler): add mappings for all HTML entities (#42818) Angular inserts text either through text nodes (`document.createTextNode`) or using `textContent`, but the drawback of doing so is that HTML entities won't be decoded. In order to work around it, the compiler has some logic that maps the entities to their unicode representation which can safely be inserted. The problem is that our current mapping is arbitrarily limited which means that some entities will be mapped while others will throw an error, even though they're valid. These changes expand the list to cover all entities that are supported by the HTML spec. Fixes #41186. PR Close #42818 12 July 2021, 21:41:21 UTC
afeab76 Joey Perrott 27 May 2021, 19:04:39 UTC refactor(dev-infra): remove usages and dependency on shelljs (#42394) Remove usages of shelljs and instead use spawn/spawnSync. PR Close #42394 12 July 2021, 21:39:08 UTC
bfb738c Joey Perrott 03 June 2021, 17:54:36 UTC refactor(dev-infra): add spawnSync to child process utils, normalize naming of child-process utils (#42394) Create a `spawnSync` command for common usage, additionally update naming to use `spawn` instead of `spawnWithDebugOutput` PR Close #42394 12 July 2021, 21:39:08 UTC
eeef3e7 Paul Gschwendtner 12 July 2021, 19:02:12 UTC fix(dev-infra): transitive targets cannot be resolved by API extractor (#42828) For API golden tests not running against a NPM package, we extract all transitive declarations of the specified `data` targets. This is necessary because API extractor needs to resolve other targets that have been linked by the Bazel NodeJS rules. The linker by default only provides access to JavaScript sources, but the API extractor is specifically concerned with type definitions that we need to manually extract. PR Close #42828 12 July 2021, 21:38:05 UTC
c2e5d76 Paul Gschwendtner 12 July 2021, 18:29:57 UTC fix(dev-infra): do not include all types in api golden test (#42828) The API golden test tool should not include all types from the `node_modules/`. This results in unnecessary type resolution when the API golden tool is run outside of sandbox (i.e. on windows or with `bazel run` for accept). PR Close #42828 12 July 2021, 21:38:05 UTC
d249665 Paul Gschwendtner 10 July 2021, 15:33:54 UTC feat(dev-infra): better caching for browser archive contents (#42814) Adds better caching for browser archives and their extraction. This is done because the archives are currently extracted as a build action and these are actions are invalidated frequently, causing flakiness on the CI and slow-down in local development. Here is an example flaky error on the CI (that surfaces often with RBE execution): ``` ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/npm/@angular/dev-infra-private/bazel/browsers/chromium/BUILD.bazel:22:17: Extracting ../org_chromium_chromium_amd64/file/chrome-linux.zip failed: (Exit 34): extract.sh failed: error executing command external/io_bazel_rules_webtesting/web/internal/extract.sh external/org_chromium_chromium_amd64/file/chrome-linux.zip ... (remaining 2 argument(s) skipped). Note: Remote connection/protocol failed with: execution failed ``` We fix this by introducing a new rule that downloads a browser archive and unpacks it directly into a Bazel repository. Before this change, the archive would just be downloaded but extracted later as part of a build action. This is unnecessary and results in less efficient caching as build actions are invalidated more often, especially if developers run `bazel clean` in between. The root cause on why the extraction often fails in RBE containers is unclear. It's unclear why the extacted archive is not cached properly as part of a build action (most likely some hermeticity issue within `rules_webtesting`, but it seems more Bazel-idiomatic to unpack the archives as part of the repository anyway, and this solves the flakiness issue. PR Close #42814 12 July 2021, 21:37:10 UTC
4f8a728 Pete Bacon Darwin 04 July 2021, 10:23:30 UTC docs: move start tutorial alert for clarity (#42764) The alert was placed in the middle of a set of steps, which was causing some confusion. This has been moved to the above the steps in the section and slightly reworded to make it clearer. Fixes #42752 PR Close #42764 12 July 2021, 20:20:13 UTC
04472d2 Paul Gschwendtner 07 July 2021, 17:58:22 UTC refactor: add override keyword to members implementing abstract declarations (#42512) In combination with the TS `noImplicitOverride` compatibility changes, we also want to follow the best-practice of adding `override` to members which are implemented as part of abstract classes. This commit fixes all instances which will be flagged as part of the custom `no-implicit-override-abstract` TSLint rule. PR Close #42512 12 July 2021, 20:11:20 UTC
8dbae89 Paul Gschwendtner 06 July 2021, 17:41:48 UTC feat(dev-infra): add lint rule to enforce no-implicit-override abstract members (#42512) TypeScript introduced a new flag called `noImplicitOverride` as part of TypeScript v4.3. This flag introduces a new keyword called `override` that can be applied to members which override declarations from a base class. This helps with code health as TS will report an error if e.g. the base class changes the method name but the override would still have the old method name. Similarly, if the base class removes the method completely, TS would complain that the memeber with `override` no longer overrides any method. A similar concept applies to abstract methods, with the exception that TypeScript's builtin `noImplicitOverride` option does not flag members which are implemented as part of an abstract class. We want to enforce this as a best-practice in the repository as adding `override` to such implemented members will cause TS to complain if an abstract member is removed, but still implemented by derived classes. More details: https://github.com/microsoft/TypeScript/issues/44457. PR Close #42512 12 July 2021, 20:11:20 UTC
6e13179 Paul Gschwendtner 07 June 2021, 19:06:06 UTC refactor: ensure compatibility with noImplicitOverride for examples (#42512) Adds the `override` keyword to the `examples` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:20 UTC
1a66199 Paul Gschwendtner 07 June 2021, 19:05:50 UTC refactor(zone.js): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `zone.js` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:20 UTC
9e8a919 Paul Gschwendtner 07 June 2021, 19:05:34 UTC refactor(localize): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `localize` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:20 UTC
367ef56 Paul Gschwendtner 07 June 2021, 19:05:21 UTC refactor(language-service): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `language-service` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:20 UTC
fdc6786 Paul Gschwendtner 07 June 2021, 19:05:03 UTC refactor(service-worker): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `service-worker` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:20 UTC
b9c1604 Paul Gschwendtner 07 June 2021, 19:04:52 UTC refactor(forms): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `forms` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
859eb13 Paul Gschwendtner 07 June 2021, 19:04:39 UTC refactor(elements): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `elements` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
1f84f01 Paul Gschwendtner 07 June 2021, 19:04:22 UTC refactor(common): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `common` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
462c157 Paul Gschwendtner 07 June 2021, 19:04:08 UTC refactor(benchpress): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `benchpress` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
9136640 Paul Gschwendtner 07 June 2021, 19:03:56 UTC refactor(upgrade): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `upgrade` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
b98b0da Paul Gschwendtner 07 June 2021, 19:03:42 UTC refactor(router): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `router` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
dffb7c5 Paul Gschwendtner 07 June 2021, 19:03:01 UTC refactor(platform-server): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `platform-server` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
a926402 Paul Gschwendtner 07 June 2021, 19:02:34 UTC refactor(platform-browser-dynamic): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `platform-browser-dynamic` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
9067d36 Paul Gschwendtner 07 June 2021, 19:02:10 UTC refactor(platform-browser): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `platform-browser` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:19 UTC
dc661eb Paul Gschwendtner 07 June 2021, 19:01:40 UTC refactor(core): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `core` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:18 UTC
c1f9d80 Paul Gschwendtner 07 June 2021, 19:00:45 UTC refactor(animations): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `animations` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:18 UTC
2afaaf0 Paul Gschwendtner 07 June 2021, 19:00:18 UTC refactor(dev-infra): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `dev-infra` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:18 UTC
0c9c8f5 Paul Gschwendtner 07 June 2021, 15:25:45 UTC refactor(compiler-cli): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `compiler-cli` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:18 UTC
cf27076 Paul Gschwendtner 07 June 2021, 15:10:51 UTC refactor(compiler): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `compiler` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:18 UTC
48010b3 Paul Gschwendtner 07 June 2021, 15:09:00 UTC build: enable noImplicitOverride in project (#42512) Enables the `noImplicitOverride` option to improve overall codehealth in the repository. PR Close #42512 12 July 2021, 20:11:18 UTC
91a576d Arthur Ming 23 June 2021, 03:39:35 UTC refactor(core): optimize the implementation about finding context from error in ErrorHandler (#42581) in _findContext method, use conditional operator check whether the params 'error' exists and then us reccursion way to find context in original error if getDebugContext's result does not exist. PR Close #42581 12 July 2021, 19:00:20 UTC
2050d84 Arthur Ming 21 June 2021, 01:48:21 UTC build: update all symbol extractor (#42581) update all symbol extractor by running 'yarn symbol-extractor:update' script PR Close #42581 12 July 2021, 19:00:19 UTC
e1d6124 Arthur Ming 16 June 2021, 08:28:56 UTC refactor(core): optimize the implementation about finding context from error in ErrorHandler (#42581) in _findContext method, use conditional operator check whether the params 'error' exists and then use nullish coalescing operator instead conditional operator when getDebugContext's result does not exist. PR Close #42581 12 July 2021, 19:00:19 UTC
65330f0 Kristiyan Kostadinov 03 July 2021, 09:59:58 UTC fix(compiler): incorrect context object being referenced from listener instructions inside embedded views (#42755) Currently unless a listener inside of an embedded view tries to reference something from the parent view, or if the reference is a local ref, we don't generate the view restoration instructions and we allow for the value to be picked up from the context object in the function parameters. The problem is that the listener is only run during creation mode and the context object may have been swapped out afterwards. These changes fix the issue by always generating the view restoration instructions for listeners inside templates. Fixes #42698. PR Close #42755 12 July 2021, 18:58:19 UTC
17d3de2 JoostK 03 July 2021, 22:59:46 UTC fix(compiler-cli): properly emit literal types when recreating type parameters in a different file (#42761) In #42492 the template type checker became capable of replicating a wider range of generic type parameters for use in template type-check files. Any literal types within a type parameter would however emit invalid code, as TypeScript was emitting the literals using the text as extracted from the template type-check file instead of the original source file where the type node was taken from. This commit works around the issue by cloning any literal types and marking them as synthetic, signalling to TypeScript that the literal text has to be extracted from the node itself instead from the source file. This commit also excludes `import()` type nodes from being supported, as their module specifier may potentially need to be rewritten. Fixes #42667 PR Close #42761 12 July 2021, 18:48:34 UTC
2ed5a2d behrooz bozorg chami 10 July 2021, 20:06:22 UTC docs(core): fix `ViewChildren` code examples to avoid TS error (#42816) Add a non-null assertion (`!`) in `ViewChildren` code examples to avoid a TypeScript error due to uninitialized property. Fixes #42811 PR Close #42816 12 July 2021, 16:48:30 UTC
7dad7df Paul Gschwendtner 06 July 2021, 13:45:55 UTC build: update to rules_nodejs v4.0.0-beta.0 (#42813) Updates the Bazel NodeJS rules to v4.0.0-beta.0. This is necessary so that the Angular components repo can update, and it's generally good to stay as up-to-date as possible with the Bazel rules as it's easy to fall behind, and updating early allows us to discover issues affecting our tooling earlier (where they are easier to address due to e.g. potential breaking change policy). PR Close #42813 12 July 2021, 16:46:34 UTC
88b2ff2 Paul Gschwendtner 06 July 2021, 13:42:32 UTC refactor(bazel): compatibility with `rules_nodejs` v4.0.0 (#42813) This commit applies changes to `@angular/bazel` which are necessary to support the Bazel NodeJS rules v4.0.0. The Bazel NodeJS rules no longer support the `_tslibrary` option for the `LinkablePackageInfo` provider and therefore we need to stop using it. Due to this removal, we also need to add two new attributes called `package_name` and `package_path` so that the API of `ng_module` matches `ts_library`. Note: This is denoted as `refactor` as we currently are not able to merge feature commits into patch branches, but we want the tooling to not diverge significantly between the patch and next branch. It is planned to update the merge tooling to allow for such changes to land. PR Close #42813 12 July 2021, 16:46:34 UTC
7b5405b Paul Gschwendtner 06 July 2021, 13:39:58 UTC build: remove `skydoc` and `rules_sass` from repository (#42813) Skydoc is no longer used as `@angular/bazel` is no longer a public API. The Sass rules were only used in a single place in the repo where Sass is not really needed and has just been added by accident most likely. We want to remove the Sass dependency in preparation for Rules NodeJS v4.x where the Sass rules currently still use an older version of `@bazel/worker` that is incompatible. PR Close #42813 12 July 2021, 16:46:34 UTC
d8d7784 Paul Gschwendtner 06 July 2021, 13:31:08 UTC build: remove outdated note when updating bazel version (#42813) We removed `bazel-toolchains` from the repository since dev-infra provides the RBE platforms now (in a way where they are not reliant on the Bazel version), so the comment in `.bazelversion` can be removed. PR Close #42813 12 July 2021, 16:46:34 UTC
f6957b2 Paul Gschwendtner 06 July 2021, 13:29:19 UTC fix(dev-infra): `ng_rollup_bundle` rule should error if import cannot be resolved (#42813) Rollup just prints a warning if an import cannot be resolved and ends up being treated as an external dependency. This in combination with the `silent = True` attribute for `rollup_bundle` means that bundles might end up being extremely small without people noticing that it misses actual imports. To improve this situation, the warning is replaced by an error if an import cannot be resolved. This unveiles an issue with the `ng_rollup_bundle` macro from dev-infra where imports in View Engine were not resolved but ended up being treated as external. This did not prevent benchmarks using this macro from working because the ConcatJS devserver had builtin resolution for workspace manifest paths. Though given the new check for no unresolved imports, this will now cause errors within Rollup, and we need to fix the resolution. We can fix the issue by temporarily enabling workspace linking. This does not have any performance downsides. To enable workspace linking (which we might need more often in the future given the linker taking over patched module resolution), we had to rename the `angular` dependency to a more specific one so that the Angular linker could link into `node_modules/angular`. PR Close #42813 12 July 2021, 16:46:34 UTC
8267d25 Paul Gschwendtner 09 July 2021, 18:26:19 UTC build: no longer ship ecmascript module files within NPM packages (#42809) We accidentally started shipping `.mjs` files for the following modules (or module paths) as of the v12.1.0-next.2 tag: - `@angular/compiler-cli` - `@angular/common/locales` - `@angular/bazel` - `@angular/benchpress` - `@angular/core/schematics` - `@angular/elements/schematics` - `@angular/language-service` - `@angular/localize/schematics`, - `@angular/localize/tools` - `zone.js` This did not cause any issues for consumers but we want to not ship these files without having them wired up in `package.json` files. We accidentally started shipping these `.mjs` files due to a NodeJS update which wired up the other JavaScript module output flavors in the `pkg_npm` rule. https://github.com/bazelbuild/rules_nodejs/commit/911529fd364eb3ee1b8ecdc568a9fcf38a8b55ca PR Close #42809 12 July 2021, 16:42:02 UTC
71f4286 Paul Gschwendtner 09 July 2021, 18:22:50 UTC feat(dev-infra): add bazel rule for extracting JavaScript module flavors from targets (#42809) Introduces a rule that collects declared JavaScript module output files from a list of dependencies based on a configurable JavaScript module provider. The extracted outputs are exposed within the `DefaultInfo` provider. Targets defined using this rule can be used as input for rules that require JavaScript sources, or if there are multiple JavaScript output variants defined for a target while for example only the `JSModuleInfo` outputs are of interest. As an example: This rule is helpful in combination with `ts_library` and `ng_module` as those rule expose multiple output flavors (which are distinguishable by the JavaScript module providers as imported from `providers.bzl`). i.e. these rules expose flavors for named AMD modules and ECMAScript module output. If we want to ship a NPM package only using ECMAScript modules for example, we could extract all `JSEcmaScriptModuleInfo`-denoted output and feed that into the `pkg_npm` rule, compared to bringing in all output flavors. For reference: https://github.com/bazelbuild/rules_nodejs/blob/stable/packages/typescript/internal/build_defs.bzl#L334-L337 PR Close #42809 12 July 2021, 16:42:01 UTC
12a9d21 dario-piotrowicz 29 June 2021, 21:15:51 UTC docs(core): edit and add docs for ng-template (#42704) PR Close #42704 12 July 2021, 16:39:30 UTC
1c31828 Andrew Scott 02 July 2021, 19:38:04 UTC refactor(router): Adjust behavior for computed navigation restoration (#42751) When another navigation is triggered during an in-process navigation and the `canceledNavigationResolution` is `'computed'`, we should not attempt to restore the browser history using `history.go`. Doing that would trigger a third navigation through the router which would conflict with the new navigation that we were trying to process. Instead, we treat this as a redirect and skip the history restoration attempt. This acts similarly to returning `UrlTree` from a guard. Fixes issue described in https://github.com/angular/angular/pull/38884#issuecomment-863767152 PR Close #42751 09 July 2021, 17:19:10 UTC
51fd5e3 George Kalpakas 07 July 2021, 15:37:25 UTC fix(docs-infra): fix margin of social icon on small screens (#42790) This commit fixes the margin of the social icons on small screens. This mainly affects screens between 420px and 480px, where only one social icon is show (due to limited space) but not necessarily the first one (in DOM order). **Before:** ![social icon before][1] **After:** ![social icon after][2] [1]: https://user-images.githubusercontent.com/8604205/124788616-2f5f0200-df52-11eb-9ec2-9e46b90cd286.png [2]: https://user-images.githubusercontent.com/8604205/124788623-2ff79880-df52-11eb-90ec-31b04973de68.png PR Close #42790 09 July 2021, 17:15:28 UTC
723342a Bastian 05 July 2021, 10:32:20 UTC docs: fix http example to show actual message in console (#42773) Previously, the error message in the console would print `[object Object]` and not the actual error message. With this change, the error message is printed in the console. PR Close #42773 09 July 2021, 17:14:35 UTC
a8d5a31 Gabriele Franchitto 02 July 2021, 08:13:03 UTC docs(core): initializeApp method should return function (#42743) Update packages/core/src/application_init.ts Update application_init.ts Update application_init.ts Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com> PR Close #42743 08 July 2021, 21:50:18 UTC
9ceadb0 Borislav Ivanov 07 July 2021, 06:42:25 UTC docs(core): fix spelling error (#42783) Fix spelling error in migration schematics. PR Close #42783 08 July 2021, 21:49:47 UTC
f6bce31 Joey Perrott 05 May 2021, 16:56:55 UTC ci: use issue forms for issue creation (#42099) Use new issue forms from Github for creating issues. PR Close #42099 08 July 2021, 21:07:31 UTC
ca4df9c mgechev 07 July 2021, 19:15:51 UTC ci: update the feature request bot (#42791) Introduce latest fixes in logging and labeling. PR Close #42791 08 July 2021, 21:06:10 UTC
d879175 George Kalpakas 08 July 2021, 13:25:16 UTC fix(service-worker): correctly handle unrecoverable state when a client no longer exists (#42736) Previously, the ServiceWorker assumed that a client found in `clientVersionMap` would exist (i.e. it could be retrieved via `clients.get()`). However, if a browser tab had been closed, the corresponding client (while present in `clientVersionMap`, which is only updated on ServiceWorker initialization) would not be retrievable via `clients.get()`. This commit fixes it by checking whether the client exists before trying to notify it about an unrecoverable state. PR Close #42736 08 July 2021, 17:28:23 UTC
c7a2d76 George Kalpakas 08 July 2021, 13:25:16 UTC refactor(service-worker): switch to the official TypeScript typings (#42736) Previously, we used custom typings for the ServiceWorker environment. This was necessary back when the ServiceWorker package was introduced, since there were no official typings. Since there are now official typings for Web Workers (including ServiceWorkers) offered by TypeScript as [lib.webworker.d.ts][1], this commit gets rid of our custom typings in favor of using the official ones. [1]: https://github.com/microsoft/TypeScript/blob/v4.3.4/lib/lib.webworker.d.ts PR Close #42736 08 July 2021, 17:28:23 UTC
7b7dce3 George Kalpakas 08 July 2021, 13:25:16 UTC test(service-worker): better align mock global scope implementation with actual implementation (#42736) This commit better aligns the mock `ServiceWorkerGlobalScope` implementation used in ServiceWorker tests (and the associated typings) with the actual implementation (and the official TypeScript typings). This allows verifying the ServiceWorker behavior in a slightly more realistic environment. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:23 UTC
1670798 George Kalpakas 08 July 2021, 13:25:16 UTC test(service-worker): better align mock client implementations with actual implementations (#42736) This commit better aligns the mock client implementations used in ServiceWorker tests (and the associated typings) with the actual implementations (and the official TypeScript typings). This allows verifying the ServiceWorker behavior in a slightly more realistic environment. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:23 UTC
305042a George Kalpakas 08 July 2021, 13:25:15 UTC refactor(service-worker): move mock client classes to their own file (#42736) In the ServiceWorker tests, we use mock implementations of the various client APIs that the ServiceWorker interacts with. Previously, these mock implementations were defined in the `testing/scope.ts` file. This added several extra classes to a file that already contains a few, making it harder to maintain. Therefore, this commit moves these mock client classes to a separate `testing/clients.ts` file. PR Close #42736 08 July 2021, 17:28:23 UTC
8493eb7 George Kalpakas 08 July 2021, 13:25:15 UTC test(service-worker): better align mock event implementations with actual implementations (#42736) This commit better aligns the mock event implementations used in ServiceWorker tests (and the associated typings) with the actual implementations (and the official TypeScript typings). This allows verifying the ServiceWorker behavior in a slightly more realistic environment. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:23 UTC
7fe7836 George Kalpakas 08 July 2021, 13:25:15 UTC refactor(service-worker): move mock event classes to their own file (#42736) In the ServiceWorker tests, we use mock implementations of the various events emitted during the ServiceWorker lifecycle. Previously, these mock implementations were defined in the `testing/scope.ts` file. This added several extra classes to a file that already contains a few, making it harder to maintain. Therefore, this commit moves these mock event classes to a separate `testing/events.ts` file. PR Close #42736 08 July 2021, 17:28:23 UTC
6010408 George Kalpakas 08 July 2021, 13:25:15 UTC refactor(service-worker): make `SwTestHarness.envIsSupported()` a standalone function (#42736) This commit makes the `SwTestHarness.envIsSupported()` static method a standalone function. This function is used to determine whether the current environment provides the necessary APIs to run the SW tests and is independent of `SwTestHarness`, so is no need for it to be a static method of `SwTestHarness`. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:23 UTC
back to top