Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision b2f49033d80c952a0ffc2d5647bc1a0b8a09c1b3 authored by Peter Staubach on 17 February 2006, 21:52:36 UTC, committed by Linus Torvalds on 17 February 2006, 21:59:26 UTC 
[PATCH] fix deadlock in ext2
 
Fix a deadlock possible in the ext2 file system implementation.  This
deadlock occurs when a file is removed from an ext2 file system which was
mounted with the "sync" mount option.

The problem is that ext2_xattr_delete_inode() was invoking the routine,
sync_dirty_buffer(), using a buffer head which was previously locked via
lock_buffer().  The first thing that sync_dirty_buffer() does is to lock
the buffer head that it was passed.  It does this via lock_buffer().  Oops.

The solution is to unlock the buffer head in ext2_xattr_delete_inode()
before invoking sync_dirty_buffer().  This makes the code in
ext2_xattr_delete_inode() obey the same locking rules as all other callers
of sync_dirty_buffer() in the ext2 file system implementation.

Signed-off-by: Peter Staubach <staubach@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 614f8f5
History
Tip revision: b2f49033d80c952a0ffc2d5647bc1a0b8a09c1b3 authored by Peter Staubach on 17 February 2006, 21:52:36 UTC
[PATCH] fix deadlock in ext2
Tip revision: b2f4903
File Mode Size
cn_test.c -rw-r--r-- 4.3 KB
connector.txt -rw-r--r-- 6.3 KB
back to top