https://github.com/voldemort/voldemort
Revision b3becf3232d4a4fefdd7a8fe3e7f86b8e401baf6 authored by Arunachalam Thirupathi on 23 March 2015, 18:43:01 UTC, committed by Arunachalam Thirupathi on 16 April 2015, 00:00:40 UTC
Separated both Admin and Client Request Handler.
Currently the client port will answer admin requests and the admin
port will answer client requests. You can bootstrap from one of these
ports and client after bootstrapping sends the queries to the correct
ports.

This is dangerous as most of the security implementations of voldemort
relies on blocking the admin port via firewall and an attacker can
change the voldemort source code to send the admin requests to client
port.

My intention for the fix was to make sure that the client answers only
client requests. This will help me
to make the client request handler share the read and write buffer
without touching the admin request handler. Though it can be done for
both client and admin, admin requests are too few and there are too many
places to touch. So will fix only the client request handler.

The AdminClient expects both the client and admin request handler. The
admin client does some get remote metadata calls which uses the
voldemort native v1 requests on admin port. So leaving the admin request
handler unchanged, just moved some code so that client request handlers
are isolated.
1 parent 4a87d69
Raw File
Tip revision: b3becf3232d4a4fefdd7a8fe3e7f86b8e401baf6 authored by Arunachalam Thirupathi on 23 March 2015, 18:43:01 UTC
Separate Client and Admin Request Handler
Tip revision: b3becf3
tomcat-tasks.properties
deploy=org.apache.catalina.ant.DeployTask
install=org.apache.catalina.ant.InstallTask
list=org.apache.catalina.ant.ListTask
reload=org.apache.catalina.ant.ReloadTask
remove=org.apache.catalina.ant.RemoveTask
resources=org.apache.catalina.ant.ResourcesTask
roles=org.apache.catalina.ant.RolesTask
start=org.apache.catalina.ant.StartTask
stop=org.apache.catalina.ant.StopTask
undeploy=org.apache.catalina.ant.UndeployTask
back to top