Revision - b40f1e5 - refactor(compiler): Remove deep imports in the language service [...] - origin: https://github.com/angular/angular

visit type:

https://github.com/angular/angular

19 April 2024, 08:24:33 UTC

Revision b40f1e5b86bb9fb7413be504e9c6a6f80f60460f authored by Dylan Hunn on 04 March 2024, 20:17:24 UTC, committed by Pawel Kozlowski on 05 March 2024, 09:28:45 UTC

refactor(compiler): Remove deep imports in the language service (#54695)

Previously, the language service relied on deep imports such as `@angular/compiler/render3/...`. This is bad form, because that creates a dependency on the package's internal structure. Additionally, this is not compatible with google3.

In this PR, I replace all the deep imports with shallow imports, in some cases adding the missing symbol to the `compiler.ts` exports.

PR Close #54695

1 parent 33a6fab

Files
Changes

Permalinks

Tip revision: b40f1e5b86bb9fb7413be504e9c6a6f80f60460f authored by Dylan Hunn on 04 March 2024, 20:17:24 UTC
refactor(compiler): Remove deep imports in the language service (#54695)

Tip revision: b40f1e5

File	Mode	Size
.circleci
.devcontainer
.github
.husky
.ng-dev
.vscode
.yarn
adev
aio
devtools
docs
goldens
integration
modules
packages
scripts
third_party
tools
.bazelignore	-rw-r--r--	1.6 KB
.bazelrc	-rw-r--r--	7.8 KB
.bazelversion	-rw-r--r--	6 bytes
.clang-format	-rw-r--r--	73 bytes
.editorconfig	-rw-r--r--	245 bytes
.gitattributes	-rw-r--r--	146 bytes
.gitignore	-rw-r--r--	1004 bytes
.gitmessage	-rw-r--r--	7.2 KB
.mailmap	-rw-r--r--	51 bytes
.npmrc	-rw-r--r--	21 bytes
.nvmrc	-rw-r--r--	8 bytes
.prettierrc	-rw-r--r--	196 bytes
.pullapprove.yml	-rw-r--r--	51.8 KB
.yarnrc	-rw-r--r--	130 bytes
BUILD.bazel	-rw-r--r--	2.5 KB
CHANGELOG.md	-rw-r--r--	278.9 KB
CHANGELOG_ARCHIVE.md	-rw-r--r--	997.0 KB
CODE_OF_CONDUCT.md	-rw-r--r--	3.6 KB
CONTRIBUTING.md	-rw-r--r--	15.7 KB
LICENSE	-rw-r--r--	1.1 KB
README.md	-rw-r--r--	5.5 KB
SECURITY.md	-rw-r--r--	403 bytes
WORKSPACE	-rw-r--r--	10.1 KB
browser-providers.conf.d.ts	-rw-r--r--	387 bytes
browser-providers.conf.js	-rw-r--r--	1.9 KB
gulpfile.js	-rw-r--r--	572 bytes
karma-js.conf.js	-rw-r--r--	6.0 KB
package.json	-rw-r--r--	10.0 KB
packages.bzl	-rw-r--r--	3.8 KB
renovate.json	-rw-r--r--	3.0 KB
tsconfig-tslint.json	-rw-r--r--	171 bytes
tslint.json	-rw-r--r--	5.3 KB
yarn.bzl	-rw-r--r--	77 bytes
yarn.lock	-rw-r--r--	805.1 KB
yarn.lock.readme.md	-rw-r--r--	1.3 KB

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/angular/angular

refactor(compiler): Remove deep imports in the language service (#54695)

README.md