Skip to main content

Browse the archive

https://github.com/web-platform-tests/wpt
26 December 2018, 22:31:15 UTC
Revision b55e29597d92ab89063673f031151e2bdb4b9479 authored by Joe Downing on 22 March 2018, 07:35:35 UTC, committed by Chromium WPT Sync on 22 March 2018, 07:35:35 UTC 
Move KeyboardLock API methods to a 'keyboard' object
 
This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object.  We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.

KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API

Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();

New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();

Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.

BUG=680809

Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544996}
1 parent 1a8c195
History
Tip revision: b55e29597d92ab89063673f031151e2bdb4b9479 authored by Joe Downing on 22 March 2018, 07:35:35 UTC
Move KeyboardLock API methods to a 'keyboard' object
Tip revision: b55e295
File Mode Size
resources
OWNERS -rw-r--r-- 44 bytes
body-basic-manual.html -rw-r--r-- 981 bytes
body-empty-manual.html -rw-r--r-- 1.2 KB
common.js -rw-r--r-- 1.5 KB
constructor-basic.html -rw-r--r-- 824 bytes
constructor-invalid.html -rw-r--r-- 718 bytes
event-onclick-manual.html -rw-r--r-- 870 bytes
event-onclose.html -rw-r--r-- 1019 bytes
event-onerror-default-manual.html -rw-r--r-- 1.0 KB
event-onerror-denied-manual.html -rw-r--r-- 970 bytes
event-onshow.html -rw-r--r-- 1014 bytes
icon-basic-manual.html -rw-r--r-- 1006 bytes
icon-empty-manual.html -rw-r--r-- 939 bytes
instance.html -rw-r--r-- 2.0 KB
interfaces.html -rw-r--r-- 3.1 KB
lang.html -rw-r--r-- 2.3 KB
permission.html -rw-r--r-- 535 bytes
requestPermission-denied-manual.html -rw-r--r-- 773 bytes
requestPermission-granted-manual.html -rw-r--r-- 566 bytes
shownotification-resolve-manual.https.html -rw-r--r-- 1.7 KB
tag-different-manual.html -rw-r--r-- 1.4 KB
tag-same-manual.html -rw-r--r-- 1.4 KB
back to top