Skip to main content

Browse the archive

Revision b55e29597d92ab89063673f031151e2bdb4b9479 authored by Joe Downing on 22 March 2018, 07:35:35 UTC, committed by Chromium WPT Sync on 22 March 2018, 07:35:35 UTC 
Move KeyboardLock API methods to a 'keyboard' object
 
This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object.  We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.

KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API

Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();

New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();

Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.

BUG=680809

Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544996}
1 parent 1a8c195
Raw File
idlharness.https.html 
<!DOCTYPE html>
<meta charset="utf-8">
<title>Presentation API IDL tests for Controlling User Agent</title>
<link rel="author" title="Louay Bassbouss" href="http://www.fokus.fraunhofer.de">
<link rel="help" href="http://w3c.github.io/presentation-api/#dfn-controlling-user-agent">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/WebIDLParser.js"></script>
<script src="/resources/idlharness.js"></script>

<script id="untested_idl" type="text/plain">
interface Navigator {
};
interface EventTarget {
};
interface EventHandler {
};
interface Event {
};
dictionary EventInit {
};
</script>

<script id='idl' type="text/plain">
partial interface Navigator {
    [SecureContext,
     SameObject]
    readonly attribute Presentation presentation;
};

[SecureContext,
 Exposed=Window]
interface Presentation {
};

partial interface Presentation {
    attribute PresentationRequest? defaultRequest;
};

[Constructor(USVString url),
 Constructor(sequence<USVString> urls),
 SecureContext,
 Exposed=Window]
interface PresentationRequest : EventTarget {
    Promise<PresentationConnection>   start();
    Promise<PresentationConnection>   reconnect(USVString presentationId);
    Promise<PresentationAvailability> getAvailability();

    attribute EventHandler onconnectionavailable;
};

[SecureContext,
 Exposed=Window]
interface PresentationAvailability : EventTarget {
    readonly attribute boolean      value;
             attribute EventHandler onchange;
};

[Constructor(DOMString type, PresentationConnectionAvailableEventInit eventInitDict),
 SecureContext,
 Exposed=Window]
interface PresentationConnectionAvailableEvent : Event {
    [SameObject]
    readonly attribute PresentationConnection connection;
};

dictionary PresentationConnectionAvailableEventInit : EventInit {
    required PresentationConnection connection;
};

enum PresentationConnectionState {
    "connecting",
    "connected",
    "closed",
    "terminated"
};

enum BinaryType {
    "blob",
    "arraybuffer"
};

[SecureContext,
 Exposed=Window]
interface PresentationConnection : EventTarget {
    readonly attribute USVString                   id;
    readonly attribute USVString                   url;
    readonly attribute PresentationConnectionState state;
    void close();
    void terminate();
             attribute EventHandler                onconnect;
             attribute EventHandler                onclose;
             attribute EventHandler                onterminate;

    // Communication
             attribute BinaryType                  binaryType;
             attribute EventHandler                onmessage;
    void send(DOMString message);
    void send(Blob data);
    void send(ArrayBuffer data);
    void send(ArrayBufferView data);
};

enum PresentationConnectionCloseReason {
    "error",
    "closed",
    "wentaway"
};

[Constructor(DOMString type, PresentationConnectionCloseEventInit eventInitDict),
 SecureContext,
 Exposed=Window]
interface PresentationConnectionCloseEvent : Event {
    readonly attribute PresentationConnectionCloseReason reason;
    readonly attribute DOMString                         message;
};

dictionary PresentationConnectionCloseEventInit : EventInit {
    required PresentationConnectionCloseReason reason;
             DOMString                         message = "";
};
</script>

<script>
    (function() {
        "use strict";
        var idl_array = new IdlArray();
        var idls = document.getElementById('idl').textContent;
        idl_array.add_untested_idls(document.getElementById('untested_idl').textContent);
        idl_array.add_idls(idls);
        window.presentation_request = new PresentationRequest("/presentation-api/receiving-ua/idlharness.html");
        window.presentation_request_urls = new PresentationRequest(["/presentation-api/receiving-ua/idlharness.html",
            "https://www.example.com/presentation.html"]);
        navigator.presentation.defaultRequest = presentation_request;
        idl_array.add_objects({
            Presentation: ['navigator.presentation'],
            PresentationRequest: ['navigator.presentation.defaultRequest', 'presentation_request', 'presentation_request_urls']
        });
        idl_array.test();
    })();
</script>
back to top