Revision b55e29597d92ab89063673f031151e2bdb4b9479 authored by Joe Downing on 22 March 2018, 07:35:35 UTC, committed by Chromium WPT Sync on 22 March 2018, 07:35:35 UTC
This change moves the KeyboardLock API methods to a 'keyboard' namespace on the Navigator object. We are doing this work now as there has been a request for additional keyboard functionality that would also be placed on the new keyboard object and we wanted to move the KeyboardLock methods there for consistency before we launch. KeyboardLock API Spec is here: https://w3c.github.io/keyboard-lock/#API Old calling pattern: Navigator.keyboardLock(); Navigator.keyboardUnlock(); New calling pattern: Navigator.keyboard.lock(); Navigator.keyboard.unlock(); Note: The main logic in the KeyboardLock.cpp class and tests is the same as it was, however the file changed enough that git does not recognize it as a file move. BUG=680809 Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4 Reviewed-on: https://chromium-review.googlesource.com/969656 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544996}
1 parent 1a8c195
RTCConfiguration-helper.js
'use strict';
// Run a test function as two test cases.
// The first test case test the configuration by passing a given config
// to the constructor.
// The second test case create an RTCPeerConnection object with default
// configuration, then call setConfiguration with the provided config.
// The test function is given a constructor function to create
// a new instance of RTCPeerConnection with given config,
// either directly as constructor parameter or through setConfiguration.
function config_test(test_func, desc) {
test(() => {
test_func(config => new RTCPeerConnection(config));
}, `new RTCPeerConnection(config) - ${desc}`);
test(() => {
test_func(config => {
const pc = new RTCPeerConnection();
assert_idl_attribute(pc, 'setConfiguration');
pc.setConfiguration(config);
return pc;
})
}, `setConfiguration(config) - ${desc}`);
}
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...