Revision b55e29597d92ab89063673f031151e2bdb4b9479 authored by Joe Downing on 22 March 2018, 07:35:35 UTC, committed by Chromium WPT Sync on 22 March 2018, 07:35:35 UTC
This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object. We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.
KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API
Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();
New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();
Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.
BUG=680809
Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544996}
1 parent 1a8c195
RTCPeerConnection-generateCertificate.html
<!doctype html>
<meta charset="utf-8">
<title>Test RTCPeerConnection.generateCertificate</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170515/webrtc.html
/*
* 4.10. Certificate Management
* partial interface RTCPeerConnection {
* static Promise<RTCCertificate> generateCertificate(
* AlgorithmIdentifier keygenAlgorithm);
* };
*
* 4.10.2. RTCCertificate Interface
* interface RTCCertificate {
* readonly attribute DOMTimeStamp expires;
* ...
* };
*
* [WebCrypto]
* 11. Algorithm Dictionary
* typedef (object or DOMString) AlgorithmIdentifier;
*/
/*
* 4.10. The following values must be supported by a user agent:
* { name: "RSASSA-PKCS1-v1_5", modulusLength: 2048,
* publicExponent: new Uint8Array([1, 0, 1]), hash: "SHA-256" },
* and { name: "ECDSA", namedCurve: "P-256" }.
*/
promise_test(t =>
RTCPeerConnection.generateCertificate({
name: 'RSASSA-PKCS1-v1_5',
modulusLength: 2048,
publicExponent: new Uint8Array([1, 0, 1]),
hash: 'SHA-256'
}).then(cert => {
assert_true(cert instanceof RTCCertificate,
'Expect cert to be instance of RTCCertificate');
assert_greater_than(cert.expires, Date.now(),
'Expect generated certificate to expire reasonably long after current time');
}),
'generateCertificate() with compulsary RSASSA-PKCS1-v1_5 parameters should succeed');
promise_test(t =>
RTCPeerConnection.generateCertificate({
name: 'ECDSA',
namedCurve: 'P-256'
}).then(cert => {
assert_true(cert instanceof RTCCertificate,
'Expect cert to be instance of RTCCertificate');
assert_greater_than(cert.expires, Date.now(),
'Expect generated certificate to expire reasonably long after current time');
}),
'generateCertificate() with compulsary ECDSA parameters should succeed');
/*
* 4.10. A user agent must reject a call to generateCertificate() with a
* DOMException of type NotSupportedError if the keygenAlgorithm
* parameter identifies an algorithm that the user agent cannot or
* will not use to generate a certificate for RTCPeerConnection.
*/
promise_test(t =>
promise_rejects(t, 'NotSupportedError',
RTCPeerConnection.generateCertificate('invalid-algo')),
'generateCertificate() with invalid string algorithm should reject with NotSupportedError');
promise_test(t =>
promise_rejects(t, 'NotSupportedError',
RTCPeerConnection.generateCertificate({
name: 'invalid-algo'
})),
'generateCertificate() with invalid algorithm dict should reject with NotSupportedError');
/*
* 4.10.1. Dictionary RTCCertificateExpiration
* dictionary RTCCertificateExpiration {
* [EnforceRange]
* DOMTimeStamp expires;
* };
*
* If this parameter is present it indicates the maximum time that
* the RTCCertificate is valid for relative to the current time.
*
* When generateCertificate is called with an object argument,
* the user agent attempts to convert the object into a
* RTCCertificateExpiration. If this is unsuccessful, immediately
* return a promise that is rejected with a newly created TypeError
* and abort processing.
*/
promise_test(t => {
const start = Date.now();
return RTCPeerConnection.generateCertificate({
name: 'ECDSA',
namedCurve: 'P-256',
expires: 2000
}).then(cert => {
assert_approx_equals(cert.expires, start+2000, 1000);
})
}, 'generateCertificate() with valid expires parameter should succeed');
promise_test(t => {
return RTCPeerConnection.generateCertificate({
name: 'ECDSA',
namedCurve: 'P-256',
expires: 0
}).then(cert => {
assert_less_than_equal(cert.expires, Date.now());
})
}, 'generateCertificate() with 0 expires parameter should generate expired cert');
promise_test(t => {
return promise_rejects(t, new TypeError(),
RTCPeerConnection.generateCertificate({
name: 'ECDSA',
namedCurve: 'P-256',
expires: -1
}))
}, 'generateCertificate() with invalid range for expires should reject with TypeError');
promise_test(t => {
return promise_rejects(t, new TypeError(),
RTCPeerConnection.generateCertificate({
name: 'ECDSA',
namedCurve: 'P-256',
expires: 'invalid'
}))
}, 'generateCertificate() with invalid type for expires should reject with TypeError');
</script>
Computing file changes ...
