Revision b55e29597d92ab89063673f031151e2bdb4b9479 authored by Joe Downing on 22 March 2018, 07:35:35 UTC, committed by Chromium WPT Sync on 22 March 2018, 07:35:35 UTC
This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object. We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.
KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API
Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();
New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();
Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.
BUG=680809
Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544996}
1 parent 1a8c195
RTCPeerConnection-setLocalDescription-answer.html
<!doctype html>
<meta charset=utf-8>
<title>RTCPeerConnection.prototype.setLocalDescription</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="RTCPeerConnection-helper.js"></script>
<script>
'use strict';
// Test is based on the following editor draft:
// https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html
// The following helper functions are called from RTCPeerConnection-helper.js:
// generateOffer
// generateAnswer
// assert_session_desc_equals
// test_state_change_event
/*
4.3.2. Interface Definition
[Constructor(optional RTCConfiguration configuration)]
interface RTCPeerConnection : EventTarget {
Promise<void> setRemoteDescription(
RTCSessionDescriptionInit description);
readonly attribute RTCSessionDescription? remoteDescription;
readonly attribute RTCSessionDescription? currentRemoteDescription;
readonly attribute RTCSessionDescription? pendingRemoteDescription;
...
};
4.6.2. RTCSessionDescription Class
dictionary RTCSessionDescriptionInit {
required RTCSdpType type;
DOMString sdp = "";
};
4.6.1. RTCSdpType
enum RTCSdpType {
"offer",
"pranswer",
"answer",
"rollback"
};
*/
/*
4.3.1.6. Set the RTCSessionSessionDescription
2.2.2. If description is set as a local description, then run one of the following
steps:
- If description is of type "answer", then this completes an offer answer
negotiation.
Set connection's currentLocalDescription to description and
currentRemoteDescription to the value of pendingRemoteDescription.
Set both pendingRemoteDescription and pendingLocalDescription to null.
Finally set connection's signaling state to stable.
*/
promise_test(t => {
const pc = new RTCPeerConnection();
test_state_change_event(t, pc, ['have-remote-offer', 'stable']);
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => pc.createAnswer())
.then(answer =>
pc.setLocalDescription(answer)
.then(() => {
assert_equals(pc.signalingState, 'stable');
assert_session_desc_equals(pc.localDescription, answer);
assert_session_desc_equals(pc.remoteDescription, offer);
assert_session_desc_equals(pc.currentLocalDescription, answer);
assert_session_desc_equals(pc.currentRemoteDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
})));
}, 'setLocalDescription() with valid answer should succeed');
/*
4.3.2. setLocalDescription
3. Let lastAnswer be the result returned by the last call to createAnswer.
4. If description.sdp is null and description.type is answer, set description.sdp
to lastAnswer.
*/
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => pc.createAnswer())
.then(answer =>
pc.setLocalDescription({ type: 'answer' })
.then(() => {
assert_equals(pc.signalingState, 'stable');
assert_session_desc_equals(pc.localDescription, answer);
assert_session_desc_equals(pc.remoteDescription, offer);
assert_session_desc_equals(pc.currentLocalDescription, answer);
assert_session_desc_equals(pc.currentRemoteDescription, offer);
assert_equals(pc.pendingLocalDescription, null);
assert_equals(pc.pendingRemoteDescription, null);
})));
}, 'setLocalDescription() with type answer and null sdp should use lastAnswer generated from createAnswer');
/*
4.3.2. setLocalDescription
3. Let lastAnswer be the result returned by the last call to createAnswer.
7. If description.type is answer and description.sdp does not match lastAnswer,
reject the promise with a newly created InvalidModificationError and abort these
steps.
*/
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer({ offerToReceiveVideo: true })
.then(offer =>
pc.setRemoteDescription(offer)
.then(() => generateAnswer(offer))
.then(answer =>
promise_rejects(t, 'InvalidModificationError',
pc.setLocalDescription(answer))));
}, 'setLocalDescription() with answer not created by own createAnswer() should reject with InvalidModificationError');
/*
4.3.1.6. Set the RTCSessionSessionDescription
2.3. If the description's type is invalid for the current signaling state of
connection, then reject p with a newly created InvalidStateError and abort
these steps.
[jsep]
5.5. If the type is "pranswer" or "answer", the PeerConnection
state MUST be either "have-remote-offer" or "have-local-pranswer".
*/
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer()
.then(offer =>
promise_rejects(t, 'InvalidStateError',
pc.setLocalDescription({ type: 'answer', sdp: offer.sdp })));
}, 'Calling setLocalDescription(answer) from stable state should reject with InvalidStateError');
promise_test(t => {
const pc = new RTCPeerConnection();
return pc.createOffer()
.then(offer =>
pc.setLocalDescription(offer)
.then(() => generateAnswer(offer)))
.then(answer =>
promise_rejects(t, 'InvalidStateError',
pc.setLocalDescription(answer)));
}, 'Calling setLocalDescription(answer) from have-local-offer state should reject with InvalidStateError');
</script>
Computing file changes ...
