Skip to main content

Browse the archive

Revision b55e29597d92ab89063673f031151e2bdb4b9479 authored by Joe Downing on 22 March 2018, 07:35:35 UTC, committed by Chromium WPT Sync on 22 March 2018, 07:35:35 UTC 
Move KeyboardLock API methods to a 'keyboard' object
 
This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object.  We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.

KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API

Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();

New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();

Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.

BUG=680809

Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544996}
1 parent 1a8c195
Raw File
RTCRtpReceiver-getParameters.html 
<!doctype html>
<meta charset=utf-8>
<title>RTCRtpReceiver.prototype.getParameters</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="dictionary-helper.js"></script>
<script src="RTCRtpParameters-helper.js"></script>
<script>
  'use strict';

  // Test is based on the following editor draft:
  // https://w3c.github.io/webrtc-pc/archives/20170605/webrtc.html

  // The following helper functions are called from RTCRtpParameters-helper.js:
  //   validateReceiverRtpParameters

  /*
    Validates the RTCRtpParameters returned from RTCRtpReceiver.prototype.getParameters

    5.3.  RTCRtpReceiver Interface
      getParameters
        When getParameters is called, the RTCRtpParameters dictionary is constructed
        as follows:

        - encodings is populated based on SSRCs and RIDs present in the current remote
          description, including SSRCs used for RTX and FEC, if signaled. Every member
          of the RTCRtpEncodingParameters dictionaries other than the SSRC and RID fields
          is left undefined.

        - The headerExtensions sequence is populated based on the header extensions that
          the receiver is currently prepared to receive.

        - The codecs sequence is populated based on the codecs that the receiver is currently
          prepared to receive.

        - rtcp.reducedSize is set to true if the receiver is currently prepared to receive
          reduced-size RTCP packets, and false otherwise. rtcp.cname is left undefined.

        - transactionId and degradationPreference are left undefined.
   */
  test(t => {
    const pc = new RTCPeerConnection();
    const { receiver } = pc.addTransceiver('audio');
    const param = pc.getParameters();
    validateReceiverRtpParameters(param);
  });
</script>
back to top