Revision b59e139bbd5c789700aa9cefe7eb6590bc516b86 authored by YOSHIFUJI Hideaki on 30 March 2007, 21:45:35 UTC, committed by David S. Miller on 02 April 2007, 20:30:54 UTC
In article <20070329.142644.70222545.davem@davemloft.net> (at Thu, 29 Mar 2007 14:26:44 -0700 (PDT)), David Miller <davem@davemloft.net> says:

> From: Sridhar Samudrala <sri@us.ibm.com>
> Date: Thu, 29 Mar 2007 14:17:28 -0700
>
> > The check for length in rawv6_sendmsg() is incorrect.
> > As len is an unsigned int, (len < 0) will never be TRUE.
> > I think checking for IPV6_MAXPLEN(65535) is better.
> >
> > Is it possible to send ipv6 jumbo packets using raw
> > sockets? If so, we can remove this check.
>
> I don't see why such a limitation against jumbo would exist,
> does anyone else?
>
> Thanks for catching this Sridhar.  A good compiler should simply
> fail to compile "if (x < 0)" when 'x' is an unsigned type, don't
> you think :-)

Dave, we use "int" for returning value,
so we should fix this anyway, IMHO;
we should not allow len > INT_MAX.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Acked-by: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 31ba548
History
File Mode Size
Kconfig -rw-r--r-- 1.5 KB
Kconfig.iosched -rw-r--r-- 1.9 KB
Makefile -rw-r--r-- 347 bytes
as-iosched.c -rw-r--r-- 37.7 KB
blktrace.c -rw-r--r-- 12.4 KB
cfq-iosched.c -rw-r--r-- 53.0 KB
deadline-iosched.c -rw-r--r-- 11.6 KB
elevator.c -rw-r--r-- 25.1 KB
genhd.c -rw-r--r-- 17.5 KB
ioctl.c -rw-r--r-- 7.4 KB
ll_rw_blk.c -rw-r--r-- 102.4 KB
noop-iosched.c -rw-r--r-- 2.5 KB
scsi_ioctl.c -rw-r--r-- 16.3 KB

back to top