https://github.com/torvalds/linux
Revision b5accbb0dfae36d8d36cd882096943c98d5ede15 authored by Jan Kara on 22 June 2017, 13:31:13 UTC, committed by Mike Marshall on 14 September 2017, 18:54:37 UTC
When new directory 'DIR1' is created in a directory 'DIR0' with SGID bit set, DIR1 is expected to have SGID bit set (and owning group equal to the owning group of 'DIR0'). However when 'DIR0' also has some default ACLs that 'DIR1' inherits, setting these ACLs will result in SGID bit on 'DIR1' to get cleared if user is not member of the owning group. Fix the problem by creating __orangefs_set_acl() function that does not call posix_acl_update_mode() and use it when inheriting ACLs. That prevents SGID bit clearing and the mode has been properly set by posix_acl_create() anyway. Fixes: 073931017b49d9458aa351605b43a7e34598caef CC: stable@vger.kernel.org CC: Mike Marshall <hubcap@omnibond.com> CC: pvfs2-developers@beowulf-underground.org Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Mike Marshall <hubcap@omnibond.com>
1 parent 569dbb8
Tip revision: b5accbb0dfae36d8d36cd882096943c98d5ede15 authored by Jan Kara on 22 June 2017, 13:31:13 UTC
orangefs: Don't clear SGID when inheriting ACLs
orangefs: Don't clear SGID when inheriting ACLs
Tip revision: b5accbb
| File | Mode | Size |
|---|---|---|
| bpf | ||
| cgroup | ||
| configs | ||
| debug | ||
| events | ||
| gcov | ||
| irq | ||
| livepatch | ||
| locking | ||
| power | ||
| printk | ||
| rcu | ||
| sched | ||
| time | ||
| trace | ||
| .gitignore | -rw-r--r-- | 69 bytes |
| Kconfig.freezer | -rw-r--r-- | 52 bytes |
| Kconfig.hz | -rw-r--r-- | 1.6 KB |
| Kconfig.locks | -rw-r--r-- | 4.8 KB |
| Kconfig.preempt | -rw-r--r-- | 2.1 KB |
| Makefile | -rw-r--r-- | 3.9 KB |
| acct.c | -rw-r--r-- | 15.4 KB |
| async.c | -rw-r--r-- | 9.9 KB |
| audit.c | -rw-r--r-- | 62.1 KB |
| audit.h | -rw-r--r-- | 11.0 KB |
| audit_fsnotify.c | -rw-r--r-- | 6.1 KB |
| audit_tree.c | -rw-r--r-- | 23.9 KB |
| audit_watch.c | -rw-r--r-- | 14.6 KB |
| auditfilter.c | -rw-r--r-- | 33.9 KB |
| auditsc.c | -rw-r--r-- | 65.3 KB |
| backtracetest.c | -rw-r--r-- | 2.1 KB |
| bounds.c | -rw-r--r-- | 703 bytes |
| capability.c | -rw-r--r-- | 13.9 KB |
| compat.c | -rw-r--r-- | 16.6 KB |
| configs.c | -rw-r--r-- | 2.8 KB |
| context_tracking.c | -rw-r--r-- | 6.3 KB |
| cpu.c | -rw-r--r-- | 42.9 KB |
| cpu_pm.c | -rw-r--r-- | 6.5 KB |
| crash_core.c | -rw-r--r-- | 11.2 KB |
| crash_dump.c | -rw-r--r-- | 1.3 KB |
| cred.c | -rw-r--r-- | 21.5 KB |
| delayacct.c | -rw-r--r-- | 4.5 KB |
| dma.c | -rw-r--r-- | 3.6 KB |
| elfcore.c | -rw-r--r-- | 396 bytes |
| exec_domain.c | -rw-r--r-- | 1.4 KB |
| exit.c | -rw-r--r-- | 44.2 KB |
| extable.c | -rw-r--r-- | 4.3 KB |
| fork.c | -rw-r--r-- | 58.8 KB |
| freezer.c | -rw-r--r-- | 4.4 KB |
| futex.c | -rw-r--r-- | 93.8 KB |
| futex_compat.c | -rw-r--r-- | 4.5 KB |
| groups.c | -rw-r--r-- | 4.9 KB |
| hung_task.c | -rw-r--r-- | 6.2 KB |
| irq_work.c | -rw-r--r-- | 4.4 KB |
| jump_label.c | -rw-r--r-- | 18.0 KB |
| kallsyms.c | -rw-r--r-- | 16.5 KB |
| kcmp.c | -rw-r--r-- | 5.7 KB |
| kcov.c | -rw-r--r-- | 6.9 KB |
| kexec.c | -rw-r--r-- | 7.0 KB |
| kexec_core.c | -rw-r--r-- | 30.6 KB |
| kexec_file.c | -rw-r--r-- | 25.4 KB |
| kexec_internal.h | -rw-r--r-- | 885 bytes |
| kmod.c | -rw-r--r-- | 20.1 KB |
| kprobes.c | -rw-r--r-- | 62.6 KB |
| ksysfs.c | -rw-r--r-- | 6.3 KB |
| kthread.c | -rw-r--r-- | 32.1 KB |
| latencytop.c | -rw-r--r-- | 7.9 KB |
| membarrier.c | -rw-r--r-- | 2.5 KB |
| memremap.c | -rw-r--r-- | 12.3 KB |
| module-internal.h | -rw-r--r-- | 458 bytes |
| module.c | -rw-r--r-- | 110.4 KB |
| module_signing.c | -rw-r--r-- | 2.2 KB |
| notifier.c | -rw-r--r-- | 16.3 KB |
| nsproxy.c | -rw-r--r-- | 6.5 KB |
| padata.c | -rw-r--r-- | 25.4 KB |
| panic.c | -rw-r--r-- | 15.8 KB |
| params.c | -rw-r--r-- | 23.1 KB |
| pid.c | -rw-r--r-- | 14.9 KB |
| pid_namespace.c | -rw-r--r-- | 11.8 KB |
| profile.c | -rw-r--r-- | 14.8 KB |
| ptrace.c | -rw-r--r-- | 32.7 KB |
| range.c | -rw-r--r-- | 3.0 KB |
| reboot.c | -rw-r--r-- | 13.3 KB |
| relay.c | -rw-r--r-- | 32.1 KB |
| resource.c | -rw-r--r-- | 39.3 KB |
| seccomp.c | -rw-r--r-- | 24.1 KB |
| signal.c | -rw-r--r-- | 95.9 KB |
| smp.c | -rw-r--r-- | 21.3 KB |
| smpboot.c | -rw-r--r-- | 13.3 KB |
| smpboot.h | -rw-r--r-- | 601 bytes |
| softirq.c | -rw-r--r-- | 19.0 KB |
| stacktrace.c | -rw-r--r-- | 1.8 KB |
| stop_machine.c | -rw-r--r-- | 17.1 KB |
| sys.c | -rw-r--r-- | 60.5 KB |
| sys_ni.c | -rw-r--r-- | 7.2 KB |
| sysctl.c | -rw-r--r-- | 73.4 KB |
| sysctl_binary.c | -rw-r--r-- | 50.9 KB |
| task_work.c | -rw-r--r-- | 3.3 KB |
| taskstats.c | -rw-r--r-- | 15.4 KB |
| test_kprobes.c | -rw-r--r-- | 7.4 KB |
| torture.c | -rw-r--r-- | 21.0 KB |
| tracepoint.c | -rw-r--r-- | 14.6 KB |
| tsacct.c | -rw-r--r-- | 5.1 KB |
| ucount.c | -rw-r--r-- | 5.7 KB |
| uid16.c | -rw-r--r-- | 5.0 KB |
| up.c | -rw-r--r-- | 2.0 KB |
| user-return-notifier.c | -rw-r--r-- | 1.3 KB |
| user.c | -rw-r--r-- | 5.4 KB |
| user_namespace.c | -rw-r--r-- | 27.4 KB |
| utsname.c | -rw-r--r-- | 3.6 KB |
| utsname_sysctl.c | -rw-r--r-- | 3.0 KB |
| watchdog.c | -rw-r--r-- | 25.3 KB |
| watchdog_hld.c | -rw-r--r-- | 7.3 KB |
| workqueue.c | -rw-r--r-- | 155.6 KB |
| workqueue_internal.h | -rw-r--r-- | 2.2 KB |
Computing file changes ...
