Skip to main content

Browse the archive

Revision b5d281f6c16dd432b618bdfd36ddba1a58d5b603 authored by Christian Marangi on 19 June 2022, 22:03:51 UTC, committed by Chanwoo Choi on 29 June 2022, 20:11:17 UTC 
PM / devfreq: Rework freq_table to be local to devfreq struct
 
On a devfreq PROBE_DEFER, the freq_table in the driver profile struct,
is never reset and may be leaved in an undefined state.

This comes from the fact that we store the freq_table in the driver
profile struct that is commonly defined as static and not reset on
PROBE_DEFER.
We currently skip the reinit of the freq_table if we found
it's already defined since a driver may declare his own freq_table.

This logic is flawed in the case devfreq core generate a freq_table, set
it in the profile struct and then PROBE_DEFER, freeing the freq_table.
In this case devfreq will found a NOT NULL freq_table that has been
freed, skip the freq_table generation and probe the driver based on the
wrong table.

To fix this and correctly handle PROBE_DEFER, use a local freq_table and
max_state in the devfreq struct and never modify the freq_table present
in the profile struct if it does provide it.

Fixes: 0ec09ac2cebe ("PM / devfreq: Set the freq_table of devfreq device")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
1 parent f44b799
Raw File
Kconfig 
config WARN_MISSING_DOCUMENTS

	bool "Warn if there's a missing documentation file"
	depends on COMPILE_TEST
	help
	   It is not uncommon that a document gets renamed.
	   This option makes the Kernel to check for missing dependencies,
	   warning when something is missing. Works only if the Kernel
	   is built from a git tree.

	   If unsure, select 'N'.

config WARN_ABI_ERRORS
	bool "Warn if there are errors at ABI files"
	depends on COMPILE_TEST
	help
	   The files under Documentation/ABI should follow what's
	   described at Documentation/ABI/README. Yet, as they're manually
	   written, it would be possible that some of those files would
	   have errors that would break them for being parsed by
	   scripts/get_abi.pl. Add a check to verify them.

	   If unsure, select 'N'.
back to top