Revision b5d281f6c16dd432b618bdfd36ddba1a58d5b603 authored by Christian Marangi on 19 June 2022, 22:03:51 UTC, committed by Chanwoo Choi on 29 June 2022, 20:11:17 UTC
On a devfreq PROBE_DEFER, the freq_table in the driver profile struct,
is never reset and may be leaved in an undefined state.

This comes from the fact that we store the freq_table in the driver
profile struct that is commonly defined as static and not reset on
PROBE_DEFER.
We currently skip the reinit of the freq_table if we found
it's already defined since a driver may declare his own freq_table.

This logic is flawed in the case devfreq core generate a freq_table, set
it in the profile struct and then PROBE_DEFER, freeing the freq_table.
In this case devfreq will found a NOT NULL freq_table that has been
freed, skip the freq_table generation and probe the driver based on the
wrong table.

To fix this and correctly handle PROBE_DEFER, use a local freq_table and
max_state in the devfreq struct and never modify the freq_table present
in the profile struct if it does provide it.

Fixes: 0ec09ac2cebe ("PM / devfreq: Set the freq_table of devfreq device")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
1 parent f44b799
History
File Mode Size
.kunitconfig -rw-r--r-- 63 bytes
Kconfig -rw-r--r-- 2.3 KB
Makefile -rw-r--r-- 452 bytes
assert.c -rw-r--r-- 6.2 KB
debugfs.c -rw-r--r-- 2.8 KB
debugfs.h -rw-r--r-- 722 bytes
executor.c -rw-r--r-- 7.1 KB
executor_test.c -rw-r--r-- 6.6 KB
kunit-example-test.c -rw-r--r-- 5.0 KB
kunit-test.c -rw-r--r-- 13.6 KB
resource.c -rw-r--r-- 1.9 KB
string-stream-test.c -rw-r--r-- 1.4 KB
string-stream.c -rw-r--r-- 4.7 KB
string-stream.h -rw-r--r-- 1.2 KB
test.c -rw-r--r-- 17.2 KB
try-catch-impl.h -rw-r--r-- 628 bytes
try-catch.c -rw-r--r-- 2.9 KB

back to top