Skip to main content

Browse the archive

https://github.com/torvalds/linux
17 May 2024, 11:00:25 UTC
Revision b5dd186d10ba59e6b5ba60e42b3b083df56df6f3 authored by Petr Machata on 20 November 2018, 11:39:56 UTC, committed by David S. Miller on 21 November 2018, 23:38:52 UTC 
net: skb_scrub_packet(): Scrub offload_fwd_mark
 
When a packet is trapped and the corresponding SKB marked as
already-forwarded, it retains this marking even after it is forwarded
across veth links into another bridge. There, since it ingresses the
bridge over veth, which doesn't have offload_fwd_mark, it triggers a
warning in nbp_switchdev_frame_mark().

Then nbp_switchdev_allowed_egress() decides not to allow egress from
this bridge through another veth, because the SKB is already marked, and
the mark (of 0) of course matches. Thus the packet is incorrectly
blocked.

Solve by resetting offload_fwd_mark() in skb_scrub_packet(). That
function is called from tunnels and also from veth, and thus catches the
cases where traffic is forwarded between bridges and transformed in a
way that invalidates the marking.

Fixes: 6bc506b4fb06 ("bridge: switchdev: Add forward mark support for stacked devices")
Fixes: abf4bb6b63d0 ("skbuff: Add the offload_mr_fwd_mark field")
Signed-off-by: Petr Machata <petrm@mellanox.com>
Suggested-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent f2cbd48
History
Tip revision: b5dd186d10ba59e6b5ba60e42b3b083df56df6f3 authored by Petr Machata on 20 November 2018, 11:39:56 UTC
net: skb_scrub_packet(): Scrub offload_fwd_mark
Tip revision: b5dd186
File Mode Size
kvm
lib
Makefile -rw-r--r-- 14 bytes
back to top