Revision b5f0549231ffb025337be5a625b0ff9f52b016f0 authored by Dmitry V. Levin on 19 February 2016, 01:27:48 UTC, committed by David S. Miller on 20 February 2016, 04:49:23 UTC
The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
__u32, but unix_lookup_by_ino's argument ino has type int, which is not
a problem yet.
However, when ino is compared with sock_i_ino return value of type
unsigned long, ino is sign extended to signed long, and this results
to incorrect comparison on 64-bit architectures for inode numbers
greater than INT_MAX.
This bug was found by strace test suite.
Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5a0e2f2
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 1017 bytes |
| lglock.c | -rw-r--r-- | 2.5 KB |
| lockdep.c | -rw-r--r-- | 104.6 KB |
| lockdep_internals.h | -rw-r--r-- | 4.5 KB |
| lockdep_proc.c | -rw-r--r-- | 17.3 KB |
| lockdep_states.h | -rw-r--r-- | 233 bytes |
| locktorture.c | -rw-r--r-- | 26.2 KB |
| mcs_spinlock.h | -rw-r--r-- | 3.3 KB |
| mutex-debug.c | -rw-r--r-- | 3.1 KB |
| mutex-debug.h | -rw-r--r-- | 1.7 KB |
| mutex.c | -rw-r--r-- | 25.1 KB |
| mutex.h | -rw-r--r-- | 1.3 KB |
| osq_lock.c | -rw-r--r-- | 5.1 KB |
| percpu-rwsem.c | -rw-r--r-- | 4.4 KB |
| qrwlock.c | -rw-r--r-- | 4.1 KB |
| qspinlock.c | -rw-r--r-- | 13.8 KB |
| qspinlock_paravirt.h | -rw-r--r-- | 15.2 KB |
| qspinlock_stat.h | -rw-r--r-- | 7.8 KB |
| rtmutex-debug.c | -rw-r--r-- | 4.5 KB |
| rtmutex-debug.h | -rw-r--r-- | 1.5 KB |
| rtmutex.c | -rw-r--r-- | 44.5 KB |
| rtmutex.h | -rw-r--r-- | 1.3 KB |
| rtmutex_common.h | -rw-r--r-- | 3.3 KB |
| rwsem-spinlock.c | -rw-r--r-- | 6.7 KB |
| rwsem-xadd.c | -rw-r--r-- | 15.8 KB |
| rwsem.c | -rw-r--r-- | 3.0 KB |
| rwsem.h | -rw-r--r-- | 357 bytes |
| semaphore.c | -rw-r--r-- | 7.3 KB |
| spinlock.c | -rw-r--r-- | 10.1 KB |
| spinlock_debug.c | -rw-r--r-- | 7.1 KB |
Computing file changes ...
